* [PATCH V1 Resend 06/10] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) [not found] <cover.1439375087.git.viresh.kumar@linaro.org> @ 2015-08-12 10:29 ` Viresh Kumar 2015-08-12 10:41 ` Alexandre Belloni 0 siblings, 1 reply; 5+ messages in thread From: Viresh Kumar @ 2015-08-12 10:29 UTC (permalink / raw) To: linux-arm-kernel IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it. gemini driver was using likely() for a failure case while the rtc driver is getting registered. That looks wrong and it should really be unlikely. But because we are killing all the unlikely() flags, lets kill that too. Acked-by: Hans Ulli Kroll <ulli.kroll@googlemail.com> (gemini) Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/rtc/interface.c | 2 +- drivers/rtc/rtc-bfin.c | 2 +- drivers/rtc/rtc-gemini.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index 11b639067312..5836751b8203 100644 --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c @@ -564,7 +564,7 @@ enum hrtimer_restart rtc_pie_update_irq(struct hrtimer *timer) void rtc_update_irq(struct rtc_device *rtc, unsigned long num, unsigned long events) { - if (unlikely(IS_ERR_OR_NULL(rtc))) + if (IS_ERR_OR_NULL(rtc)) return; pm_stay_awake(rtc->dev.parent); diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c index 3d44b11721ea..535a5f9338d0 100644 --- a/drivers/rtc/rtc-bfin.c +++ b/drivers/rtc/rtc-bfin.c @@ -361,7 +361,7 @@ static int bfin_rtc_probe(struct platform_device *pdev) /* Register our RTC with the RTC framework */ rtc->rtc_dev = devm_rtc_device_register(dev, pdev->name, &bfin_rtc_ops, THIS_MODULE); - if (unlikely(IS_ERR(rtc->rtc_dev))) + if (IS_ERR(rtc->rtc_dev)) return PTR_ERR(rtc->rtc_dev); /* Grab the IRQ and init the hardware */ diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c index 35f4486738fc..2fed93e1114a 100644 --- a/drivers/rtc/rtc-gemini.c +++ b/drivers/rtc/rtc-gemini.c @@ -148,7 +148,7 @@ static int gemini_rtc_probe(struct platform_device *pdev) rtc->rtc_dev = rtc_device_register(pdev->name, dev, &gemini_rtc_ops, THIS_MODULE); - if (likely(IS_ERR(rtc->rtc_dev))) + if (IS_ERR(rtc->rtc_dev)) return PTR_ERR(rtc->rtc_dev); return 0; -- 2.4.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH V1 Resend 06/10] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) 2015-08-12 10:29 ` [PATCH V1 Resend 06/10] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) Viresh Kumar @ 2015-08-12 10:41 ` Alexandre Belloni 2015-08-12 10:46 ` Viresh Kumar 0 siblings, 1 reply; 5+ messages in thread From: Alexandre Belloni @ 2015-08-12 10:41 UTC (permalink / raw) To: linux-arm-kernel Hi Viresh, Why are you resending? On 12/08/2015 at 15:59:43 +0530, Viresh Kumar wrote : > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there > is no need to do that again from its callers. Drop it. > > gemini driver was using likely() for a failure case while the rtc driver > is getting registered. That looks wrong and it should really be > unlikely. But because we are killing all the unlikely() flags, lets kill > that too. > > Acked-by: Hans Ulli Kroll <ulli.kroll@googlemail.com> (gemini) > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/rtc/interface.c | 2 +- > drivers/rtc/rtc-bfin.c | 2 +- > drivers/rtc/rtc-gemini.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c > index 11b639067312..5836751b8203 100644 > --- a/drivers/rtc/interface.c > +++ b/drivers/rtc/interface.c > @@ -564,7 +564,7 @@ enum hrtimer_restart rtc_pie_update_irq(struct hrtimer *timer) > void rtc_update_irq(struct rtc_device *rtc, > unsigned long num, unsigned long events) > { > - if (unlikely(IS_ERR_OR_NULL(rtc))) > + if (IS_ERR_OR_NULL(rtc)) > return; > > pm_stay_awake(rtc->dev.parent); > diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c > index 3d44b11721ea..535a5f9338d0 100644 > --- a/drivers/rtc/rtc-bfin.c > +++ b/drivers/rtc/rtc-bfin.c > @@ -361,7 +361,7 @@ static int bfin_rtc_probe(struct platform_device *pdev) > /* Register our RTC with the RTC framework */ > rtc->rtc_dev = devm_rtc_device_register(dev, pdev->name, &bfin_rtc_ops, > THIS_MODULE); > - if (unlikely(IS_ERR(rtc->rtc_dev))) > + if (IS_ERR(rtc->rtc_dev)) > return PTR_ERR(rtc->rtc_dev); > > /* Grab the IRQ and init the hardware */ > diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c > index 35f4486738fc..2fed93e1114a 100644 > --- a/drivers/rtc/rtc-gemini.c > +++ b/drivers/rtc/rtc-gemini.c > @@ -148,7 +148,7 @@ static int gemini_rtc_probe(struct platform_device *pdev) > > rtc->rtc_dev = rtc_device_register(pdev->name, dev, > &gemini_rtc_ops, THIS_MODULE); > - if (likely(IS_ERR(rtc->rtc_dev))) > + if (IS_ERR(rtc->rtc_dev)) > return PTR_ERR(rtc->rtc_dev); > > return 0; > -- > 2.4.0 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V1 Resend 06/10] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) 2015-08-12 10:41 ` Alexandre Belloni @ 2015-08-12 10:46 ` Viresh Kumar 2015-08-12 11:42 ` Alexandre Belloni 0 siblings, 1 reply; 5+ messages in thread From: Viresh Kumar @ 2015-08-12 10:46 UTC (permalink / raw) To: linux-arm-kernel On 12-08-15, 12:41, Alexandre Belloni wrote: > Hi Viresh, > > Why are you resending? I never got a reply from Andrew Morton on V1, so resent it again. And today Andrew asked me to take this via trivial tree. So the resent. I need to find a sane way to get few more people to the cover-letter. The problem is that I am generating the cc-list with get_maintainers, and if I combine that list for all the patches, it becomes huge. And really can't send the cover-letter to those people then. Few lists may block it as well, due to high number of cc'd people. I am telling this because, the cover-letter did contain the reason for resend. -- viresh ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V1 Resend 06/10] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) 2015-08-12 10:46 ` Viresh Kumar @ 2015-08-12 11:42 ` Alexandre Belloni 2015-08-12 11:47 ` Viresh Kumar 0 siblings, 1 reply; 5+ messages in thread From: Alexandre Belloni @ 2015-08-12 11:42 UTC (permalink / raw) To: linux-arm-kernel On 12/08/2015 at 16:16:25 +0530, Viresh Kumar wrote : > On 12-08-15, 12:41, Alexandre Belloni wrote: > > Hi Viresh, > > > > Why are you resending? > > I never got a reply from Andrew Morton on V1, so resent it again. And > today Andrew asked me to take this via trivial tree. > > So the resent. > > I need to find a sane way to get few more people to the cover-letter. > The problem is that I am generating the cc-list with get_maintainers, > and if I combine that list for all the patches, it becomes huge. And > really can't send the cover-letter to those people then. Few lists may > block it as well, due to high number of cc'd people. > > I am telling this because, the cover-letter did contain the reason for > resend. > The fact is that I sent you a mail yesterday stating that I applied that particular patch. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V1 Resend 06/10] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) 2015-08-12 11:42 ` Alexandre Belloni @ 2015-08-12 11:47 ` Viresh Kumar 0 siblings, 0 replies; 5+ messages in thread From: Viresh Kumar @ 2015-08-12 11:47 UTC (permalink / raw) To: linux-arm-kernel On 12-08-15, 13:42, Alexandre Belloni wrote: > The fact is that I sent you a mail yesterday stating that I applied that > particular patch. Urg .. I looked at the 'V1 Resend' series to see which all are applied, and missed your reply on the first version. Sorry about that. -- viresh ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-08-12 11:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1439375087.git.viresh.kumar@linaro.org>
2015-08-12 10:29 ` [PATCH V1 Resend 06/10] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) Viresh Kumar
2015-08-12 10:41 ` Alexandre Belloni
2015-08-12 10:46 ` Viresh Kumar
2015-08-12 11:42 ` Alexandre Belloni
2015-08-12 11:47 ` Viresh Kumar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).