From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8D41CA5506 for ; Thu, 14 Sep 2023 13:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f4KPoxNABs+FaWjYL96GTofOrOoeSvo4Ucp0lUoaZGw=; b=citb+A4d+zyL4d XmK3iQ9BjFdDy3aJ8vWF9JEgznrOrtw/vjXnJ88ZqaaNs7uo6GcdqoN3Qhek83IRjpbTCrbdiAopK CR8lUigRCR1SeZHNvsM9X5eTgE0f6F8w6ApoQOsvvhN5jde590FmyyeBxEA0GN51o7y03G4YINcH8 8bfFO5O9qM4mwst8kkXPstyY+TLc8FVttswhojbWN492PMAvJhCP8xPl7HYfdS0Z5h5xyCe9CnUvp hTXVJHtHryNRb0j9ww8+Wy1tj5AzST/YmXAg5Yrr2IbkyGnKyq36If75S/vvKQTkY0EpunyzER35H EhwyGnHzgHhuOcpaOw3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgm27-008P6c-1W; Thu, 14 Sep 2023 13:05:23 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgm23-008P07-0i for linux-arm-kernel@lists.infradead.org; Thu, 14 Sep 2023 13:05:21 +0000 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 672F724E1D4; Thu, 14 Sep 2023 21:04:17 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 14 Sep 2023 21:04:17 +0800 Received: from [192.168.125.113] (113.72.145.181) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 14 Sep 2023 21:04:16 +0800 Message-ID: <1a9d2905-b0e8-1775-e44f-39d3693a1dad@starfivetech.com> Date: Thu, 14 Sep 2023 21:04:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 13/17] pmdomain: starfive: Move Kconfig file to the pmdomain subsystem To: Conor Dooley , Ulf Hansson CC: Arnd Bergmann , Olof Johansson , , , , Conor Dooley References: <20230914111904.586744-1-ulf.hansson@linaro.org> <20230914-delegator-dimple-51b9414caa28@wendy> Content-Language: en-US From: Walker Chen In-Reply-To: <20230914-delegator-dimple-51b9414caa28@wendy> X-Originating-IP: [113.72.145.181] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_060519_573757_FB64860C X-CRM114-Status: GOOD ( 26.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023/9/14 19:59, Conor Dooley wrote: > Hey, > > > On Thu, Sep 14, 2023 at 01:19:04PM +0200, Ulf Hansson wrote: >> The Kconfig belongs closer to the corresponding implementation, hence let's >> move it from the soc subsystem to the pmdomain subsystem. >> >> Cc: Walker Chen >> Cc: Conor Dooley >> Signed-off-by: Ulf Hansson > > Thanks for doing this, saved me having to! > The series appears to have broken threading though, which can be seen > pretty easily on lore: > https://lore.kernel.org/all/20230914111904.586744-1-ulf.hansson@linaro.org/ > Dunno if something is borked with your process while sending patches to > only a subset of the total recipient list. > >> --- >> MAINTAINERS | 2 +- >> drivers/pmdomain/Kconfig | 1 + >> drivers/{soc => pmdomain}/starfive/Kconfig | 0 >> drivers/soc/Kconfig | 1 - >> 4 files changed, 2 insertions(+), 2 deletions(-) >> rename drivers/{soc => pmdomain}/starfive/Kconfig (100%) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 6b491ebcf790..b8eae18f0fb1 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -20523,7 +20523,7 @@ M: Conor Dooley >> S: Maintained >> T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/ >> F: Documentation/devicetree/bindings/soc/starfive/ >> -F: drivers/soc/starfive/ >> +F: drivers/pmdomain/starfive/ > > This isn't the correct change, just remove the drivers/soc/starfive > bit entirely from this entry. > I've just been doing some review & sending PRs to Arnd for this stuff > (or failing to send the PRs as you saw), I don't have particular > interest in this driver other than helping out the starfive people with > actually getting the code merged. > Instead I think you should generalise the existing entry for the driver > to cover the whole directory, so that it includes the Kconfig bits too: > > diff --git a/MAINTAINERS b/MAINTAINERS > index fa7487b7729b..22c1a5e5b130 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20564,7 +20564,7 @@ M: Walker Chen > M: Changhuang Liang > S: Supported > F: Documentation/devicetree/bindings/power/starfive* > -F: drivers/pmdomain/starfive/jh71xx-pmu.c > +F: drivers/pmdomain/starfive/ > F: include/dt-bindings/power/starfive,jh7110-pmu.h > > STARFIVE SOC DRIVERS > Hi Conor, Anyway, thank you for helping maintain this driver as starfive people lack of experience in this area. You have indeed helped us a lot during this period. Best regards, Walker > Thanks, > Conor. > >> >> STARFIVE TRNG DRIVER >> M: Jia Jie Ho >> diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig >> index cfe9ea754062..67049ebf7265 100644 >> --- a/drivers/pmdomain/Kconfig >> +++ b/drivers/pmdomain/Kconfig >> @@ -12,5 +12,6 @@ source "drivers/pmdomain/renesas/Kconfig" >> source "drivers/pmdomain/rockchip/Kconfig" >> source "drivers/pmdomain/samsung/Kconfig" >> source "drivers/pmdomain/st/Kconfig" >> +source "drivers/pmdomain/starfive/Kconfig" >> >> endmenu >> diff --git a/drivers/soc/starfive/Kconfig b/drivers/pmdomain/starfive/Kconfig >> similarity index 100% >> rename from drivers/soc/starfive/Kconfig >> rename to drivers/pmdomain/starfive/Kconfig >> diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig >> index 8b46da40f107..10a9ff84ff41 100644 >> --- a/drivers/soc/Kconfig >> +++ b/drivers/soc/Kconfig >> @@ -23,7 +23,6 @@ source "drivers/soc/renesas/Kconfig" >> source "drivers/soc/rockchip/Kconfig" >> source "drivers/soc/samsung/Kconfig" >> source "drivers/soc/sifive/Kconfig" >> -source "drivers/soc/starfive/Kconfig" >> source "drivers/soc/sunxi/Kconfig" >> source "drivers/soc/tegra/Kconfig" >> source "drivers/soc/ti/Kconfig" >> -- >> 2.34.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel