Re: [PATCH v10 0/3] firmware: ti_sci: Partial-IO support

[Sebin Francis <sebin.francis@ti.com>]

Hi

On 03/11/25 18:12, Markus Schneider-Pargmann (TI.com) wrote:
> Hi,
> 
> This series adds support for Partial-IO to the ti-sci driver,
> implementing the firmware interface necessary to enter this low power
> state. It processes the wakeup-source properties from the devicetree and
> communicates with the system firmware to enter Partial-IO mode when
> appropriate wakeup sources are enabled.
> 
> Partial-IO Overview
> ------------------
> Partial-IO is a low power system state in which nearly everything is
> turned off except the pins of the CANUART group (mcu_mcan0, mcu_mcan1,
> wkup_uart0 and mcu_uart0). These devices can trigger a wakeup of the
> system on pin activity. Note that this does not resume the system as the
> DDR is off as well. So this state can be considered a power-off state
> with wakeup capabilities.
> 
> A documentation can also be found in section 6.2.4 in the TRM:
>    https://www.ti.com/lit/pdf/spruiv7
> 

[...]

> Changes in v2:
>   - Rebase to v6.11-rc1
>   - dt-binding:
>      - Update commit message
>      - Add more verbose description of the new binding for a better
>        explanation.
>   - ti_sci driver:
>      - Combine ti_sci_do_send() into ti_sci_do_xfer and only wait on a
>        response if a flag is set.
>      - On failure to enter Partial-IO, do emergency_restart()
>      - Add comments
>      - Fix small things
> 
> Signed-off-by: Markus Schneider-Pargmann (TI.com) <msp@baylibre.com>
> ---

Changes looks good.
Reviewed-by: Sebin Francis <sebin.francis@ti.com>

> Markus Schneider-Pargmann (TI.com) (3):
>        firmware: ti_sci: Support transfers without response
>        firmware: ti_sci: Partial-IO support
>        firmware: ti_sci: Remove constant 0 function arguments
> 
>   drivers/firmware/ti_sci.c | 131 +++++++++++++++++++++++++++++++++++++++-------
>   drivers/firmware/ti_sci.h |   5 ++
>   2 files changed, 117 insertions(+), 19 deletions(-)
> ---
> base-commit: c9a389ffad27e7847c69f4d2b67ba56b77190209
> change-id: 20241008-topic-am62-partialio-v6-12-b4-c273fbac4447
> 
> Best regards,