From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C368C43219 for ; Fri, 18 Nov 2022 16:45:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c9loGu28H0BUzZPwlAai48pgwlceMhaqsS7o2xo3uVo=; b=kL0OEig5L4Sbdx y5Ff3kgJyly0ocou3CYzGuBCWT3h4L88ekf4a+Q5GSA71+gpvNrx5KHRIurefdnWVWTUTMtoZfq+g jagqb8a0SghdIXSyYjd37tQ2rU+sjctMpkQuFrToCWsHNmT8x4je1FqLPVmaOCkb26Y83RBOPtrq0 6bbiXIxUf5hbqcce3k17By3ko7lXQgCvyQOZYRM0OBp7q73iz9ShvoewJjGyZYu05ZIEDbOmrqWcy bjdPiQRCtBO2DtjqS2hyHBIRz0ju1mYoRDUJ2mZZ7hVVIQP3AWT/HN7Utax38pDHtCTrtkzdoJ7mm 0lXlczAGBVVqgzmAb5fA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow4TW-005Rqj-GG; Fri, 18 Nov 2022 16:44:22 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow4TS-005RnE-1j for linux-arm-kernel@lists.infradead.org; Fri, 18 Nov 2022 16:44:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668789856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iCeupirs0oRwfAYdrtKDNR33oxtw0kRHF9WhmcxURbs=; b=VbfSdjc8niO8VHnUyJrc4oIYlOOqSHan5D/PXpngB/3qba6I+yNvCqnx4RZkYwd0TURjxz g7+MClW5+ZCQXcxRQOo/crIwRg3gzH+A5P3ZuI25lyhpYqcVqYHt3Qha/y2WfSGM2z6oH1 RwFk5Hf8BS76iAYXSZ9uyRP20+rbGWo= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-486-AfPTzRlBNw68SDZLNodweg-1; Fri, 18 Nov 2022 11:42:38 -0500 X-MC-Unique: AfPTzRlBNw68SDZLNodweg-1 Received: by mail-ed1-f69.google.com with SMTP id dz9-20020a0564021d4900b0045d9a3aded4so3344642edb.22 for ; Fri, 18 Nov 2022 08:42:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iCeupirs0oRwfAYdrtKDNR33oxtw0kRHF9WhmcxURbs=; b=MMlGHvnHTsIeuHKz8P+T6E6zUWj8OdhmcSvb/LI6u0uI4iQRd/P9BEDOlY7F9KkGOz wxCMV/ee4WIA2rGkIxtnL84Sttyr0QUOO2Mm35+Thw4UUrINKi51fe/Y4L7ALyoy9+NN kMBBUswiw/I+L8BzhtOoa83p3xsOLQPMW0f4N8gbHc9sYAnAdM0+Ka1j9dCHKnKblbaA FhKlgoMmtIfUGAD4vDxLg0vrcmXqPcHX3BPYB4mDH9Ihb9CZV3ZHq84Hkutf4p2bLd04 MRajDJb/jHfO0+Qknlax/3G/3MBv7RhkhgHgPmnM9E3Vbnl4zVeMOs3hgtpASw3Kk7PI v4jA== X-Gm-Message-State: ANoB5pkuv/rqpr5ovdfeOU9nYXzUOzgD74q8+cfjF8PQRb7ppeTM0FHC vhNnuROJKSS+QFGNKuEva4R5jf7N2E50HTun8gXv2AO241+6/hpAdMCZMi/7+AdEZ6KOr1Bw/Aj DqtvrpAXLKbXAKfvuuQFulzXGJjDg1LpOH7I= X-Received: by 2002:aa7:d4cf:0:b0:461:a9ce:5408 with SMTP id t15-20020aa7d4cf000000b00461a9ce5408mr6997429edr.201.1668789757508; Fri, 18 Nov 2022 08:42:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf5TaV9WywAgyEkJUjIKk83rbFXBQR8khfDHnlKNNSiUU8k8aohx0CjQn5lly7hEq5+W3BWrVw== X-Received: by 2002:aa7:d4cf:0:b0:461:a9ce:5408 with SMTP id t15-20020aa7d4cf000000b00461a9ce5408mr6997376edr.201.1668789757207; Fri, 18 Nov 2022 08:42:37 -0800 (PST) Received: from [192.168.0.46] (host-95-248-159-81.retail.telecomitalia.it. [95.248.159.81]) by smtp.gmail.com with ESMTPSA id b10-20020a1709063caa00b0073d83f80b05sm1912134ejh.94.2022.11.18.08.42.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 08:42:36 -0800 (PST) Message-ID: <1ab5082c-bec5-53f2-501b-f15f7e8edbd9@redhat.com> Date: Fri, 18 Nov 2022 17:42:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC PATCH v2 8/8] sched, smp: Trace smp callback causing an IPI To: Peter Zijlstra , Valentin Schneider Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, "Paul E. McKenney" , Steven Rostedt , Thomas Gleixner , Sebastian Andrzej Siewior , Juri Lelli , Marcelo Tosatti , Frederic Weisbecker , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Marc Zyngier , Mark Rutland , Russell King , Nicholas Piggin , Guo Ren , "David S. Miller" References: <20221102182949.3119584-1-vschneid@redhat.com> <20221102183336.3120536-7-vschneid@redhat.com> From: Daniel Bristot de Oliveira In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_084418_215778_FC11EEEB X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/18/22 10:12, Peter Zijlstra wrote: > On Thu, Nov 17, 2022 at 02:45:29PM +0000, Valentin Schneider wrote: > >>> + if (trace_ipi_send_cpumask_enabled()) { >>> + call_single_data_t *csd; >>> + smp_call_func_t func; >>> + >>> + csd = container_of(node, call_single_data_t, node.llist); >>> + >>> + func = sched_ttwu_pending; >>> + if (CSD_TYPE(csd) != CSD_TYPE_TTWU) >>> + func = csd->func; >>> + >>> + if (raw_smp_call_single_queue(cpu, node)) >>> + trace_ipi_send_cpumask(cpumask_of(cpu), _RET_IP_, func); >> So I went with the tracepoint being placed *before* the actual IPI gets >> sent to have a somewhat sane ordering between trace_ipi_send_cpumask() and >> e.g. trace_call_function_single_entry(). >> >> Packaging the call_single_queue logic makes the code less horrible, but it >> does mix up the event ordering... > Keeps em sharp ;-) > Having the trace before the IPI avoids the (non ideal) case where the trace stops because of an IPI execution before we have trace about who sent it... :-(. -- Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel