From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21AFBC43461 for ; Fri, 11 Sep 2020 14:35:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8F02222C2 for ; Fri, 11 Sep 2020 14:35:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DgPbBd6l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8F02222C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b4BjaYJwU4JLn+Eonv4YxuXwYXF8xBlEGl1KDsKDwbU=; b=DgPbBd6lRI4BM2binAWblrmvQ IUM2j8FbCwmwhgtR4yKYC3/GzvQGeq+ddMVfX4Mc2nrET2G0VuwJE/T8UzqsLkb+5sBXzE93LbrwL 3a9AQMFlCSjtQCpAWCiWwbSjz17NpNY8oSZKnqhq91EqRfZVd5Wwef2A3UqIExDmfTLqVs+AczAef CLCXyVuB0I03tW4U/TCrn6bE/3WTk57waZcPdj+Ifv/ppgwOoeQQDdio96/vmL20ZatzDMjFP7JbL DlyB7T6iSfyNjqKUM06QGXvc45rA7If4tJaQuD8ltFaoX0Me9+L+S6kkc/l9EW3TRug52+1VtB93l j+t20yphQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGk7S-0002wX-Rn; Fri, 11 Sep 2020 14:33:42 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGk7N-0002v7-UT for linux-arm-kernel@lists.infradead.org; Fri, 11 Sep 2020 14:33:38 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGk7E-0004h8-OX; Fri, 11 Sep 2020 16:33:28 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kGk77-0003hr-RU; Fri, 11 Sep 2020 16:33:21 +0200 Message-ID: <1ac4ba40a031169b968e3084c132579db921033c.camel@pengutronix.de> Subject: Re: [v2,2/3] PCI: mediatek: Add new generation controller support From: Philipp Zabel To: Jianjun Wang , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Ryder Lee Date: Fri, 11 Sep 2020 16:33:21 +0200 In-Reply-To: <20200910034536.30860-3-jianjun.wang@mediatek.com> References: <20200910034536.30860-1-jianjun.wang@mediatek.com> <20200910034536.30860-3-jianjun.wang@mediatek.com> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200911_103337_987707_8F2606F7 X-CRM114-Status: GOOD ( 18.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mauro Carvalho Chehab , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Sj Huang , linux-mediatek@lists.infradead.org, Matthias Brugger , davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jianjun, On Thu, 2020-09-10 at 11:45 +0800, Jianjun Wang wrote: > MediaTek's PCIe host controller has three generation HWs, the new > generation HW is an individual bridge, it supoorts Gen3 speed and > up to 256 MSI interrupt numbers for multi-function devices. > > Add support for new Gen3 controller which can be found on MT8192. > > Signed-off-by: Jianjun Wang > Acked-by: Ryder Lee > --- > drivers/pci/controller/Kconfig | 14 + > drivers/pci/controller/Makefile | 1 + > drivers/pci/controller/pcie-mediatek-gen3.c | 1076 +++++++++++++++++++ > 3 files changed, 1091 insertions(+) > create mode 100644 drivers/pci/controller/pcie-mediatek-gen3.c > [...] > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c > new file mode 100644 > index 000000000000..f8c8bdf88d33 > --- /dev/null > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c [...] > +static int mtk_pcie_power_up(struct mtk_pcie_port *port) > +{ > + struct device *dev = port->dev; > + int err; > + > + port->phy_reset = devm_reset_control_get_optional(dev, "phy-rst"); Please use devm_reset_control_get_optional_exclusive() instead. > + if (PTR_ERR(port->phy_reset) == -EPROBE_DEFER) > + return PTR_ERR(port->phy_reset); This should be if (IS_ERR(port->phy_reset)) return PTR_ERR(port->phy_reset); there is no reason to continue if this throws -ENOMEM, for example. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel