* [PATCH] mt76: mt7615: check devm_kasprintf() returned value
@ 2024-09-05 1:47 Ma Ke
2024-09-05 8:01 ` Matthias Brugger
0 siblings, 1 reply; 2+ messages in thread
From: Ma Ke @ 2024-09-05 1:47 UTC (permalink / raw)
To: nbd, lorenzo, ryder.lee, shayne.chen, sean.wang, kvalo,
matthias.bgg, angelogioacchino.delregno, ruanjinjie, make24
Cc: linux-wireless, linux-kernel, linux-arm-kernel, linux-mediatek,
stable
devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.
Found by code review.
Cc: stable@vger.kernel.org
Fixes: 0bb4e9187ea4 ("mt76: mt7615: fix hwmon temp sensor mem use-after-free")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
drivers/net/wireless/mediatek/mt76/mt7615/init.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
index f7722f67db57..0b9ebdcda221 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
@@ -56,6 +56,9 @@ int mt7615_thermal_init(struct mt7615_dev *dev)
name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7615_%s",
wiphy_name(wiphy));
+ if (!name)
+ return -ENOMEM;
+
hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, dev,
mt7615_hwmon_groups);
return PTR_ERR_OR_ZERO(hwmon);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mt76: mt7615: check devm_kasprintf() returned value
2024-09-05 1:47 [PATCH] mt76: mt7615: check devm_kasprintf() returned value Ma Ke
@ 2024-09-05 8:01 ` Matthias Brugger
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2024-09-05 8:01 UTC (permalink / raw)
To: Ma Ke, nbd, lorenzo, ryder.lee, shayne.chen, sean.wang, kvalo,
angelogioacchino.delregno, ruanjinjie
Cc: linux-wireless, linux-kernel, linux-arm-kernel, linux-mediatek,
stable
On 05/09/2024 03:47, Ma Ke wrote:
> devm_kasprintf() can return a NULL pointer on failure but this returned
> value is not checked. Fix this lack and check the returned value.
>
> Found by code review.
>
> Cc: stable@vger.kernel.org
> Fixes: 0bb4e9187ea4 ("mt76: mt7615: fix hwmon temp sensor mem use-after-free")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
If you find more problems of that sort in the mediatek wireless drivers, I think
a better approach would be to send them all as one patch.
> ---
> drivers/net/wireless/mediatek/mt76/mt7615/init.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> index f7722f67db57..0b9ebdcda221 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> @@ -56,6 +56,9 @@ int mt7615_thermal_init(struct mt7615_dev *dev)
>
> name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7615_%s",
> wiphy_name(wiphy));
> + if (!name)
> + return -ENOMEM;
> +
> hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, dev,
> mt7615_hwmon_groups);
> return PTR_ERR_OR_ZERO(hwmon);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-05 8:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-05 1:47 [PATCH] mt76: mt7615: check devm_kasprintf() returned value Ma Ke
2024-09-05 8:01 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).