From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Tomeu Vizoso" <tomeu@tomeuvizoso.net>,
"Nishanth Menon" <nm@ti.com>, "Andrew F. Davis" <afd@ti.com>,
"Randolph Sapp" <rs@ti.com>,
"Jonathan Humphreys" <j-humphreys@ti.com>,
"Andrei Aldea" <a-aldea@ti.com>,
"Chirag Shilwant" <c-shilwant@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Tero Kristo" <kristo@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Oded Gabbay" <ogabbay@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-doc@vger.kernel.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org,
Tomeu Vizoso <tomeu@tomeuvizoso.net>
Subject: Re: [PATCH 4/5] accel/thames: Add IOCTL for job submission
Date: Wed, 14 Jan 2026 14:04:44 +0200 [thread overview]
Message-ID: <1acdffd8f05eae0a3531d43d3919d8bd4558f37a@intel.com> (raw)
In-Reply-To: <20260113-thames-v1-4-99390026937c@tomeuvizoso.net>
On Tue, 13 Jan 2026, Tomeu Vizoso <tomeu@tomeuvizoso.net> wrote:
> +#include "linux/dev_printk.h"
Random drive-by comment, please use <> instead of "" for include/
headers.
> +#include <drm/drm_file.h>
> +#include <drm/drm_gem.h>
> +#include <drm/drm_print.h>
> +#include <drm/thames_accel.h>
> +#include <linux/platform_device.h>
In general, I think it will make everyone's life easier in the long run
if the include directives are grouped and sorted.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-01-14 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 17:44 [PATCH 0/5] New DRM accel driver for Texas Instruments' C7x DSPs Tomeu Vizoso
2026-01-13 17:44 ` [PATCH 1/5] arm64: dts: ti: k3-j722s-ti-ipc-firmware: Add memory pool for DSP i/o buffers Tomeu Vizoso
2026-01-13 17:44 ` [PATCH 2/5] accel/thames: Add driver for the C7x DSPs in TI SoCs Tomeu Vizoso
2026-01-13 18:22 ` Robert Nelson
2026-01-14 12:08 ` Jani Nikula
2026-01-13 17:44 ` [PATCH 3/5] accel/thames: Add IOCTLs for BO creation and mapping Tomeu Vizoso
2026-01-13 17:44 ` [PATCH 4/5] accel/thames: Add IOCTL for job submission Tomeu Vizoso
2026-01-14 8:57 ` Christian König
2026-01-14 12:04 ` Jani Nikula [this message]
2026-01-13 17:44 ` [PATCH 5/5] accel/thames: Add IOCTL for memory synchronization Tomeu Vizoso
2026-01-14 9:02 ` [PATCH 0/5] New DRM accel driver for Texas Instruments' C7x DSPs Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1acdffd8f05eae0a3531d43d3919d8bd4558f37a@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=a-aldea@ti.com \
--cc=afd@ti.com \
--cc=c-shilwant@ti.com \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=j-humphreys@ti.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nm@ti.com \
--cc=ogabbay@kernel.org \
--cc=robh@kernel.org \
--cc=rs@ti.com \
--cc=sumit.semwal@linaro.org \
--cc=tomeu@tomeuvizoso.net \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox