From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD817C4706F for ; Fri, 29 Dec 2023 01:28:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BzPPEoRkz+X30i5BpXS0tXvTez5FK8c2kv3csXWVNCo=; b=1uRG6go2++MY+1 JGFrkNeV9O4yMBym9D8TGa5NTOcnKHSDkntu18tG1dBEtndMOUQBGg/+/vZIE2j9edba1ZU9AGLOa +TPNQq6/KWVWVUoOk7Wggp2aPcXd7guwThDBbc+h3hEyT+XwNmvSpGCEZaO1vC5NNBXx/7mEl9exQ CdWlH9drvGrdWU/dUhTJI6fhwJrEk2viY9TiUFnpzxz7yT9FzdOxcRCVk+r3N+miqGOzUw+KIfVM9 SDEzCBB8+pmJIggmhMedFfojqhtcou98WOHCOuNLdGwZuHEExHX0+HTfa8cubeXaO6+tnLWIwLUa5 KSPi5z5/58ftd3+g7g+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rJ1en-00029P-0T; Fri, 29 Dec 2023 01:27:25 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rJ1ei-00027l-0K; Fri, 29 Dec 2023 01:27:21 +0000 X-UUID: 60ea9234a5e911eeafd70d0b34820190-20231228 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=UB9FV4Zh3w7vsXP7MgduU31Cz6sRW+ibus/Q4YAzwhc=; b=n9DCibkLjrTp1n0XMgN5Emqy4lVatAQw8UCYa4rXNTYZZ7oSABJCufVACbGib0TBDdBUpAINvWfExzMKfBFHIHxRS4OEGvs13y+VDfD9+txuueCCHyjt9+ru/uMcTZ9Ng6yRLyr6jkwi2K6AW3grMc0moprOoAVce/R3xulHmS8=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:8de23c05-de65-4bdc-93c7-70a0fb9612fb,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5d391d7,CLOUDID:092c992e-1ab8-4133-9780-81938111c800,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR: NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULN X-UUID: 60ea9234a5e911eeafd70d0b34820190-20231228 Received: from mtkmbs14n2.mediatek.inc [(172.21.101.76)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1863179100; Thu, 28 Dec 2023 18:27:06 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 29 Dec 2023 09:27:03 +0800 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 29 Dec 2023 09:27:03 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bukdZyq3O41YH288TtMGtEsCYHis++ZbG+xDjl67WRgEzmV3M3VCg2QhDJJZcwHKxjFVyJ0E1RkXgLE8nqJ7PvJgJyV0gHCac7rvhMu0PW73YVwZlennHJscpSc/rKja0lhUsdKXkbhDRFndqEftbUTWDF9sVbAcbzMb3uNQIaVqnGti1q2SFdinLgKmkSTRxGaplw8U5d2wknYpd85YMgwHdyJ9tMDi+H/PurcDlopMTdkCTb3YpJKW07Q5DqhHEcmd+nFmgxJOqOcw8QanpIjaU1wrEHY5l+9RTpWaKgGbUhKzSYS968900ynJHqpu7RfxXA15mo36y2pIE9Hxog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UB9FV4Zh3w7vsXP7MgduU31Cz6sRW+ibus/Q4YAzwhc=; b=LbDIKtO27HxbF6BNb4oPdO1Ya7CQ8sQTm8sCICEk7GRYCd5QwPdio9YiSFVhP8zmbGXe4l27dg+wgj1rvuK5B0hEKDp7tODgBtEmW9QesB7shGnUdCRwHvUmu2YNIfXMg+R+NhGWAQh3kk4h05P3AaewXW1iv/sUrzZfktCwHAnntrCX86M73WM6YqN80iltAiGc2ht0jUgq6tldmBuPD/iiXLXDLFqLUEbmO1//qthEUVdjt4cQZjpgEdLZ66sViPJXnwOZjVFziWwK8AtGxfLnajRbCLM8tBa/6gs9H/H/vg3c0a8HptWUX3s/z9lcmLXBp7ga0PsdM68kHYlCpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UB9FV4Zh3w7vsXP7MgduU31Cz6sRW+ibus/Q4YAzwhc=; b=Co3WR0TN16MXvHkavmUVD2Vhbe1GPtasN5w+FHhMREnWl+SwkAU+3mqY/O9x8mWlkVfIUEreDxLcWMbsPr6Flpd7UPVD6Ydb0e5gV0ZUNCM1RT/RmZbxikUHMmstaY3Q/zCjV6UTaU1wl7pYuDTELAapSVunH3ovxhd2tsDD3e8= Received: from TYZPR03MB6624.apcprd03.prod.outlook.com (2603:1096:400:1f4::13) by PSAPR03MB5302.apcprd03.prod.outlook.com (2603:1096:301:40::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.21; Fri, 29 Dec 2023 01:27:01 +0000 Received: from TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::eb43:57cb:edfd:3762]) by TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::eb43:57cb:edfd:3762%7]) with mapi id 15.20.7135.019; Fri, 29 Dec 2023 01:27:01 +0000 From: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= To: "jassisinghbrar@gmail.com" , "matthias.bgg@gmail.com" , =?utf-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "angelogioacchino.delregno@collabora.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "chunkuang.hu@kernel.org" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?utf-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , =?utf-8?B?Sm9obnNvbiBXYW5nICjnjovogZbpkasp?= , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , =?utf-8?B?SmFzb24tY2ggQ2hlbiAo6Zmz5bu66LGqKQ==?= , =?utf-8?B?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= , "mchehab@kernel.org" , =?utf-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "conor+dt@kernel.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 8/9] mailbox: mediatek: Add CMDQ secure mailbox driver Thread-Topic: [PATCH v3 8/9] mailbox: mediatek: Add CMDQ secure mailbox driver Thread-Index: AQHaNJMHlgU6p3MSPUCi0pus2NsH47C/gxcA Date: Fri, 29 Dec 2023 01:27:00 +0000 Message-ID: <1b21f5bfa561b049193742804de42a1c03500a73.camel@mediatek.com> References: <20231222045228.27826-1-jason-jh.lin@mediatek.com> <20231222045228.27826-9-jason-jh.lin@mediatek.com> In-Reply-To: <20231222045228.27826-9-jason-jh.lin@mediatek.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6624:EE_|PSAPR03MB5302:EE_ x-ms-office365-filtering-correlation-id: 1d67aca3-45c8-4fc1-7c48-08dc080d41b5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8JsdUz6K9zGwxTyLp9TRSfccH6ckMzbpZmdND9VC0EAJo30SDwqKKPXwf25vOYOPCIkZhBQZJuCEAB0B+G96nnOWtCO4LjDiSQb984PMk4b0p2wHl3kstoywWr51oGgsDrA3e+xMMt2liZKyNmjW9sEfRIb61lp8VS5n1mpZYVdxyDpCDl7UlGZsKzJWtK3eoyUX8woSNWrDa5C633I6os9ZquCSY/0tQIX5NOwfTOMe5ReF60ogaY+ypwR+vPvUExT7dk3FO9gCb2WJK6NuAjG5oFcDe+4/oL857k+Zm9DXegTrYXN2JjAgjSo1YQaDRXP94BdZAStxtlGYlmDK6gR9oPek0HutR1S0DivfjSeSzrRKE/oWXV1pMeb2qr40iP//NRn2reIvM3Mg7N/GLAGdFJb4u/sFxV0lhbwa2acl1KRnu9iBWwufA6bLdcLxHi4nrogZ+Rr/Qb+CuSNbGrgkYekrHBRIniNStlndaoPAvtGoP3+JDAJPdiLrJER+Ts9u+n6QNnJxN3d61B/IO7DlfG/o4VdLVQN3FTS99yDkJcKCDX21xjj/1N4IILfksMNDhsXYqeojdvcLYKLQfG5VcVgJ+Fmly8XgXwIvkYv6wnirPyKIyXXuxdfNTIMv1sRYofMdh6BIvJ4Fix4hQHunxYq+fKmpBACES+Q1KoI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6624.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(136003)(376002)(39860400002)(346002)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(41300700001)(83380400001)(2906002)(4001150100001)(54906003)(66946007)(76116006)(66476007)(64756008)(66446008)(66556008)(110136005)(316002)(6512007)(38070700009)(122000001)(71200400001)(6506007)(478600001)(26005)(2616005)(38100700002)(86362001)(6486002)(15650500001)(5660300002)(7416002)(8676002)(8936002)(85182001)(4326008)(36756003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UHAyRjV0eFliRnp4T2RiNVVza0RVWnQySmRISkRsNGxIMzljR3czcGVDampD?= =?utf-8?B?WHlVVTFqaHpVSkZzQm5INTV0eHZaSWVINUE4UGd0VU9pbzZUbUx2QllDdXc2?= =?utf-8?B?cU1TMzkydjV2SjIwUmI1dHdPMnREdnJWRXB1S2c5TFgrdGxXclltTVgyd0J1?= =?utf-8?B?Z2lEd29TNHFmZy9LSlZ1ZVN4RnhYUU5JdlFKN2tUOWZocXFaRjMybzI1ZlRG?= =?utf-8?B?dUFpZDFBODJhazBXejBpVlZIcFAxTnROUGJ4eVVvdHZPd1NsMXJWbFgwdXpv?= =?utf-8?B?NUNaTUxjL1dWM1o3aTY2ekF6OUNhYXZVSTI4OENTUDZaS0dMbjRxSE1KVVNx?= =?utf-8?B?NUlVYThsd0RKaUNDMWc0SCtVbWlmNEtuVnFxZGpwaC9HeUlVdzBIejE1VTVv?= =?utf-8?B?a1ZVMDVIaXBaRHlPNFMwOWI2Wm1uUXVJVzVUZ2xiKzdQQTNtQ01HeURyS1p3?= =?utf-8?B?SlRuaTRrNWd1aGZPWjF2dkVLYnpMdDRvTXMvYTlsbG5rV1NLNU9VbGtQdDhs?= =?utf-8?B?azVQN0RHVWlpWnRDdTBFME5lWjFPKzBKbjJ6UythM010d2tZbzBpb2JXUjBS?= =?utf-8?B?c3pYTG1RV3RkTEZTeWVTaVhvd2dEUnVvU3BVeEtXREVhVlNpWFNZS3hSSWZY?= =?utf-8?B?ZjZ2TEQ5eWJ4eWQ2aDJYcnQ5L3NqVlRBREk2QmFsUFZRdG1DK2hxQVR6cFdG?= =?utf-8?B?Mzh4aGhoWWRrQVBVNE1md2NlV1FpRVo1UG4wOUlKajZyZzRUWis0MnR2bGlV?= =?utf-8?B?ckZxbkwzWk4yU2M0R2UyVituTWNDTmQ4Z0Y3c096azI2K1NIQ2J0cnVWeVAw?= =?utf-8?B?cExCNlBHRHRJNlIyNys3TkV2bk53RTl5b25mRDRQWVBETkxzZ3JyUHoxYXJj?= =?utf-8?B?QjB3ZnNFNXpKM2JvditjWk80RUwzdXRBSGFpaE1ONCswanFDeGptVURrZXhB?= =?utf-8?B?Z25SYWNreDZVVlJuV2hrakZGWXVDSW9WWGp1WWRnNmhpQ0hzSXIrYTVJSVBo?= =?utf-8?B?VnhWYmJRSFpOZXh0YzBOZFZ3Q0h1YjN5SWwyZE4wMmxmdklZTUk0YVdWZnBi?= =?utf-8?B?OTJvUm1yNkVrZE5DLzlzMUdlMmNZays4WTdCdFlmaWh2TUI2eWJ0RlpHbzZG?= =?utf-8?B?MmdFY3BDY0kzYnNZTjNBUDRYZ1BFZVROMHdRV01OclFCREx0dTBFZFU2NWx3?= =?utf-8?B?c3RKMUFxUzZMM2VzQlVzb25Ta0QwYlhzcnVFcjJ2dllBUkhSd0crQjdpZEUx?= =?utf-8?B?SGZzYnZJZHJJQW9yaXJTYVpMbHZlcTlESUxnanIzQjJ6TEJKVE1qRUQxTjd0?= =?utf-8?B?Qm85MHdTTGFrVEFZZDFtM3RaVTlqU2kwZXlnUXlNSzN1dzV5Q1VPWkxqMHdQ?= =?utf-8?B?am40dXMwSDZqcEdMelFaZTF0ak9KZ2FXMnJZZVFZREJDTERmeGJ0THZlWE5u?= =?utf-8?B?SFNHY3VvM2VMQ0lhUGUvallwVi91Ly9tMHI4d0N6Z2Vadm50ZTMrYVZQbmZI?= =?utf-8?B?UXZydkExc0N2QXptRlFwV1MyRWtTQjkrc2dMSm40NWgyLytnanJhUm53MG5P?= =?utf-8?B?aE50dEsraDVyRlJlODVDMmhBS2JZNEFsNUs5RVJWcDRvVUFQNTZSTlJBTTIx?= =?utf-8?B?ZkczTjdoUWNNTGkzYVpiT0o3MEhobDUwNklPalJ6L3NLUGtyTHBtSk9qTlUv?= =?utf-8?B?S056SUtLbmtlazdwSnV0Qyt3ZVRXYnU5NVVjVHpQYU44SkZ4TFQ3OVN4d25r?= =?utf-8?B?RmEvcEJWS2xkV3NOUjZmN1MvTmRqN0RUU0FaU0ZEZDcyQ0RmaDR2THJDWFVr?= =?utf-8?B?TmVFUURENW5GNXMvYWFLdlJsc0VCc0xWODNJbmZxT0t4aEliSDhUM0VPeGFi?= =?utf-8?B?TUt0NVM4RWxJcnRvSUlkRkpxblUzYTNTa1UwZTVWTGpBTWhvQSsyR1NvcURZ?= =?utf-8?B?MHVhc3RpTDZWK25YTkRPZFlHWk5Za1BKZWhpdXg5MStPbkxLUlhUdkNzVVdV?= =?utf-8?B?UysxWmlLV2FlakNpNDcrYlZJZytMSEcySTY2VjI5QmpPT2pHSnBFamsxeUNG?= =?utf-8?B?bHI3Qllzc2pmeWI5dXNuTEhhSzJoQjB0Q3l6c09mM0lEZjNObUtBVkZZQy9n?= =?utf-8?Q?A/nIMZ/YA7w3T15GF+WHwKtqF?= Content-ID: <6D4A100A98650649AF99087C1404DAD7@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6624.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d67aca3-45c8-4fc1-7c48-08dc080d41b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2023 01:27:00.9758 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U/0aCcY6tFGJYmmJOXRxkfvn1E3CwNrezVfn7FsOG0ZcVOn69IdUNwBq/JifSTluW2/7mc6xcm64pcRhgqm80A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR03MB5302 X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--17.298800-8.000000 X-TMASE-MatchedRID: QfHZjzml1E8OwH4pD14DsPHkpkyUphL9qQ9UezeTkThu4FknyqyshF1Q po5pNysMe29pTfBhqOY7b3Js3F6vVD1LciJB3541o65WJt1k1O8TbU1KYGoQp3vsbfoZixUT3oz JRX7b4NlXDMdLGLREMMXK8CR3a95BwkdUVZ4wAsQdxBAG5/hkW9qgUkBwIfKYrcsFdtecvlP6p1 jlhLAJAvcqU4dInnrp5tlnPJX7htRoAILruplAqrdQIb8hCnY+I7OxeNfmD+wIxs8bpapULKPFj JEFr+olFUew0Fl/1pEBi3kqJOK62QtuKBGekqUpI/NGWt0UYPCQjpWlTG6/YrkraxDde6naBUVv b7IBJzEH5eyzBoWGRHPmli6osFKp X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--17.298800-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: AD86BE1E1160C73C4DD29A134235C7DBEC29837991A2530FB21E33118AE90AE82000:8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231228_172720_152141_AB74ABCE X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Jason: On Fri, 2023-12-22 at 12:52 +0800, Jason-JH.Lin wrote: > To support secure video path feature, GCE have to read/write > registgers > in the secure world. GCE will enable the secure access permission to > the > HW who wants to access the secure content buffer. > > Add CMDQ secure mailbox driver to make CMDQ client user is able to > sending their HW settings to the secure world. So that GCE can > execute > all instructions to configure HW in the secure world. > > Signed-off-by: Jason-JH.Lin > --- [snip] > + > +static int cmdq_sec_session_send(struct cmdq_sec_context *context, > + struct cmdq_sec_task *sec_task, const > u32 iwc_cmd, > + const u32 thrd_idx, struct cmdq_sec > *cmdq) > +{ > + int err = 0; > + u64 cost; > + struct iwc_cmdq_message_t *iwc_msg = NULL; > + > + iwc_msg = (struct iwc_cmdq_message_t *)context->iwc_msg; > + > + memset(iwc_msg, 0, sizeof(*iwc_msg)); > + iwc_msg->cmd = iwc_cmd; > + iwc_msg->cmdq_id = cmdq->pdata->hwid; > + iwc_msg->command.thread = thrd_idx; > + > + switch (iwc_cmd) { > + case CMD_CMDQ_IWC_SUBMIT_TASK: > + err = cmdq_sec_fill_iwc_msg(context, sec_task, > thrd_idx); > + if (err) > + return err; > + break; > + case CMD_CMDQ_IWC_CANCEL_TASK: > + iwc_msg->cancel_task.wait_cookie = sec_task- > >wait_cookie; > + iwc_msg->cancel_task.thread = thrd_idx; > + break; > + case CMD_CMDQ_IWC_PATH_RES_ALLOCATE: > + if (!cmdq->shared_mem || !cmdq->shared_mem->va) { > + dev_err(cmdq->mbox.dev, "%s %d: shared_mem is > NULL", __func__, __LINE__); > + return -EFAULT; > + } > + iwc_msg->path_resource.size = cmdq->shared_mem->size; > + iwc_msg->path_resource.share_memoy_pa = cmdq- > >shared_mem->pa; > + iwc_msg->path_resource.use_normal_irq = 1; > + break; > + default: > + break; > + } > + > + cmdq->sec_invoke = sched_clock(); > + dev_dbg(cmdq->mbox.dev, "%s execute cmdq:%p sec_task:%p > command:%u thread:%u cookie:%d", > + __func__, cmdq, sec_task, iwc_cmd, thrd_idx, > + sec_task ? sec_task->wait_cookie : -1); > + > + /* send message */ > + err = cmdq_sec_execute_session(&context->tee_ctx, iwc_cmd, > CMDQ_TIMEOUT_DEFAULT); > + > + cmdq->sec_done = sched_clock(); > + cost = div_u64(cmdq->sec_done - cmdq->sec_invoke, 1000000); > + if (cost >= CMDQ_TIMEOUT_DEFAULT) Maybe for some client driver, 1 ms is too long, and for some client driver 1 second is not long. So I think the timeout detection should be done by client driver. And the execution time depend on the command buffer generated by client driver, so only client driver has the ability to debug the command buffer it generated. So it's not necessary to detect timeout in cmdq driver. Regards, CK > + dev_err(cmdq->mbox.dev, "%s execute timeout cmdq:%p > sec_task:%p cost:%lluus", > + __func__, cmdq, sec_task, cost); > + else > + dev_dbg(cmdq->mbox.dev, "%s execute done cmdq:%p > sec_task:%p cost:%lluus", > + __func__, cmdq, sec_task, cost); > + > + if (err) > + return err; > + > + context->state = IWC_SES_ON_TRANSACTED; > + return 0; > +} > + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel