From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3B0EC4332F for ; Tue, 8 Nov 2022 16:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pyR+B4xVJIhTDB8pH2tPNy7LBhzaxFUkMbdEn0HyNEM=; b=yDrNQgPl58j/cu ESL4B+LLm+0R0H+81u+GIwIxuVboH5Yc0uQcofsd6XpFaEDy/84sPkr9n688y9JzBkYhRRQQoqb6T x8SYf8Vtp+ev+M2UcFYNqsxgNbGZWR/C2Cg5dH31RfUHUw3sVSifRxzVJO3cQAefFWGNdEtagt1m7 ALOcoHBUXbHTO/7qfi/Woej1dC1hu6B+SeYQkMet2LeWF1kbUke87YjS2w856cMwQxvqMFe1kbacP +DW0hB1sxrW9k+FUuEiZ1VcWxAhixT9ofuZnNJor4vYZolzS4vboR4rzmhXJTTl9BpvvXyYvZKVxq SzdUnaNMFFB/99S2strw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osRuL-006nbC-1V; Tue, 08 Nov 2022 16:57:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osRuH-006nQw-8c; Tue, 08 Nov 2022 16:57:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D30E1FB; Tue, 8 Nov 2022 08:57:00 -0800 (PST) Received: from [10.57.5.11] (unknown [10.57.5.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F1FCB3F703; Tue, 8 Nov 2022 08:56:50 -0800 (PST) Message-ID: <1b2f25e5-cd60-a533-14be-a608f4c801bd@arm.com> Date: Tue, 8 Nov 2022 17:56:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 3/5] ACPI: PPTT: Remove acpi_find_cache_levels() To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Gavin Shan , Peter Chen , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org References: <20221108110424.166896-1-pierre.gondois@arm.com> <20221108110424.166896-4-pierre.gondois@arm.com> <20221108161315.lmm3sakza5quyzlv@bogus> Content-Language: en-US From: Pierre Gondois In-Reply-To: <20221108161315.lmm3sakza5quyzlv@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221108_085701_395956_7692A2AF X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/8/22 17:13, Sudeep Holla wrote: > On Tue, Nov 08, 2022 at 12:04:19PM +0100, Pierre Gondois wrote: >> acpi_find_cache_levels() is used at a single place and is short >> enough to be merged into the calling function. The removal allows >> an easier renaming of the calling function in the next patch. >> >> Also reorder the parameters in the 'reversed Christmas tree' order. > > Not sure if the above is worth mentioning explicitly. Even if you do, > 'parameters' sounds very confusing to at-least me. I was searching for > the changes is some function parameters to understand what it was and > finally realised you meant the stack variable declaration order here. > Right ? Yes right, I will use another word. > > > Other than that, it looks good. > > Reviewed-by: Sudeep Holla > Regards, Pierre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel