From: Michael Walle <michael@walle.cc>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, Peng Fan <peng.fan@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: issue: could not get #nvmem-cell-cells
Date: Tue, 10 Jan 2023 11:47:08 +0100 [thread overview]
Message-ID: <1b4ac08c5ff53180db4aeddd944f85cf@walle.cc> (raw)
In-Reply-To: <13180287.uLZWGnKmhe@steina-w>
[+ Rob and Krzysztof]
Am 2023-01-10 11:32, schrieb Alexander Stein:
> Hi Michael,
>
> Am Dienstag, 10. Januar 2023, 09:12:26 CET schrieb Michael Walle:
>> Hi Peng,
>>
>> Am 2023-01-10 09:07, schrieb Peng Fan:
>> > I see you have added nvmem-cell-cells support, but with linux-next, I
>> > see error on i.MX8MP-EVK:
>> > [ 0.027518] OF: /soc@0: could not get #nvmem-cell-cells for
>> > /soc@0/bus@30000000/efuse@30350000/unique-id@8
>> > [ 0.027868] OF: /soc@0/bus@30000000/tmu@30260000: could not get
>> > #nvmem-cell-cells for /soc@0/bus@30000000/efuse@30350000/calib@264
>> > [ 0.030338] OF: /soc@0/bus@30800000/ethernet@30be0000: could not
>> > get #nvmem-cell-cells for
>> > /soc@0/bus@30000000/efuse@30350000/mac-address@90
>> > [ 0.030511] OF: /soc@0/bus@30800000/ethernet@30bf0000: could not
>> > get #nvmem-cell-cells for
>> > /soc@0/bus@30000000/efuse@30350000/mac-address@96
>> >
>> > Do you have ideas?
>>
>> Do you have [1] applied? It is already in -next but just to be sure.
>
> This patch does fix requesting a non-existing io_impedance_ctrl nvmem
> cell.
> But these errors are about missing '#nvmem-cell-cells' properties.
> IIRC there should be another patch assuming '#nvmem-cell-cells = <0>'
> by
> default.
Yeah, I'm just looking at that. As I said, this should have been
addressed
with my commit 7850f3f4da30 (of: base: add
of_parse_phandle_with_optional_args()).
But it seems to be broken/not working as intended :/
It seems that we have to pass the information wether the cells_name is
optional to of_phandle_iterator_init().
-michael
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-10 10:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 8:07 issue: could not get #nvmem-cell-cells Peng Fan
2023-01-10 8:12 ` Michael Walle
2023-01-10 8:14 ` Peng Fan
2023-01-10 10:32 ` Alexander Stein
2023-01-10 10:47 ` Michael Walle [this message]
2023-01-10 14:45 ` Michael Walle
2023-01-10 15:52 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b4ac08c5ff53180db4aeddd944f85cf@walle.cc \
--to=michael@walle.cc \
--cc=aisheng.dong@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox