From: jassisinghbrar@gmail.com (jassi brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/10] S3C64XX I2S: En/Disable codec clocks.
Date: Tue, 15 Sep 2009 21:35:48 +0900 [thread overview]
Message-ID: <1b68c6790909150535p777f93d4pc416f65dd8dbced4@mail.gmail.com> (raw)
In-Reply-To: <20090915114936.GK22878@rakim.wolfsonmicro.main>
On Tue, Sep 15, 2009 at 8:49 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Sep 15, 2009 at 07:02:42PM +0900, Jassi wrote:
>
>> ? ? ? switch (clk_id) {
>> ? ? ? case S3C64XX_CLKSRC_PCLK:
>> ? ? ? ? ? ? ? iismod &= ~S3C64XX_IISMOD_IMS_SYSMUX;
>> + ? ? ? ? ? ? clk_disable(i2s->iis_cclk);
>> ? ? ? ? ? ? ? break;
>>
>> ? ? ? case S3C64XX_CLKSRC_MUX:
>> ? ? ? ? ? ? ? iismod |= S3C64XX_IISMOD_IMS_SYSMUX;
>> + ? ? ? ? ? ? clk_enable(i2s->iis_cclk);
>> ? ? ? ? ? ? ? break;
>
> I'd expect that this will cause trouble eventually - machine drivers
> tend to call set_sysclk() repeatedly, meaning that the clock will be
> repeatedly enabled or disabled. ?Eventually this will overflow the
> counter the clock API is using, perhaps even cause it to complain loudly
> about errors (eg, if the use count drops below zero). ?A local reference
> count should deal with those issues, or checking to see if iismod
> actualy changed before updating the clock API.
Yes, this was a bad idea.
next prev parent reply other threads:[~2009-09-15 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 10:02 [PATCH 10/10] S3C64XX I2S: En/Disable codec clocks Jassi
2009-09-15 11:49 ` Mark Brown
2009-09-15 12:35 ` jassi brar [this message]
2009-09-16 0:18 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b68c6790909150535p777f93d4pc416f65dd8dbced4@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).