From: jassisinghbrar@gmail.com (jassi brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: SAMSUNG: Rename s3c24xx touchscreen interface to s3c
Date: Wed, 27 Jan 2010 09:32:45 +0900 [thread overview]
Message-ID: <1b68c6791001261632y354b54c6v5845d33358a52179@mail.gmail.com> (raw)
In-Reply-To: <4B5F1229.9030304@gmail.com>
On Wed, Jan 27, 2010 at 1:02 AM, Maurus Cuelenaere
<mcuelenaere@gmail.com> wrote:
> Op 26-01-10 15:55, Ben Dooks schreef:
>>
>> On Fri, Jan 22, 2010 at 11:47:11PM +0100, Maurus Cuelenaere wrote:
>>
>>>
>>> ARM: SAMSUNG: Rename s3c24xx touchscreen interface to s3c
>>>
>>> Signed-off-by: Maurus Cuelenaere<mcuelenaere@gmail.com>
>>>
>>
>> Renaming for naming sake is in my view just a waste of diff, unless
>> anyone disagrees here.
>>
>
> Well I don't think it's pointless, having s3c24xx_ts_set_platdata() and
> s3c2410_ts_mach_info instead of their s3c_ equivalents make it look like the
> API only handles s3c24xx platforms, which isn't true (anymore).
well, even after making it s3c_ it still doesn't cover s5pxxxx(and its not
just ts but other devices as well). The point is, we can't ever catch up
with the SoC names.
A more soothing pov is to see newer devices as containing the ts
controller of s3c2410(in this case).
If not that, then no point in renaming just ts, we should rename every
other such symbol to not s3c_ but samsung_<dev>_ver_abc_
or some more compact form otherwise we fall back in the same dilemma.
next prev parent reply other threads:[~2010-01-27 0:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 22:47 [PATCH 2/4] ARM: SAMSUNG: Rename s3c24xx touchscreen interface to s3c Maurus Cuelenaere
2010-01-26 14:55 ` Ben Dooks
2010-01-26 16:02 ` Maurus Cuelenaere
2010-01-27 0:32 ` Maurus Cuelenaere
2010-01-27 0:32 ` jassi brar [this message]
2010-01-31 18:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b68c6791001261632y354b54c6v5845d33358a52179@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).