* [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines
@ 2010-01-27 5:57 jassisinghbrar at gmail.com
2010-01-27 8:11 ` Ben Dooks
0 siblings, 1 reply; 7+ messages in thread
From: jassisinghbrar at gmail.com @ 2010-01-27 5:57 UTC (permalink / raw)
To: linux-arm-kernel
From: Jassi Brar <jassi.brar@samsung.com>
GPIO_E-[5,9] pin functionality was defined incorrectly.
The patch corrects and adds missing pins.
Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
---
arch/arm/mach-s3c2410/include/mach/regs-gpio.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-s3c2410/include/mach/regs-gpio.h b/arch/arm/mach-s3c2410/include/mach/regs-gpio.h
index ebc85c6..fd672f3 100644
--- a/arch/arm/mach-s3c2410/include/mach/regs-gpio.h
+++ b/arch/arm/mach-s3c2410/include/mach/regs-gpio.h
@@ -406,31 +406,31 @@
#define S3C2443_GPE5_SD1_CLK (0x02 << 10)
#define S3C2400_GPE5_EINT5 (0x02 << 10)
#define S3C2400_GPE5_TCLK1 (0x03 << 10)
+#define S3C2443_GPE5_AC_BITCLK (0x03 << 10)
#define S3C2410_GPE6_SDCMD (0x02 << 12)
#define S3C2443_GPE6_SD1_CMD (0x02 << 12)
-#define S3C2443_GPE6_AC_BITCLK (0x03 << 12)
+#define S3C2443_GPE6_AC_SDI (0x03 << 12)
#define S3C2400_GPE6_EINT6 (0x02 << 12)
#define S3C2410_GPE7_SDDAT0 (0x02 << 14)
#define S3C2443_GPE5_SD1_DAT0 (0x02 << 14)
-#define S3C2443_GPE7_AC_SDI (0x03 << 14)
+#define S3C2443_GPE7_AC_SDO (0x03 << 14)
#define S3C2400_GPE7_EINT7 (0x02 << 14)
#define S3C2410_GPE8_SDDAT1 (0x02 << 16)
#define S3C2443_GPE8_SD1_DAT1 (0x02 << 16)
-#define S3C2443_GPE8_AC_SDO (0x03 << 16)
+#define S3C2443_GPE8_AC_SYNC (0x03 << 16)
#define S3C2400_GPE8_nXDACK0 (0x02 << 16)
#define S3C2410_GPE9_SDDAT2 (0x02 << 18)
#define S3C2443_GPE9_SD1_DAT2 (0x02 << 18)
-#define S3C2443_GPE9_AC_SYNC (0x03 << 18)
+#define S3C2443_GPE9_AC_nRESET (0x03 << 18)
#define S3C2400_GPE9_nXDACK1 (0x02 << 18)
#define S3C2400_GPE9_nXBACK (0x03 << 18)
#define S3C2410_GPE10_SDDAT3 (0x02 << 20)
#define S3C2443_GPE10_SD1_DAT3 (0x02 << 20)
-#define S3C2443_GPE10_AC_nRESET (0x03 << 20)
#define S3C2400_GPE10_nXDREQ0 (0x02 << 20)
#define S3C2410_GPE11_SPIMISO0 (0x02 << 22)
--
1.6.2.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines
2010-01-27 5:57 [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines jassisinghbrar at gmail.com
@ 2010-01-27 8:11 ` Ben Dooks
2010-01-27 8:15 ` jassi brar
0 siblings, 1 reply; 7+ messages in thread
From: Ben Dooks @ 2010-01-27 8:11 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2010 at 02:57:53PM +0900, jassisinghbrar at gmail.com wrote:
> From: Jassi Brar <jassi.brar@samsung.com>
>
> GPIO_E-[5,9] pin functionality was defined incorrectly.
> The patch corrects and adds missing pins.
Ok, should I apply this to the fixes tree and send to linus?
> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
> ---
> arch/arm/mach-s3c2410/include/mach/regs-gpio.h | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-s3c2410/include/mach/regs-gpio.h b/arch/arm/mach-s3c2410/include/mach/regs-gpio.h
> index ebc85c6..fd672f3 100644
> --- a/arch/arm/mach-s3c2410/include/mach/regs-gpio.h
> +++ b/arch/arm/mach-s3c2410/include/mach/regs-gpio.h
> @@ -406,31 +406,31 @@
> #define S3C2443_GPE5_SD1_CLK (0x02 << 10)
> #define S3C2400_GPE5_EINT5 (0x02 << 10)
> #define S3C2400_GPE5_TCLK1 (0x03 << 10)
> +#define S3C2443_GPE5_AC_BITCLK (0x03 << 10)
>
> #define S3C2410_GPE6_SDCMD (0x02 << 12)
> #define S3C2443_GPE6_SD1_CMD (0x02 << 12)
> -#define S3C2443_GPE6_AC_BITCLK (0x03 << 12)
> +#define S3C2443_GPE6_AC_SDI (0x03 << 12)
> #define S3C2400_GPE6_EINT6 (0x02 << 12)
>
> #define S3C2410_GPE7_SDDAT0 (0x02 << 14)
> #define S3C2443_GPE5_SD1_DAT0 (0x02 << 14)
> -#define S3C2443_GPE7_AC_SDI (0x03 << 14)
> +#define S3C2443_GPE7_AC_SDO (0x03 << 14)
> #define S3C2400_GPE7_EINT7 (0x02 << 14)
>
> #define S3C2410_GPE8_SDDAT1 (0x02 << 16)
> #define S3C2443_GPE8_SD1_DAT1 (0x02 << 16)
> -#define S3C2443_GPE8_AC_SDO (0x03 << 16)
> +#define S3C2443_GPE8_AC_SYNC (0x03 << 16)
> #define S3C2400_GPE8_nXDACK0 (0x02 << 16)
>
> #define S3C2410_GPE9_SDDAT2 (0x02 << 18)
> #define S3C2443_GPE9_SD1_DAT2 (0x02 << 18)
> -#define S3C2443_GPE9_AC_SYNC (0x03 << 18)
> +#define S3C2443_GPE9_AC_nRESET (0x03 << 18)
> #define S3C2400_GPE9_nXDACK1 (0x02 << 18)
> #define S3C2400_GPE9_nXBACK (0x03 << 18)
>
> #define S3C2410_GPE10_SDDAT3 (0x02 << 20)
> #define S3C2443_GPE10_SD1_DAT3 (0x02 << 20)
> -#define S3C2443_GPE10_AC_nRESET (0x03 << 20)
> #define S3C2400_GPE10_nXDREQ0 (0x02 << 20)
>
> #define S3C2410_GPE11_SPIMISO0 (0x02 << 22)
> --
> 1.6.2.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines
2010-01-27 8:11 ` Ben Dooks
@ 2010-01-27 8:15 ` jassi brar
2010-01-27 8:24 ` Ben Dooks
2010-01-27 10:29 ` Mark Brown
0 siblings, 2 replies; 7+ messages in thread
From: jassi brar @ 2010-01-27 8:15 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2010 at 5:11 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Wed, Jan 27, 2010 at 02:57:53PM +0900, jassisinghbrar at gmail.com wrote:
>> From: Jassi Brar <jassi.brar@samsung.com>
>>
>> GPIO_E-[5,9] pin functionality was defined incorrectly.
>> The patch corrects and adds missing pins.
>
> Ok, should I apply this to the fixes tree and send to linus?
Honestly speaking, I don't know. Please do as you see due.
Maybe Mark Brown, as an affected maintainer, has some opinion?
thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines
2010-01-27 8:15 ` jassi brar
@ 2010-01-27 8:24 ` Ben Dooks
2010-01-27 8:28 ` jassi brar
2010-01-27 10:29 ` Mark Brown
1 sibling, 1 reply; 7+ messages in thread
From: Ben Dooks @ 2010-01-27 8:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2010 at 05:15:28PM +0900, jassi brar wrote:
> On Wed, Jan 27, 2010 at 5:11 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> > On Wed, Jan 27, 2010 at 02:57:53PM +0900, jassisinghbrar at gmail.com wrote:
> >> From: Jassi Brar <jassi.brar@samsung.com>
> >>
> >> GPIO_E-[5,9] pin functionality was defined incorrectly.
> >> The patch corrects and adds missing pins.
> >
> > Ok, should I apply this to the fixes tree and send to linus?
> Honestly speaking, I don't know. Please do as you see due.
> Maybe Mark Brown, as an affected maintainer, has some opinion?
> thanks
Ok, couple of questions:
1) Is it currently causing an working driver to fail?
2) Will it break anything currently in the kernel if merged now?
I'll await Mark's comments.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines
2010-01-27 8:24 ` Ben Dooks
@ 2010-01-27 8:28 ` jassi brar
0 siblings, 0 replies; 7+ messages in thread
From: jassi brar @ 2010-01-27 8:28 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2010 at 5:24 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Wed, Jan 27, 2010 at 05:15:28PM +0900, jassi brar wrote:
>> On Wed, Jan 27, 2010 at 5:11 PM, Ben Dooks <ben-linux@fluff.org> wrote:
>> > On Wed, Jan 27, 2010 at 02:57:53PM +0900, jassisinghbrar at gmail.com wrote:
>> >> From: Jassi Brar <jassi.brar@samsung.com>
>> >>
>> >> GPIO_E-[5,9] pin functionality was defined incorrectly.
>> >> The patch corrects and adds missing pins.
>> >
>> > Ok, should I apply this to the fixes tree and send to linus?
>> Honestly speaking, I don't know. Please do as you see due.
>> Maybe Mark Brown, as an affected maintainer, has some opinion?
>> thanks
>
> Ok, couple of questions:
>
> 1) Is it currently causing an working driver to fail?
No.
> 2) Will it break anything currently in the kernel if merged now?
No.
It is needed for the patch "ARM: S3C24XX: Update AC97 platform resources".
> I'll await Mark's comments.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines
2010-01-27 8:15 ` jassi brar
2010-01-27 8:24 ` Ben Dooks
@ 2010-01-27 10:29 ` Mark Brown
2010-01-27 10:37 ` jassi brar
1 sibling, 1 reply; 7+ messages in thread
From: Mark Brown @ 2010-01-27 10:29 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2010 at 05:15:28PM +0900, jassi brar wrote:
> On Wed, Jan 27, 2010 at 5:11 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> > On Wed, Jan 27, 2010 at 02:57:53PM +0900, jassisinghbrar at gmail.com wrote:
> >> From: Jassi Brar <jassi.brar@samsung.com>
> >>
> >> GPIO_E-[5,9] pin functionality was defined incorrectly.
> >> The patch corrects and adds missing pins.
> >
> > Ok, should I apply this to the fixes tree and send to linus?
> Honestly speaking, I don't know. Please do as you see due.
> Maybe Mark Brown, as an affected maintainer, has some opinion?
Might've wanted to CC me there... :) If they're just plain wrong then
it should probably go to Linus, though equally well nobody's been
complaining about it.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines
2010-01-27 10:29 ` Mark Brown
@ 2010-01-27 10:37 ` jassi brar
0 siblings, 0 replies; 7+ messages in thread
From: jassi brar @ 2010-01-27 10:37 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2010 at 7:29 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Jan 27, 2010 at 05:15:28PM +0900, jassi brar wrote:
>> On Wed, Jan 27, 2010 at 5:11 PM, Ben Dooks <ben-linux@fluff.org> wrote:
>> > On Wed, Jan 27, 2010 at 02:57:53PM +0900, jassisinghbrar at gmail.com wrote:
>> >> From: Jassi Brar <jassi.brar@samsung.com>
>> >>
>> >> GPIO_E-[5,9] pin functionality was defined incorrectly.
>> >> The patch corrects and adds missing pins.
>> >
>> > Ok, should I apply this to the fixes tree and send to linus?
>> Honestly speaking, I don't know. Please do as you see due.
>> Maybe Mark Brown, as an affected maintainer, has some opinion?
>
> Might've wanted to CC me there... :) ?If they're just plain wrong then
> it should probably go to Linus, though equally well nobody's been
> complaining about it.
yes, I missed to cc u on the first patch by mistake.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-01-27 10:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-27 5:57 [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines jassisinghbrar at gmail.com
2010-01-27 8:11 ` Ben Dooks
2010-01-27 8:15 ` jassi brar
2010-01-27 8:24 ` Ben Dooks
2010-01-27 8:28 ` jassi brar
2010-01-27 10:29 ` Mark Brown
2010-01-27 10:37 ` jassi brar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).