linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jassisinghbrar@gmail.com (jassi brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 06/10] ARM: SMDK64XX: Enable AC97 device
Date: Thu, 28 Jan 2010 14:31:49 +0900	[thread overview]
Message-ID: <1b68c6791001272131u388f1980l48a1a587070f0189@mail.gmail.com> (raw)
In-Reply-To: <1b68c6791001272008k7341d360oeb0e84b181e74b0c@mail.gmail.com>

On Thu, Jan 28, 2010 at 1:08 PM, jassi brar <jassisinghbrar@gmail.com> wrote:
> On Thu, Jan 28, 2010 at 12:41 PM, Ben Dooks <ben@trinity.fluff.org> wrote:
>> On Wed, Jan 27, 2010 at 02:59:29PM +0900, jassisinghbrar at gmail.com wrote:
>>> From: Jassi Brar <jassi.brar@samsung.com>
>>>
>>> Add AC97 controller to platform devices and initialize the AC97 gpios.
>>
>> I'd much rather see platform devices always added unless there is a really
>> good reason not to. People can build things as modules and this means you
>> end up having to rebuild the core kernel as well as the module if you want
>> to change.
> Yes, sounds good to me. I will revise this patch accordingly.
> Thanks

s3c64xx_device_ac97 device is exported from dev-audio.c
which is compiled only if CONFIG_SND_S3C24XX_SOC is defined.
So, If we unconditionally add the platform device, it will give error in case
the user didn't select Samsung ASoC option.
So, I guess i should make it conditional on CONFIG_SND_S3C24XX_SOC
rather than CONFIG_SND_SOC_SMDK_WM9713

      reply	other threads:[~2010-01-28  5:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27  5:59 [PATCHv2 06/10] ARM: SMDK64XX: Enable AC97 device jassisinghbrar at gmail.com
2010-01-27 10:45 ` Mark Brown
2010-01-28  3:41 ` Ben Dooks
2010-01-28  4:08   ` jassi brar
2010-01-28  5:31     ` jassi brar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b68c6791001272131u388f1980l48a1a587070f0189@mail.gmail.com \
    --to=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).