From: jassisinghbrar@gmail.com (jassi brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] ARM: S3C64XX: SPI: Make platform device compilation selectable
Date: Thu, 28 Jan 2010 18:12:30 +0900 [thread overview]
Message-ID: <1b68c6791001280112h5054a260rc5b37d3adc7c5576@mail.gmail.com> (raw)
In-Reply-To: <20100128090239.GD13756@pengutronix.de>
2010/1/28 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> On Thu, Jan 28, 2010 at 05:14:49PM +0900, jassisinghbrar at gmail.com wrote:
>> From: Jassi Brar <jassi.brar@samsung.com>
>>
>> The SPI controller platform devices should be compiled in
>> independent of the driver support, otherwise we might end
>> up with dev-spi built as kernel module.
>> Change this to make every machine select if it has some SPI
>> device and wants to build device definitions.
> Is it correct that S3C64XX_DEV_SPI for now is always unselected and so
> dev-spi.o is never compiled? ?Assuming there are already machines using
> it the corresponding symbols should select S3C64XX_DEV_SPI, don't they?
>
> If that's wrong the last sentence in your commit log is confusing.
Hello,
No machine currently uses s3c64xx-spi, so it's ok.
In future a s3c64xx based machine has to select S3C64XX_DEV_SPI
if it has some device attached to the SPI bus.
next prev parent reply other threads:[~2010-01-28 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 8:14 [PATCHv2] ARM: S3C64XX: SPI: Make platform device compilation selectable jassisinghbrar at gmail.com
2010-01-28 8:23 ` Ben Dooks
2010-01-28 9:02 ` Uwe Kleine-König
2010-01-28 9:12 ` jassi brar [this message]
2010-01-28 9:29 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b68c6791001280112h5054a260rc5b37d3adc7c5576@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).