From: jassisinghbrar@gmail.com (jassi brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCHv2 05/10] ASoC: AC97: SMDK: Add wm9713 machine driver
Date: Fri, 29 Jan 2010 10:08:04 +0900 [thread overview]
Message-ID: <1b68c6791001281708ve324caaoa52581e3ebce09bd@mail.gmail.com> (raw)
In-Reply-To: <20100128120020.GA19270@sirena.org.uk>
On Thu, Jan 28, 2010 at 9:00 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Jan 27, 2010 at 02:59:19PM +0900, jassisinghbrar at gmail.com wrote:
>
>> + ? ? Headphone Playback Switch - On
>> + ? ? $ amixer cset numid=4 1
>> +
>
> Actually, one thing that really needs fixing here - these instructions
> refer to the controls by number. ?This is extremely fragile in the face
> of any changes in the CODEC driver since the control numbering is worked
> out at runtime and any change in the set of controls exported by the
> device may change the result. ?It is much better to refer to the
> controls by name since the names are much less likely to change. ?This
> is also helpful for people using other UIs which don't display the
> control names.
I will submit a patch for it, though I used exact control names and their
values before every command.
next prev parent reply other threads:[~2010-01-29 1:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 5:59 [PATCHv2 05/10] ASoC: AC97: SMDK: Add wm9713 machine driver jassisinghbrar at gmail.com
2010-01-28 12:00 ` [alsa-devel] " Mark Brown
2010-01-29 1:08 ` jassi brar [this message]
2010-01-29 9:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b68c6791001281708ve324caaoa52581e3ebce09bd@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).