From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A34AEC74A5B for ; Sun, 26 Mar 2023 14:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9wxo4VzXshs9lKYQ01dUeRKoMYeIHhNhu6cdSuKzR7g=; b=QJYy5ayIZAYTQd 8Bj4A7ISe5YV+ZD6sGjb7yifivPPGGFlQDU0m9OICvTfYM35OJOcjTJYgUXaZWXhBXaUyG2tV3SRN MYXo7u41c4fCeYBPz3dG63zVrNn8wfH0BJRaPZ69pgVxrPvXuQeu5O0+PuMW1lTdk/SUhnrlQjmxV xlIC64vmhvcejwfylmFknagiq+M7d58ugfT9TXThQtSXTBXCdAs9Vy3GRvv36WWVpWD9OfD1LYwAg Z5RAEM3AKejjWAUohMq8cJqPal58tCplTHYHvuljFzlMfZf4dtS3mI8tb3aMo4JISj1Y6j9rlzsMb aS5I+I0bktKWA9845wkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgRiR-008fhi-31; Sun, 26 Mar 2023 14:51:27 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgRiO-008fgv-1F for linux-arm-kernel@lists.infradead.org; Sun, 26 Mar 2023 14:51:25 +0000 Received: by mail-ed1-x531.google.com with SMTP id cn12so25891728edb.4 for ; Sun, 26 Mar 2023 07:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679842282; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+s3tOPmxxPboBBurR7XBfM3D4IM5gZJk5nXyQfbhXWA=; b=VV3VHfKT0tKRtfSuq1Rx1WDEMfmt5m3GN3pbM2oW15Tzukx2Knbj3499bEBkXsDUtQ BDkXYusPEcYPXotjc9VSlPx1av9BzbaQEA75cQbM0yscfHxXEzgL6B5MBnKShiDFQUGi XrqNzDv+6co7pGe8VcvBlLmCPL+Cdx47NkKoApuxP5A0xDjyc8zeSgnXlM3ghWa0XUZY t6RiwIcfUUKZUjJEXmMDFTdwuStKfeql+CPO7C04H84jMcNPUibsO9v9xvk7ikdLvaHu apHmzANpy5+e2gsL/C1z4af7ZA67JAPvjP4A/7g4apuPvRWxqBm/6Ay5GEeWNFaiBNR7 MzWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679842282; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+s3tOPmxxPboBBurR7XBfM3D4IM5gZJk5nXyQfbhXWA=; b=LymOQoICk4kzJnN+dPZpNO9Bn9tenayfljJVMc0jPRj49P4L3c49WDf93eOfDYwVQk 3pku15DhALOpj9vDADDvhJzI7zKuGtvezoAJz2FnufKIiDB3SMAGSf/rYfkooLvLL+bz o3upgQPfVlgiFgscwD9Id5oJqO2hHU4Y3owlqi5SkjpU02/bIXPjQoneOpK1Wrf4XbP0 +/R8IdXR0IJS0YTzTo6UqY1jPuqTUzL4LlFBFvQmzQdaAgmvU8oWevymMz0ZQY+8iiiQ 5LSw5vZ0Ymmx37+unolqNjU4uNnCXSmOQ+jDBtYnYN0dG9nzGWiGNTWgTKYkLegWiduD 74fw== X-Gm-Message-State: AAQBX9fjpd43Dli3D5GaFmq303xa/AXEbtLufqCZj+v+MNvby6Hcs3ei UMXAZq0jEarporEPwXixyxZklw== X-Google-Smtp-Source: AKy350bvB8YDMFh/w+j6qkDcaEMKOOIcdpCW4jkZGkTENqR/6Jo2c1CXyvQbB5dL7I1kRbH4gI7eAA== X-Received: by 2002:a17:906:5010:b0:92a:77dd:f6f with SMTP id s16-20020a170906501000b0092a77dd0f6fmr9990766ejj.73.1679842282329; Sun, 26 Mar 2023 07:51:22 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:eca3:3b8f:823b:2669? ([2a02:810d:15c0:828:eca3:3b8f:823b:2669]) by smtp.gmail.com with ESMTPSA id hf8-20020a1709072c4800b0092b65c54379sm13035392ejc.104.2023.03.26.07.51.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Mar 2023 07:51:21 -0700 (PDT) Message-ID: <1b9c8e19-10f2-824d-9b50-51e7a9287bb1@linaro.org> Date: Sun, 26 Mar 2023 16:51:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions Content-Language: en-US To: Shane Francis Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230326001535.149539-1-bigbeeshane@gmail.com> <20230326001535.149539-2-bigbeeshane@gmail.com> <10930783-e1dd-5e75-a2cc-a09af862d949@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_075124_447446_324CA456 X-CRM114-Status: GOOD ( 18.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/03/2023 14:02, Shane Francis wrote: >> Please wrap commit message according to > > Linux coding style / > submission > > Will do, I haven't submitted patches for a while totally forgot the > wrapping guidelines > >> Unfortunately the reason is not good enough > for ABI break. Replace >> vendor boot uboots with open-source one or > just correct them (it's still >> U-Boot so even for vendor one you have the source). > > Replacing uboot is fine for this case, however I can foresee that can cause > issues further down the line. > > > 1. No uboot source from the vendor, we all know no everyone respects code > licencing > > 2. Secure environments (like android tables), this chipset will likely end > up in android tablets that have the secure boot chain enable. These will be > unable to replace uboot even if source is available. So mention this in the commit msg. > > As this SoC is new to the Linux kernel (not even useable for much it's > current state) would it not be better to aling on this so vendor and > mainline DTS "agree" now rather than possibly have to address is in the > future ? Then commit msg should also mention it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel