From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8D7C433B4 for ; Wed, 19 May 2021 11:49:58 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF31F610CB for ; Wed, 19 May 2021 11:49:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF31F610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hmwN1eEqM4T1hEt6agnJE41MQwuOtXu2+LQ6UcB4U5g=; b=OROx+rLhTz+Dtoyyr+glLSX+y izihNNTwmyvWqA+9wA93quHpusPmJ7Nh6Cm21MCBBIV132IlPple7zUc7AS7/287u/uIVQ5yQaP04 TIDNrJFkiTo7m/N52L5Yhgofr8v2qc29hXTRPKVC5kGtx6r/TjOgI+86eny6iXItXd0fufqwlb7JH iflIZ3UVnl9pyST94g9H1M0IiZqsfMPus0O/EyZFr7kimtMJCFT57vSFbP4aoQgluTHItn3qgu6bP xs1l/e84bFW2ZrokLvtpVDToMunWFgddpxxVH+wyxUVOQHJ+xWTWDKJ/dAA8FBNqUm3om7orx/GuR rCttZiHFA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljKfh-003pUP-Ph; Wed, 19 May 2021 11:47:30 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljKfT-003pRy-9m for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 11:47:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=+5KzLJU12Eq2A7WIb9L8h0Cg2h98ONu03v/e6H2J7F0=; b=WlaBFVcMzY0xPd/qFhC9TaoUmY knu3ttTL5By9RcFDeOKwzUmW9I9/zf73UPbH2H6ZafLHhXJSzUk8C9YRHJ1w/9lYT1ag3HxW9j1md l5la+1isOvqBzNznFHslrGqJ/n+XcN+acbojqPKq32x+maHIxoxCj7P2MeVlJBk/6VzMmgK5nZ0y6 yvIxrM0gj7GnDkEopIwRv2XJt5L5EoHZHo9R81YctSJpjCvzFpMpKHxtqX22V5jds8NvM9y3kQINI etHakTFSHLksC8YSGog4oVn+1IWapOnICLhrkxfDHNWtBEoYrSISgFV/PQg9MmnwFEAGWsNqihrQy VhNQU8rQ==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljKck-00FQHh-A9 for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 11:44:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8A333101E; Wed, 19 May 2021 04:44:24 -0700 (PDT) Received: from [10.163.79.253] (unknown [10.163.79.253]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 07DD13F719; Wed, 19 May 2021 04:44:19 -0700 (PDT) Subject: Re: [PATCH] arm64: mm: hugetlb: add support for free vmemmap pages of HugeTLB To: Muchun Song , will@kernel.org, akpm@linux-foundation.org, david@redhat.com, bodeddub@amazon.com, osalvador@suse.de, mike.kravetz@oracle.com, rientjes@google.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, zhengqi.arch@bytedance.com References: <20210518091826.36937-1-songmuchun@bytedance.com> From: Anshuman Khandual Message-ID: <1b9d008a-7544-cc85-5c2f-532b984eb5b5@arm.com> Date: Wed, 19 May 2021 17:15:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210518091826.36937-1-songmuchun@bytedance.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_044426_428551_32C463AB X-CRM114-Status: GOOD ( 20.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/18/21 2:48 PM, Muchun Song wrote: > The preparation of supporting freeing vmemmap associated with each > HugeTLB page is ready, so we can support this feature for arm64. > > Signed-off-by: Muchun Song > --- > arch/arm64/mm/mmu.c | 5 +++++ > fs/Kconfig | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 5d37e461c41f..967b01ce468d 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -1134,6 +1135,10 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, > pmd_t *pmdp; > > WARN_ON((start < VMEMMAP_START) || (end > VMEMMAP_END)); > + > + if (is_hugetlb_free_vmemmap_enabled() && !altmap) > + return vmemmap_populate_basepages(start, end, node, altmap); Not considering the fact that this will force the kernel to have only base page size mapping for vmemmap (unless altmap is also requested) which might reduce the performance, it also enables vmemmap mapping to be teared down or build up at runtime which could potentially collide with other kernel page table walkers like ptdump or memory hotremove operation ! How those possible collisions are protected right now ? Does not this vmemmap operation increase latency for HugeTLB usage ? Should not this runtime enablement also take into account some other qualifying information apart from potential memory save from struct page areas. Just wondering. > + > do { > next = pmd_addr_end(addr, end); > > diff --git a/fs/Kconfig b/fs/Kconfig > index 6ce6fdac00a3..02c2d3bf1cb8 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -242,7 +242,7 @@ config HUGETLB_PAGE > > config HUGETLB_PAGE_FREE_VMEMMAP > def_bool HUGETLB_PAGE > - depends on X86_64 > + depends on X86_64 || ARM64 > depends on SPARSEMEM_VMEMMAP > > config MEMFD_CREATE > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel