From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7E68C87FCE for ; Thu, 29 Aug 2024 18:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject: References:In-Reply-To:Content-Transfer-Encoding:MIME-Version:Content-Type: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2JiB+TS5ae6gga49hGyD8MtoukdNDYVenb4+0g9lVok=; b=kAxzxxJDrq44LhKNZBbZkCmZbo sE9Dykko15A1UhJ4RXv5MrqEzuvMlr/SsoZ/dYj0TvJzhBn1z0Q5XVJl5QYF2Yan+U1dVrhrbyUZU hwdGFHwMhqpXFKAdw7JXtgR584hzgQZZMswUTLsG3WpIz0qGkaOQ7c0S47gjpluqnjdAB8qnmDuDx KbP2kEgqthTVDqfVaqmfSok7DAmoptAkCb/yezZx2OFiqqDAoCx6YVGoi9acFZMDnj5HgT92iVGmh NZwLFoh2gsoQ11xn4LHDMdMTNkpN985Yb2Bcjk98bYmg3x9DrpfdK2mDibGiNz9mUYaHfQayAnBXB kqZ8CwxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjjj1-000000039v6-2NCR; Thu, 29 Aug 2024 18:18:27 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjjiA-000000039nu-3zse for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 18:17:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4027CCE1BAD; Thu, 29 Aug 2024 18:17:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32543C4CEC1; Thu, 29 Aug 2024 18:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724955452; bh=PQ8NlAQBi9YMzKHfqEYVZxQkx9i4+zrKJSJVjyL8mLE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=kqxgsCrNZ5pvHD/nrx5mXB/rly/1GcB8AsCi87Ae/YPO/96pNXan9yE/uBeqNYpBh sEuVfXZtkOu27d2MWuvCnJSqFrQIrnhDvEwgHplymhp2t9TGjU4/FbdWbF4egohHYz 7UIqY9V+kUKwtEDnfkd2QaEwpqgXonXiE8viKu29jA0kwo+ftU3qmEHbbrg9BDkMWG JzHACGv48pwWrcujx1Lo1L4tVpcXkB2g2J+lVwS2CAQm18yYD4fckBWyKf1AYOyRtp THXd5+RS9WgRxjkzpkE9QD97UWA9Uol3DNAih9A1X8qwHBQxQLZyPw09APZFWSdIH3 7eyq0nXTY5GnA== Message-ID: <1bd17a02bab46391872e4934895b83e8.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <2024082824-emphasis-thwarting-4ef4@gregkh> References: <20240826123602.1872-1-hpausten@protonmail.com> <20240826123602.1872-8-hpausten@protonmail.com> <2024082655-cubicle-flashily-6ab3@gregkh> <2024082824-emphasis-thwarting-4ef4@gregkh> Subject: Re: [PATCH v3 7/9] uio: add Xilinx user clock monitor support From: Stephen Boyd Cc: Michael Turquette , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michal Simek , Shubhrajyoti Datta , Dave Ertman , Ira Weiny , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Harry Austen , Greg Kroah-Hartman Date: Thu, 29 Aug 2024 11:17:30 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_111735_187490_5E4B4273 X-CRM114-Status: GOOD ( 19.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Greg Kroah-Hartman (2024-08-28 00:10:46) > On Tue, Aug 27, 2024 at 04:40:52PM -0700, Stephen Boyd wrote: > > Quoting Harry Austen (2024-08-27 12:08:52) > > > On Mon Aug 26, 2024 at 2:11 PM BST, Greg Kroah-Hartman wrote: > > > > Why do you want a UIO api for a clock device? What userspace code = is > > > > going to access the hardware this way? Why not use the normal > > > > kernel/user apis instead? > > >=20 > > > I was just trying to provide userspace access to these _unexpected_ c= lock > > > status event indications (clock stopped, underrun, overrun or glitche= d) and UIO >=20 > That is going to be a brand-new user/kernel api that isn't documented > anywhere and will be unique to this one device. Please don't do that. >=20 > > Maybe unexpected events can be indicated through the EDAC subsystem, > > except that is usually about memory or cache errors, not device driver > > issues. >=20 > If you all need a new way to report issues like this to userspace, then > let's create the correct api for it, don't require userspace to mmap a > random device and expect to poke around in it safely to get the > information. >=20 > Odds are that mmap will change with the next version of this device, > right? Agreed. I'm wondering if we don't even need to invent anything new though and can simply use devcoredump. Harry?