From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE1FBD2A520 for ; Wed, 16 Oct 2024 14:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gE16HBn92E+T84kpg1fvLexWOrEzAz+UTTnBAEOWf98=; b=czmQIrMdiFnuMOCFlt0TjH+5qo Y4btCyFcI6wFn1Q+oybjcBjoyRfpK7R3aTbKMyppLYMmavf3zZFvt8EJALbb+DsNAdSkzWr0ZbQeM DC9SBtYNPHYQWmCRmJO1q9jBeoItUsnnh0Tn1h5fxFIdYjjzajhJDHONzkNX6EqyCAcSG/KB1IQzr JadUXUC5IOoOQN5IFCex0UIkNhCazSclqlShwluKygaeZJjcJ/kOPwOujtI6gC5nOzvdmpXcMrspP BFCdZmZceFICrdCtajSQkjq+9W7g6XhNeqiRmqWLyA8vlcGEVX8um5T/FkGprsu1T72srci0VSlzd znCLLgwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t15Sh-0000000CAKP-0wIX; Wed, 16 Oct 2024 14:57:19 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t15I9-0000000C8Bj-2BMu for linux-arm-kernel@bombadil.infradead.org; Wed, 16 Oct 2024 14:46:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=gE16HBn92E+T84kpg1fvLexWOrEzAz+UTTnBAEOWf98=; b=QjFJoIJn/sW7Q2roZQPDAK1Sx+ 9soOYAM/r3coFCxl3g8CYoiQtGKI94IS9H1ANZbxXw4/c38bs9VIPqVVwZO6laLzUwbPbiSk/hnCG ZkD+fzSQY8wb6iUHk408j55JaDT3i0jrkwYlh/ztIrFh6h3h4zIkxZoDey0sfo380fLIAvXIyD6jw rAHLr1/zChnBzESL1/ngob88GZ7gSSUAo05W8MiU6ssiLEWw/1fCsC56ISnOsONd8d8exYYCQm3TJ uUXGs6XNBOZCGK3Yxr1GOnGneeji132gzRck8EgJSdSuHx9CeacJrZGB8fiNfsII8eu65zbogC+0o UG8Ha/Tw==; Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t15I6-00000006pmZ-0NyN for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2024 14:46:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 273EA1007; Wed, 16 Oct 2024 07:46:49 -0700 (PDT) Received: from [10.1.28.177] (XHFQ2J9959.cambridge.arm.com [10.1.28.177]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C949F3F71E; Wed, 16 Oct 2024 07:46:16 -0700 (PDT) Message-ID: <1bd243ce-12d6-46d7-89d3-816fb58a4c95@arm.com> Date: Wed, 16 Oct 2024 15:46:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 31/57] edac: Remove PAGE_SIZE compile-time constant assumption Content-Language: en-GB To: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-31-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: <20241014105912.3207374-31-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241016_154622_380068_4234C365 X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org + Borislav Petkov, Tony Luck This was a rather tricky series to get the recipients correct for and my script did not realize that "supporter" was a pseudonym for "maintainer" so you were missed off the original post. Appologies! More context in cover letter: https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ On 14/10/2024 11:58, Ryan Roberts wrote: > To prepare for supporting boot-time page size selection, refactor code > to remove assumptions about PAGE_SIZE being compile-time constant. Code > intended to be equivalent when compile-time page size is active. > > Convert PAGES_TO_MiB() and MiB_TO_PAGES() to use the ternary operator so > that they continue to work with boot-time page size; Boot-time page size > can't be used with CPP because it's value is not known at compile time. > For compile-time page size builds, the compiler will dead code strip for > the same result. > > Signed-off-by: Ryan Roberts > --- > > ***NOTE*** > Any confused maintainers may want to read the cover note here for context: > https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ > > drivers/edac/edac_mc.h | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/edac/edac_mc.h b/drivers/edac/edac_mc.h > index 881b00eadf7a5..22132ee86e953 100644 > --- a/drivers/edac/edac_mc.h > +++ b/drivers/edac/edac_mc.h > @@ -37,13 +37,12 @@ > #include > #include > > -#if PAGE_SHIFT < 20 > -#define PAGES_TO_MiB(pages) ((pages) >> (20 - PAGE_SHIFT)) > -#define MiB_TO_PAGES(mb) ((mb) << (20 - PAGE_SHIFT)) > -#else /* PAGE_SHIFT > 20 */ > -#define PAGES_TO_MiB(pages) ((pages) << (PAGE_SHIFT - 20)) > -#define MiB_TO_PAGES(mb) ((mb) >> (PAGE_SHIFT - 20)) > -#endif > +#define PAGES_TO_MiB(pages) (PAGE_SHIFT < 20 ? \ > + ((pages) >> (20 - PAGE_SHIFT)) :\ > + ((pages) << (PAGE_SHIFT - 20))) > +#define MiB_TO_PAGES(mb) (PAGE_SHIFT < 20 ? \ > + ((mb) << (20 - PAGE_SHIFT)) : \ > + ((mb) >> (PAGE_SHIFT - 20))) > > #define edac_printk(level, prefix, fmt, arg...) \ > printk(level "EDAC " prefix ": " fmt, ##arg)