From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: Andy Shevchenko <andy@kernel.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 21/23] gpio: xgs-iproc: Convert to platform remove callback returning void
Date: Thu, 28 Sep 2023 23:22:32 +0200 [thread overview]
Message-ID: <1bec5afd-e17d-458b-9596-1d63e79646f2@broadcom.com> (raw)
In-Reply-To: <20230928070706.2290137-22-u.kleine-koenig@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 884 bytes --]
On 9/28/2023 9:07 AM, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-28 21:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 7:06 [PATCH 00/23] gpio: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 03/23] gpio: brcmstb: " Uwe Kleine-König
2023-09-28 21:22 ` Florian Fainelli
2023-09-28 7:06 ` [PATCH 09/23] gpio: lpc18xx: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 16/23] gpio: rockchip: " Uwe Kleine-König
2023-10-01 22:45 ` Heiko Stuebner
2023-09-28 7:07 ` [PATCH 19/23] gpio: uniphier: " Uwe Kleine-König
2023-09-28 7:07 ` [PATCH 21/23] gpio: xgs-iproc: " Uwe Kleine-König
2023-09-28 21:22 ` Florian Fainelli [this message]
2023-09-28 7:07 ` [PATCH 22/23] gpio: xilinx: " Uwe Kleine-König
2023-09-28 8:32 ` Datta, Shubhrajyoti
2023-09-28 7:07 ` [PATCH 23/23] gpio: zynq: " Uwe Kleine-König
2023-09-28 21:54 ` [PATCH 00/23] gpio: " Linus Walleij
2023-10-02 6:52 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bec5afd-e17d-458b-9596-1d63e79646f2@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox