From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0DC3CEF142 for ; Tue, 8 Oct 2024 09:38:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AkUrttCQ5fOL6PrH7JQH+jh3uBvnwDTVVw6+ImTwc5Y=; b=UlPzrbiEqguFOyzsDqxR244D6N 0SVW+qpAvtKMxGXb8iXeGfDwJR7jL+u4uxZw+0+Vw1U+J0/rnHUQoeEmepMTzQ4qQOBLjL2jaM0Bw KyycIDf6dqT4FXastSngAKsgwS8jS9Arci4aqp1qVT6aycRr8j1oB/nX0ruez5TxqCjUB3fR59+4n SYLPW1gTKwttap18YGpVjE2LLv7AReNrfL4xE82e4UJzr1FFnR2kMNSuOmKLXfpt7uP16xWgKvUYq H7+3wXpV7zutpjrUJA6yX4I0+B0WOJ6JJAFrnBTfzkqc+C0npHSoHYcKE55VSuo/RdJUB6H0fkNBA hTVennAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy6f9-00000005KnH-19cA; Tue, 08 Oct 2024 09:37:51 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sy6c7-00000005KKu-1WPr for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 09:34:44 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43056d99a5aso808355e9.0 for ; Tue, 08 Oct 2024 02:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728380081; x=1728984881; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=AkUrttCQ5fOL6PrH7JQH+jh3uBvnwDTVVw6+ImTwc5Y=; b=NUJKmXnl2V2yh0Sh7pVtRa5R+UaVrdWZUE6arrKxI2YFWccvvJk7ToXrFQ0GC5jHFm 0dnDsA+davSzXO8JyVWZSt0Xfv9U1hE5r4pXw4pNOJpLONJT40zbWT8JE7Ci9x0ONstX czYd8YAagpXgwGd8oYrH5icsnuN3iv4DcAjR+Tn49Zc0eF6t0TICQ1Utp2ZxFrmrVzx7 6sQPcbWJZQvn8z7fvAgRqMJVKMaZbZmuyml4xWK69KA4wTx8YweO5BqOULL1FvAYqZD3 CmG1PdzxLq/DbNW7HLvhJuDMwrT77UtEwlMDvJBKjhNYTd5buZNR8E+kJh23ujZ0XTSH paCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728380081; x=1728984881; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AkUrttCQ5fOL6PrH7JQH+jh3uBvnwDTVVw6+ImTwc5Y=; b=Ql5Xzxo5zFXtJ0HdHiVBMma3t7FshaU1kG/zF6TtnTTmhK8/YFEAFKcgtOw7ApXc+6 3KZOknlFD6PYRhhS32kQeJ5JF3IL8R9o1aSEm2UJPO2K4H21BLjYEVOxKqzSB8SCSnCq HSYS3rtYo8cI/liHV26vcZXXNv+n6wVYT5cHTcORAMlZ0t5CQd9RmzpjwDuTK+AWD7J4 MQQoGhNfTqUVqE1n7o2B6/zckNS6emvt4gLrbdulNsR+Hmtp6J6gZd9dePL1BCpMJD9Q CZZ+97CmgzvTtvX64OLzgCbxQjndqDCy26tMHKBKlTyGrqQrnUJ29JKx4H/9ntiLtVcR OAWw== X-Forwarded-Encrypted: i=1; AJvYcCXE08giqRlx/svuvlMBdX2kghI3Y5bWYOg58/4k/h1SuFOpufPnvJcxM4eRfrXfa4Mk6B/pI77l3Poo4kRdeUA6@lists.infradead.org X-Gm-Message-State: AOJu0Yz/kyGyuwBOpwgGESg27svmLjfGAafATvCjN0lN1uaiclLqrUid Xpt9V9M4H9aN6mjqwWovmP8kGYbfDTaJOB1XDynB11dUmKSu+QO8DQfVqN4H3Es= X-Google-Smtp-Source: AGHT+IHEZnWRQz4AvycE7TbZa8Wd4RxN1heiXUIFm7/Zn/w1b4DSiaXxZ4pg1k8jYTnHuFOlEzBQTw== X-Received: by 2002:a05:6000:2a83:b0:37d:2e73:fbcb with SMTP id ffacd0b85a97d-37d2e73fd07mr1031436f8f.2.1728380081173; Tue, 08 Oct 2024 02:34:41 -0700 (PDT) Received: from [192.168.0.157] ([82.76.204.61]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f89eda21esm103923195e9.46.2024.10.08.02.34.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2024 02:34:40 -0700 (PDT) Message-ID: <1c525e43-d71c-4c4a-a8ac-96627cd6ea7e@linaro.org> Date: Tue, 8 Oct 2024 10:34:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] spi: atmel-quadspi: Print the controller version and used irq To: Mihai Sain , broonie@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241008083226.51163-1-mihai.sain@microchip.com> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <20241008083226.51163-1-mihai.sain@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_023443_450362_7DEC6060 X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Mihai, On 10/8/24 9:32 AM, Mihai Sain wrote: > Add support to print the controller version and used irq > similar to other at91 drivers (spi, twi, usart). > > Signed-off-by: Mihai Sain > --- > drivers/spi/atmel-quadspi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c > index 95cdfc28361e..757f07132585 100644 > --- a/drivers/spi/atmel-quadspi.c > +++ b/drivers/spi/atmel-quadspi.c > @@ -687,6 +687,8 @@ static int atmel_qspi_probe(struct platform_device *pdev) > pm_runtime_mark_last_busy(&pdev->dev); > pm_runtime_put_autosuspend(&pdev->dev); > > + dev_info(&pdev->dev, "AT91 QSPI Controller version %#x (irq %d)\n", > + atmel_qspi_read(aq, QSPI_VERSION), irq); This pollutes the console. Better to add a dev_dbg if you care. And irq number doesn't bring too much value as you can see it in dt, isn't it? Cheers, ta