From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 372BEE7AD6E for ; Tue, 3 Oct 2023 15:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p6UDKOrQgbEF6OsaDDH6FiCVBYPlcPXbDTCCImtlvbA=; b=AiMf4tnMIjIcwt NBnUSRX8/Q5dxdod0/yGwm5sSsss3MUdTjjmbSe68U47WrsepSWIF6xb3ZgLseUvyn0825xIziA+T XA5uoMG7sfkd2MIN5WEvM8i1bHbjLoXX0jEEx2/aqrvjlyxS6UvdXed+0G4DV3E3SVHKuLvBq3toY k4PfHx4aNm5Gdw5u1qoQ9y/5sSiaCq1b8mvP4a1IJ3Q0aaTMiLKqt5nDiuobgwN9brHErCPa6uIqA 4vsJsHOcB2/V5qBNnjHUmxy9EWnAzT4NIFkh4Uqfx0YoXY5rN5jNYwl/VgWh0qFM5NyiAMQPaF/0M jHMdj1exhnEwAhOtvGIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnhiL-00EuZF-10; Tue, 03 Oct 2023 15:53:37 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnhiH-00EuYq-2E for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2023 15:53:35 +0000 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 393EM5rc032204; Tue, 3 Oct 2023 15:53:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=k/hSMubV2CSZSBSLDKar3QNIq194wMLgReotx7drAPA=; b=gJUJ7NE2RTwH24kjjoOL9M0H5zAgGZdaYZ5OVNIIb8nLb/Kr6p/LGgA3JkAjxGG5xZTw yMzxppy7yExprEApenFSkDLoJBuSctrWr/lCofdyi6/GY3TTPrr0bx0MzEB+CFPU4km4 vAdqZmT6Su7McBxP5Hc9LEFv5dYwFqrUWtlpoGYIJsrfDm93bKNWGAlV66BIVwWBwnY9 o7Dfue17VQ7FAGDxtjclIdLsSchVnzscH7syqqbvZBS6zx38OmpfY+0eqUkIt3H4RDM5 zT3EQ7SWgGIdsUXSCEENb9TnnfYf5kQQt4//OrNq11TEOi35m32SXXZBpTBSizQXCwcB +Q== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tgbjj9f2j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Oct 2023 15:53:22 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 393FrMdc031729 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Oct 2023 15:53:22 GMT Received: from [10.110.20.163] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 3 Oct 2023 08:53:21 -0700 Message-ID: <1c58a05b-1337-0287-225f-5a73b4c6828e@quicinc.com> Date: Tue, 3 Oct 2023 08:53:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 1/4] firmware: arm_scmi: Add polling support for completion in smc To: Sudeep Holla CC: , , Brian Masney , , , , , , , , References: <20230718160833.36397-1-quic_nkela@quicinc.com> <20230911194359.27547-1-quic_nkela@quicinc.com> <20230911194359.27547-2-quic_nkela@quicinc.com> <20231003103317.pjfmf6uisahowmom@bogus> Content-Language: en-US From: Nikunj Kela In-Reply-To: <20231003103317.pjfmf6uisahowmom@bogus> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 4MX0BOBsUn_jb1OK_dO6Y06XJ-gFn0XA X-Proofpoint-ORIG-GUID: 4MX0BOBsUn_jb1OK_dO6Y06XJ-gFn0XA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-03_12,2023-10-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 clxscore=1015 impostorscore=0 phishscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=865 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310030119 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_085333_741518_C9ACFC29 X-CRM114-Status: GOOD ( 22.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/3/2023 3:33 AM, Sudeep Holla wrote: > On Mon, Sep 11, 2023 at 12:43:56PM -0700, Nikunj Kela wrote: >> Currently, the return from the smc call assumes the completion of >> the scmi request. However this may not be true in virtual platforms >> that are using hvc doorbell. >> > Hmm, it is expectation from SMCCC for the fast calls. Is you HVC FID > not a fast call. AFAIK, only TOS use yielding calls. Are you using them > here ? If not, this must complete when the SMC/HVC returns. We added > support for platforms indicating the same via interrupt. > > I would like to avoid adding this build config. Why does it require polling ? > Broken firmware ? I would add a compatible for that. Or if the qcom always > wants to do this way, just make it specific to the qcom compatible. > > I would avoid a config flag as it needs to be always enabled for single > image and affects other platforms as well. So please drop this change. > If this is absolutely needed, just add additional property which DT > maintainers may not like as it is more like a policy or just make it > compatible specific. > > -- > Regards, > Sudeep We are using Fast call FID. We are using completion IRQ for all the scmi instances except one where we need to communicate with the server when GIC is in suspended state in HLOS. We will need to poll the channel for completion in that use case. I am open to suggestions. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel