From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F627C46499 for ; Fri, 5 Jul 2019 14:08:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7461A20828 for ; Fri, 5 Jul 2019 14:08:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d+mr2Viw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HjCiLjpJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JtlJfhOj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7461A20828 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gxJ2SsmCwuwU8hzqx3wecKMM2ReHWAPag8wDEN/WFRk=; b=d+mr2ViwXETlWfjjjOOkPWqO0 NC6GuAjhivmBNfmJmYD6EBxHPBuxUokcH6RWA9+V0bH09NGlfSIKp7jacDTkPjTimx2YncaPw1/s4 3zWD1N+TV7HlJz8bR9K9V7dQHvdRsBl8q6MUMCUA0jmtMFJ+Vz8K/pguNRrjOavqtPLH+hiSneouK EOzE0ZXoZKYRkZWPfI4oCuS7gtLP9ZtIY1J0UvCfjVJhX7uDRD4fBcrjGmT9S/Ryjyg9OIZvlX4wu Ocq88ZpUoKe2DfhSrrNeDRvz9NTsizS4+ZsWGYxjCzf8O4bNnbw6aYhOPZvdeqaBYQvZw9+7dQWhS r8bVRPAPg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hjOt3-000364-4Z; Fri, 05 Jul 2019 14:08:29 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjOt0-00035S-3n for linux-arm-kernel@bombadil.infradead.org; Fri, 05 Jul 2019 14:08:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jePOyDB+/BJqai65o/nniy/GmigQg37Te1D63738p1E=; b=HjCiLjpJZ1Mow87AEeRiIL0nUa StJA1GcwIwZbadfuwRTzyLc97n2XdnkXZtBx3J8blPrKEhZTOsk06B470KJNNEgKRNyffbrk32PBd +38AyCwRHcy59lafxnXqfseNFNLlTX0WVE7rNAZYH41gQvfjg1RVuppwEPdiwK86S9ONNqU+30CvU gXiZ3FLLu/nnayaFSRG+qNAiV/YdLHCXXqfsXLncR8p7x+9XE4Vneu/xiXws7RMIVGWuWOalXMdPY zQnwfdeiUlYFt8QJc8IIt8JLGl8PpFjiQ0MjxokgsCArCQl1JXnUTxS5TdBmnqCxjMxr+lsyJ1WuD Y2KkOP5w==; Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by casper.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjN7e-000175-RT for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2019 12:15:28 +0000 Received: by mail-pg1-x544.google.com with SMTP id z75so4243107pgz.5 for ; Fri, 05 Jul 2019 05:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jePOyDB+/BJqai65o/nniy/GmigQg37Te1D63738p1E=; b=JtlJfhOjR1la3EpAWrJCUcNV4oHwfD9FQubM6udvIOnuMNZ5uQpom0RPxotusXmHqm /7W3+ZerruZFxjPXXdsH5w5RvqPd3b1xaSL9W7Lf3ym0WRX2nM5yrjKiA28bEd6YUGrt NU3sZVP4+earPTO1vg2PCvVapr+lWxiawwFGRwzeVtOGW8cH+bKd46geULijeR+owSD7 2fINXPA8ilMbwNs4q9tygYZTG8azh5u9Sz8/9npjs3I7DHcNJM6iv5GDXQtnBuzoj/PI 5onvYs9savWSAkBlHPYoLmlgi5oxybS1sZIyOeKTbqUxyMT4MEjpUyaq9Q/Om6u60JZc 3yBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jePOyDB+/BJqai65o/nniy/GmigQg37Te1D63738p1E=; b=YNhYyyaeeK4aMfWu33xW2T8JYqaIPl9cdUA0q5wD2wyDauCP+jR8swu89oTr5DcS5M BCAL1oEJL9BfSCZ0EUk1vtstpGB4xOwsRfoLnEA+vb4fFgx+HS1AnrwEUK0FPOASFH4s 39oQc+xdYdbg4PZMwxd0KRCWetHedyPnZmC+/VZpFgNaX0sd5uxzw2iq801IYkiEstPS O23D0VCm+NJq2TenjSC3G/88ZwvHlCngEoledBAWRq8DOT4s7W2oRrWMuT9TjZ3PjRU5 qVhHuljWCUVmwjjmOac7tbO65HFugjxICI1K0/2IBYchWjFGzP1k4kDLMj0syEdVdy9o Uimg== X-Gm-Message-State: APjAAAWvCQOW0Y93k2mT6AfzK9n+E22TpYzkHypEhTJtacbVFRWwmz/R +lZVktMn8qxvTqtwqhNSCjSOD6TH X-Google-Smtp-Source: APXvYqy3i++VbGx86LnHqXfWM8gjGJRZBK1+vkUqx5LVHHUpUywmvMQXDo6JvqDrcbGPIIbM2HQ5uw== X-Received: by 2002:a63:b904:: with SMTP id z4mr5103509pge.388.1562328799173; Fri, 05 Jul 2019 05:13:19 -0700 (PDT) Received: from [10.0.2.15] ([122.163.64.117]) by smtp.gmail.com with ESMTPSA id m9sm5693445pgr.24.2019.07.05.05.13.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jul 2019 05:13:18 -0700 (PDT) Subject: Re: [PATCH 2/2] staging: media: sunxi: Replace function cedrus_check_format() To: Paul Kocialkowski References: <20190703081317.22795-1-nishkadg.linux@gmail.com> <20190703081317.22795-2-nishkadg.linux@gmail.com> <20190705102650.GB1645@aptenodytes> From: Nishka Dasgupta Message-ID: <1c5bd5a6-757e-2bce-6adf-6dafbf6956a6@gmail.com> Date: Fri, 5 Jul 2019 17:43:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190705102650.GB1645@aptenodytes> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190705_131526_911444_223C9E59 X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, maxime.ripard@bootlin.com, gregkh@linuxfoundation.org, wens@csie.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/07/19 3:56 PM, Paul Kocialkowski wrote: > Hi, > > On Wed 03 Jul 19, 13:43, Nishka Dasgupta wrote: >> Remove function cedrus_check_format as all it does is call >> cedrus_find_format. >> Rename cedrus_find_format to cedrus_check_format to maintain >> compatibility with call sites. >> Issue found with Coccinelle. > > Maybe we could have a !! or a bool cast to make coccinelle happy here? Coccinelle didn't flag the type mismatch, just the single-line functions. I could add the bool cast then? Thanking you, Nishka > Cheers, > > Paul > >> Signed-off-by: Nishka Dasgupta >> --- >> drivers/staging/media/sunxi/cedrus/cedrus_video.c | 10 ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c >> index 0ec31b9e0aea..d5cc9ed04fd2 100644 >> --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c >> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c >> @@ -55,8 +55,8 @@ static inline struct cedrus_ctx *cedrus_file2ctx(struct file *file) >> return container_of(file->private_data, struct cedrus_ctx, fh); >> } >> >> -static bool cedrus_find_format(u32 pixelformat, u32 directions, >> - unsigned int capabilities) >> +static bool cedrus_check_format(u32 pixelformat, u32 directions, >> + unsigned int capabilities) >> { >> struct cedrus_format *fmt; >> unsigned int i; >> @@ -76,12 +76,6 @@ static bool cedrus_find_format(u32 pixelformat, u32 directions, >> return false; >> } >> >> -static bool cedrus_check_format(u32 pixelformat, u32 directions, >> - unsigned int capabilities) >> -{ >> - return cedrus_find_format(pixelformat, directions, capabilities); >> -} >> - >> static void cedrus_prepare_format(struct v4l2_pix_format *pix_fmt) >> { >> unsigned int width = pix_fmt->width; >> -- >> 2.19.1 >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel