From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C2D3C10F0E for ; Mon, 15 Apr 2019 12:05:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 063FE20833 for ; Mon, 15 Apr 2019 12:05:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JbC9r6FH"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="I5wD9+DQ"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="I5wD9+DQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 063FE20833 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/n6qvgqJwFBp6Bt5b/tKof5DM3aYpPGIfwe00lOdpM0=; b=JbC9r6FHrM3LkUq3KGtpx4VIx Mnsvi220NxV1fo6uIsPSbv0TZ0vaoAOoA6cjNu/l2ZbIv/6G86yz97U/GJGPrwd928mvgTHs7mJYT 8wGR9L5X14byi4d5jrtjhhux9hWcm/POsJim3dco8BA2PBvIOWmlwB8ymzY5dU3nTYN3FkcrgXkfo wo0sqLL/aOaToMQWFzDZaO6aIqy5XRsbeLLXv6FCQCvjrZmhro+g/jh9eGMXXSo8bYVcFNlqShXKr NMdpsf1bD88pztJddbicYWoizchh/pNUE8WpbM7tSWoY/xwLzdR5VPZaUUFQhYmgGAgI4J3zn85ty Gxqv5bzVQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG0Mi-0006Ps-TE; Mon, 15 Apr 2019 12:05:36 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG0Lt-0004Ij-2d for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2019 12:05:12 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A716F615E8; Mon, 15 Apr 2019 12:04:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1555329884; bh=uphRgZl5YWC86zbVIpFwkVOZ0PYPGQtWO1cFBR4SNWo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=I5wD9+DQdi7WHHSdPDORKoNw4FQfWFDJraoxWPKvTpVrsRjhCihpnYlOCje6BeSy+ 1xIGUAyP7e3eE3SSGzC5gucO2mWV9P9nsjUasz8NrBjO4xRSj2+bsJAg8wDcDRuMC7 PwkA2YQnXrou08D/unYqzjYMvpuLoMEEFkOH+tnw= Received: from [10.79.129.68] (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vivek.gautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id DDB87615E8; Mon, 15 Apr 2019 12:04:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1555329884; bh=uphRgZl5YWC86zbVIpFwkVOZ0PYPGQtWO1cFBR4SNWo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=I5wD9+DQdi7WHHSdPDORKoNw4FQfWFDJraoxWPKvTpVrsRjhCihpnYlOCje6BeSy+ 1xIGUAyP7e3eE3SSGzC5gucO2mWV9P9nsjUasz8NrBjO4xRSj2+bsJAg8wDcDRuMC7 PwkA2YQnXrou08D/unYqzjYMvpuLoMEEFkOH+tnw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DDB87615E8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org Subject: Re: [PATCH 1/1] iommu/arm-smmu: Add SID information to context fault log To: Marc Gonzalez References: <20190415080734.6843-1-vivek.gautam@codeaurora.org> <5cee3aa1-6bef-25bf-2a34-06d086ca76dd@free.fr> From: Vivek Gautam Message-ID: <1c73617c-64a5-0c9f-7791-72e596a4e21f@codeaurora.org> Date: Mon, 15 Apr 2019 17:34:40 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <5cee3aa1-6bef-25bf-2a34-06d086ca76dd@free.fr> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190415_050445_669901_BB058FF2 X-CRM114-Status: GOOD ( 13.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: MSM , Linux ARM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On 4/15/2019 2:24 PM, Marc Gonzalez wrote: > Trimming CC list for very minor suggestions (feel free to ignore) Thanks for the review. Please find my responses inline below. > > On 15/04/2019 10:07, Vivek Gautam wrote: > >> Extract the SID and add the information to context fault log. >> This is specially useful in a distributed smmu architecture >> where multiple masters are connected to smmu. SID information >> helps to quickly identify the faulting master device. > I find it slightly clearer to keep acronyms capitalized, such as SMMU. Sure, will change it. > > >> @@ -575,7 +575,10 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev) >> struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain); >> struct arm_smmu_cfg *cfg = &smmu_domain->cfg; >> struct arm_smmu_device *smmu = smmu_domain->smmu; >> + void __iomem *gr1_base = ARM_SMMU_GR1(smmu); >> void __iomem *cb_base; >> + u32 cbfrsynra; >> + u16 sid; >> >> cb_base = ARM_SMMU_CB(smmu, cfg->cbndx); >> fsr = readl_relaxed(cb_base + ARM_SMMU_CB_FSR); >> @@ -586,9 +589,16 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev) >> fsynr = readl_relaxed(cb_base + ARM_SMMU_CB_FSYNR0); >> iova = readq_relaxed(cb_base + ARM_SMMU_CB_FAR); >> >> + cbfrsynra = readl_relaxed(gr1_base + >> + ARM_SMMU_GR1_CBFRSYNRA(cfg->cbndx)); > I find it slightly clearer to write > > void __iomem *reg; > ... > reg = ARM_SMMU_GR1(smmu) + ARM_SMMU_GR1_CBFRSYNRA(cfg->cbndx); > cbfrsynra = readl_relaxed(reg); I would actually argue here, to go with the flow of how this function declares the variables, for the simple case of symmetry. Let me know what do you think. Thanks & regards Vivek > > Regards. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel