From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4D17C433E0 for ; Fri, 22 Jan 2021 06:05:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D6EE238D7 for ; Fri, 22 Jan 2021 06:05:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D6EE238D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=63gcTVjZPOxVpyjaJ4bQXMafakZ8IJHzILrveSd0ufQ=; b=LIhEPTrcoOwyANmOXCLVenPCJ iNF22SJ6TfeQ+QEL2/KN8v+zi/fmWXM8M0Pf4esM3QxWnx307GqP34kuzOGoDexBGebyZRbRbXBvs 6BgqfKCM3NFk3Y+ZIg/EDwFPykLODhqEnGNIlvWxzwNoWH2FXZZHVIF07Po7CHy2d6l4B7X8hxNTD DF3KQpQsl10MwShSyxstUeH4TqzgUnwRpmdpKWTv5rQIeBHYb0cyAUz1KzRabDi38neFS3rP9nweh qCiXtbMKbdOwiUxYRcGgrwFRU0UQyyHzaCUpCIy9qFUMfy79bpM3saFLDnANFyPQV7ZzTyVFLRy90 3xBXYm6VQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2pYM-0004Vk-Hx; Fri, 22 Jan 2021 06:04:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2pYJ-0004Ue-Rq for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 06:04:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BFDF211B3; Thu, 21 Jan 2021 22:04:04 -0800 (PST) Received: from [10.163.92.92] (unknown [10.163.92.92]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8B7D03F68F; Thu, 21 Jan 2021 22:04:00 -0800 (PST) Subject: Re: [PATCH V3 0/3] mm/memory_hotplug: Pre-validate the address range with platform From: Anshuman Khandual To: Oscar Salvador , David Hildenbrand References: <1610975582-12646-1-git-send-email-anshuman.khandual@arm.com> <20210119134016.GA23408@linux> <8df4e1e1-1ddd-398e-c9a6-17a67d8a95bc@arm.com> Message-ID: <1c8c204d-1f96-d3aa-1b7b-ec4cc7b1b79b@arm.com> Date: Fri, 22 Jan 2021 11:34:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8df4e1e1-1ddd-398e-c9a6-17a67d8a95bc@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_010411_975441_BB3B1B93 X-CRM114-Status: GOOD ( 17.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-s390@vger.kernel.org, Vasily Gorbik , catalin.marinas@arm.com, hca@linux.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/20/21 2:07 PM, Anshuman Khandual wrote: > > > On 1/19/21 7:10 PM, Oscar Salvador wrote: >> On Tue, Jan 19, 2021 at 02:33:03PM +0100, David Hildenbrand wrote: >>> Minor thing, we should make up our mind if we want to call stuff >>> internally "memhp_" or "mhp". I prefer the latter, because it is shorter. >> >> I would rather use the latter as well. I used that in [1]. > > Okay, will change all that is 'memhp' as 'mhp' instead. > >> MEMHP_MERGE_RESOURCE should be renamed if we agree on that. >> >> [1] https://patchwork.kernel.org/project/linux-mm/cover/20201217130758.11565-1-osalvador@suse.de/ >> While replacing 'memhp' as 'mhp' in this series, noticed there are some more 'memhp' scattered around the code from earlier. A mix of both 'memhp' and 'mhp' might not be a good idea. Hence should we just change these remaining 'memhp' as 'mhp' as well and possibly also MEMHP_MERGE_RESOURCE as suggested earlier, in a subsequent clean up patch ? Would there be a problem with memhp_default_state being a command line parameter ? >From a tree wide search - Documentation/admin-guide/kernel-parameters.txt: memhp_default_state=online/offline drivers/base/memory.c:int memhp_online_type_from_str(const char *str) drivers/base/memory.c: const int online_type = memhp_online_type_from_str(buf); drivers/base/memory.c: online_type_to_str[memhp_default_online_type]); drivers/base/memory.c: const int online_type = memhp_online_type_from_str(buf); drivers/base/memory.c: memhp_default_online_type = online_type; include/linux/memory_hotplug.h:extern int memhp_online_type_from_str(const char *str); include/linux/memory_hotplug.h:extern int memhp_default_online_type; mm/memory_hotplug.c:int memhp_default_online_type = MMOP_OFFLINE; mm/memory_hotplug.c:int memhp_default_online_type = MMOP_ONLINE; mm/memory_hotplug.c:static int __init setup_memhp_default_state(char *str) mm/memory_hotplug.c: const int online_type = memhp_online_type_from_str(str); mm/memory_hotplug.c: memhp_default_online_type = online_type; mm/memory_hotplug.c:__setup("memhp_default_state=", setup_memhp_default_state); mm/memory_hotplug.c: mem->online_type = memhp_default_online_type; mm/memory_hotplug.c: if (memhp_default_online_type != MMOP_OFFLINE) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel