From: Suzuki Kuruppassery Poulose <suzuki.poulose@arm.com>
To: hejunhao <hejunhao3@huawei.com>,
mathieu.poirier@linaro.org, mike.leach@linaro.org,
leo.yan@linaro.org, jonathan.cameron@huawei.com,
john.garry@huawei.com
Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
lpieralisi@kernel.org, linuxarm@huawei.com,
yangyicong@huawei.com, liuqi115@huawei.com,
f.fangjian@huawei.com, prime.zeng@hisilicon.com
Subject: Re: [PATCH v13 1/2] drivers/coresight: Add UltraSoc System Memory Buffer driver
Date: Mon, 21 Nov 2022 10:47:24 +0000 [thread overview]
Message-ID: <1c8da30c-d798-729d-c8e5-73a07f8b9f18@arm.com> (raw)
In-Reply-To: <c07e6417-7a37-3cf5-d3dd-b3ce7b3c20b1@huawei.com>
On 18/11/2022 12:45, hejunhao wrote:
> Hi Suzuki ,
>
>
> On 2022/11/15 19:06, Suzuki K Poulose wrote:
>> On 14/11/2022 09:03, Junhao He wrote:
>>> From: Qi Liu <liuqi115@huawei.com>
>>>
>>> +static void smb_init_hw(struct smb_drv_data *drvdata)
>>> +{
>>> + /* First disable SMB and clear the status of SMB buffer */
>>> + smb_reset_buffer_status(drvdata);
>>> + smb_disable_hw(drvdata);
>>> + smb_purge_data(drvdata);
>>> +
>>> + writel(SMB_LB_CFG_LO_DEFAULT, drvdata->base + SMB_LB_CFG_LO_REG);
>>> + writel(SMB_LB_CFG_HI_DEFAULT, drvdata->base + SMB_LB_CFG_HI_REG);
>>> + writel(SMB_GLB_CFG_DEFAULT, drvdata->base + SMB_GLB_CFG_REG);
>>> + writel(SMB_GLB_INT_CFG, drvdata->base + SMB_GLB_INT_REG);
>>> + writel(SMB_LB_INT_CTRL_CFG, drvdata->base + SMB_LB_INT_CTRL_REG);
>>
>> Does this come with interrupt on overflow ? Do we not use this ?
>>
> When the buffer overflow, no interrupt will come.
> Interrupt will upgrade SMB_LB_INT_STS_REG register status if start trace.
> Thanks.
>> Rest looks fine to me.
What is the purpose of the "Interrupt" on the SMB ? It is not clear to
me.
Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-21 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 9:03 [PATCH v13 0/2] Add support for UltraSoc System Memory Buffer Junhao He
2022-11-14 9:03 ` [PATCH v13 1/2] drivers/coresight: Add UltraSoc System Memory Buffer driver Junhao He
2022-11-15 11:06 ` Suzuki K Poulose
2022-11-18 12:45 ` hejunhao
2022-11-21 10:47 ` Suzuki Kuruppassery Poulose [this message]
2022-11-22 13:23 ` hejunhao
2022-11-22 14:06 ` Suzuki K Poulose
2022-11-23 6:54 ` hejunhao
2022-11-14 9:03 ` [PATCH v13 2/2] Documentation: Add document for UltraSoc SMB drivers Junhao He
2022-11-14 13:57 ` Bagas Sanjaya
2022-11-15 7:33 ` hejunhao
2022-11-15 7:35 ` Bagas Sanjaya
2022-11-15 11:01 ` hejunhao
2022-11-14 13:11 ` [PATCH v13 0/2] Add support for UltraSoc System Memory Buffer Bagas Sanjaya
2022-11-15 7:52 ` hejunhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c8da30c-d798-729d-c8e5-73a07f8b9f18@arm.com \
--to=suzuki.poulose@arm.com \
--cc=coresight@lists.linaro.org \
--cc=f.fangjian@huawei.com \
--cc=hejunhao3@huawei.com \
--cc=john.garry@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=lpieralisi@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=prime.zeng@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).