From: Yang Shi <yang@os.amperecomputing.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: jgg@ziepe.ca, james.morse@arm.com, will@kernel.org,
robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for 32-bit sid size
Date: Wed, 2 Oct 2024 12:04:32 -0700 [thread overview]
Message-ID: <1c9767e1-4d05-4650-bc14-65a18fc63cc2@os.amperecomputing.com> (raw)
In-Reply-To: <Zv2ONA2b3+kMAizm@Asurada-Nvidia>
On 10/2/24 11:17 AM, Nicolin Chen wrote:
> I think both v1 and v2 are missing iommu@lists.linux.dev in CC.
Will do it for the later revision.
>
> On Wed, Oct 02, 2024 at 10:55:14AM -0700, Yang Shi wrote:
>> +static inline unsigned int arm_smmu_strtab_max_sid(struct arm_smmu_device *smmu)
>> +{
>> + return (1ULL << smmu->sid_bits);
>> +}
>> +
> Hmm, why ULL gets truncated to unsigned int here?
No particular reason, but it should be better to not truncate here. Will
fix it.
>
> Thanks
> Nicolin
next prev parent reply other threads:[~2024-10-02 19:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 17:55 [v2 PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for 32-bit sid size Yang Shi
2024-10-02 18:14 ` Jason Gunthorpe
2024-10-02 18:17 ` Nicolin Chen
2024-10-02 19:04 ` Yang Shi [this message]
2024-10-02 19:22 ` Nicolin Chen
2024-10-02 19:40 ` Jason Gunthorpe
2024-10-02 20:00 ` Yang Shi
2024-10-02 20:05 ` Yang Shi
2024-10-03 11:16 ` Jason Gunthorpe
2024-10-03 15:31 ` Yang Shi
2024-10-04 12:43 ` Jason Gunthorpe
2024-10-04 16:05 ` Yang Shi
2024-10-04 16:14 ` Jason Gunthorpe
2024-10-04 16:29 ` Yang Shi
2024-10-04 16:37 ` Yang Shi
2024-10-04 16:41 ` Jason Gunthorpe
2024-10-04 16:46 ` Yang Shi
2024-10-02 19:50 ` Yang Shi
2024-10-02 18:21 ` Robin Murphy
2024-10-02 18:36 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c9767e1-4d05-4650-bc14-65a18fc63cc2@os.amperecomputing.com \
--to=yang@os.amperecomputing.com \
--cc=james.morse@arm.com \
--cc=jgg@ziepe.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox