From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86A22C43334 for ; Sat, 18 Jun 2022 14:12:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PqQn0wNxVWHBlFPRvnWwLFBhF5dscJbJM/J4GtolcGQ=; b=L8CWOkLPHs3brV qvU2d7R1vzgaGZLNsm4qhAmH08G0D33Yl+0O/M3PvrleeSESXqAU6bPi94kmsuEh+ThqVQnQNPT/1 uw3hhZl3XH7rVxMgsPGAUfn1P3+TD7ig5qFBjjfTxMXWjCBnYV4NJkaAaS70ZbV4N6oFlInT8FpDX xxt90cdebJs6epSpZ0hUpsN/ZLOdowi8yuqvD6Dzed5CXlsQU+EEQFmLDkDLV75x4KwiF24HeKbss 7Nud2OkwzMWfHgBE+aj5ZswYHJkv0Q7+vC0YLDwQXT+zIZBx6MU7Zxi6KEOlSA5yg7YLnp7jorQFU yP0DQo0xtgtMJetgbI1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2ZA0-00BVM6-Sv; Sat, 18 Jun 2022 14:10:49 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2Z9x-00BVLK-ER for linux-arm-kernel@lists.infradead.org; Sat, 18 Jun 2022 14:10:46 +0000 Received: by mail-pg1-x535.google.com with SMTP id r66so436377pgr.2 for ; Sat, 18 Jun 2022 07:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=ow8g3o4z79Y5Cr2CRU5IK8a4Nx81Y5TgND6Vb+EHq2A=; b=I2mm4Rlo4JbRzZncPQX5K+A6VfD1WPz4umBSLloPa2vNlBf5n7u5e5Q8ck/n8xAcgT SBsy6yUmq4Nv/ftAlSnchjoAmeca+Hii490/4yQu/Q5CplEQnBwBbj1zpv4KDgJ/Xp0N qm0029PtaHAO1cp6pQf2xUdNQPQYXnSXdC/ivYthGppz2aHagL+qstK4OTw7siJoPBLI 6BTuTLNHMRMV/+e69E6JqGJov0BVUOHahFc31t6rDcW7tnFdboAtvd1pF+ySSVvyNXlI i0MkFeVBXo6cMdKv3b0tjXXRJKHMGNXdLBNNYjqUuiNQ/UVfzNsBQqCV1kaJSgYF+j9R sPCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ow8g3o4z79Y5Cr2CRU5IK8a4Nx81Y5TgND6Vb+EHq2A=; b=zs5Ly5aN016dvPYQAtyXhQEsKvdDTT87jMfuAafybF2ecWCsX/N09Hz7dPdadf77eN tQHb23M+NGI3cwAgRJWmxfQcJLVX9wqBsOpEoGq4ZZsOY4y0qlq0ZMyg2h7YI/fezeUT YASDd1MrSO8CRQj7nsKHS+Ar6bC7lDz9lwVU42jKVzrmgTBgd5SnPzok924WwN6qqYYu WYheQ/29iXtrzcLgZK54fQVFotYgb6E6AVWZPoR3BcPlIEPLuPTpttlU1Aj7z5yRZX/S 7Kc7eqj5iLlz+Gm/hx+yphs5JZnreu94tzwtLoEeJzsyOzZxjUfDNeqyHdt5QPgJLEnp 9yHQ== X-Gm-Message-State: AJIora9qW/ZcdJLOy+DShBKHmjRB9kxk0/Q5hXSPYM8RjYD39rGJe76O wcIYXADH7hSAZURbppXVrxw= X-Google-Smtp-Source: AGRyM1uBDBheUIBa3LF5ThEugEca5LdgbPgylYXdAbfL/ChjXdHKb3W7RxpttWO98MxnzMb+JkAjJQ== X-Received: by 2002:a05:6a00:21c2:b0:4fa:914c:2c2b with SMTP id t2-20020a056a0021c200b004fa914c2c2bmr12088578pfj.56.1655561443391; Sat, 18 Jun 2022 07:10:43 -0700 (PDT) Received: from [172.30.1.37] ([14.32.163.5]) by smtp.gmail.com with ESMTPSA id j4-20020a62c504000000b00518a473265csm997780pfg.217.2022.06.18.07.10.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jun 2022 07:10:42 -0700 (PDT) Message-ID: <1c9e0697-ff02-d678-f231-8a3bc2e6be6e@gmail.com> Date: Sat, 18 Jun 2022 23:10:37 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events Content-Language: en-US To: Miaoqian Lin , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220526082856.37594-1-linmq006@gmail.com> From: Chanwoo Choi In-Reply-To: <20220526082856.37594-1-linmq006@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220618_071045_555542_6BDC55FB X-CRM114-Status: GOOD ( 19.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22. 5. 26. 17:28, Miaoqian Lin wrote: > of_get_child_by_name() returns a node pointer with refcount > incremented, we should use of_node_put() on it when done. > This function only calls of_node_put() in normal path, > missing it in error paths. > Add missing of_node_put() to avoid refcount leak. > > Fixes: f262f28c1470 ("PM / devfreq: event: Add devfreq_event class") > Signed-off-by: Miaoqian Lin > --- > drivers/devfreq/event/exynos-ppmu.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > index 9b849d781116..a443e7c42daf 100644 > --- a/drivers/devfreq/event/exynos-ppmu.c > +++ b/drivers/devfreq/event/exynos-ppmu.c > @@ -519,15 +519,19 @@ static int of_get_devfreq_events(struct device_node *np, > > count = of_get_child_count(events_np); > desc = devm_kcalloc(dev, count, sizeof(*desc), GFP_KERNEL); > - if (!desc) > + if (!desc) { > + of_node_put(events_np); > return -ENOMEM; > + } > info->num_events = count; > > of_id = of_match_device(exynos_ppmu_id_match, dev); > if (of_id) > info->ppmu_type = (enum exynos_ppmu_type)of_id->data; > - else > + else { > + of_node_put(events_np); > return -EINVAL; > + } > > j = 0; > for_each_child_of_node(events_np, node) { Applied it. Thanks. -- Best Regards, Samsung Electronics Chanwoo Choi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel