From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15DB5C433EF for ; Tue, 17 May 2022 14:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SXv1KuD0lgbMYvXbWiG9nh7h9bOK3rWmVAj8j2SvPcU=; b=ZLtB2CP52SvATP fihu1UfqfuDZkwQvtx2xZqtj6JS0O5BrNvqqYGK0qOvPZcn1mQvUkJmTX/dYAy790s8gpIYQJstpM DqH/fuDydGP3/085IRNr4QI1IlRuT1ceJhcUmjHxtie2UnjxXridUXPs1H0RDl8lj3vJPjCSP/2k5 pWsAdgusO/EWDW3CeLVf4G7cUv/nMZZ9ju8DJb9F/fr7cYffIefcIQPQ9IG2mpdSPJrHtH83Nz7jx oPyjwIUZqaxe7KSQTRusZMe2cw0QQBrxgdoBnz0wFGWqTJX/fIWymJ3Z6sNL5r2+jeYmm2e5O+O9X WStrxt6HCalB0LYyNkNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqyHq-00ETAm-47; Tue, 17 May 2022 14:34:58 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqyH5-00ESdF-1p for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 14:34:16 +0000 Received: by mail-lf1-x12a.google.com with SMTP id bu29so31778493lfb.0 for ; Tue, 17 May 2022 07:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=i7zyBF11Q2Vl2Fn+mqi0uKcM3WsZAR1VgADTgLmAWKM=; b=JCpSk0IGHnwfJTk7xQhJe8A+lFomuiac/OqKtv6lqPa9YRBRc6Oy0LsPRvupnoGUl5 4PfRwcZrn4Haar93JXSl4ALQqT1DVsfdFrAJNzt/ot9BFe0O6TiqWjycRaO87u2A4WDx Rf7T6tFEbSdsmJyfKg2M2cq3FkJTiztv+oMb+vcTV2T4U303G93rrs8qi/PYVF+CniPQ eTUVG5bd8aoQ3p5tU2YNJHXLytDO8D/tEUaDYyRv4HksDgXF+RP5zNP/W7Y/LUvIbhyw 1NcfZl0Guvv86a6A6VONM9dBMgs4kb1ThWETAmhIXwd9FeNfXyyxcAHmHwt4vhMSz4s4 bK6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=i7zyBF11Q2Vl2Fn+mqi0uKcM3WsZAR1VgADTgLmAWKM=; b=hxg4FNncnGi62LocTRKYVvdFElAmf6M7dQ+qIjDKWVR7DoIc2B9QM+dbPvjr+53ocQ gDIfwabGn4YWIM00ZgdChD8jEzbVzS1B2YIKpZfIRgsgBU+6zUDXdR+2/7CYpEqAqYoF oKqWloIS6kRqGufwSceV+HPOw1gotqByWhSO9Lf4RqtR07axMYv7ZoBzDHP5MhHRE+JK MUwbWzYywJW5grB4JjIqWKWRMbI8q4Oh66Jod6Z9Gv8n7H3hldzXKxnjbIcKoHse2D0l 0ghYA5+1HdvErZ3yNXncyLa4gC8u8tXeSk3XhVAYOh6NqCkldv0vo5AMNHbqgfz69+/U NvKA== X-Gm-Message-State: AOAM532nUlgTCp6HZfnsgEylO33a7vCwzYFJz6nXF/P/XKjO0DV6yn8L /UjupzvRWJKiFYC46ogHWkjxrg== X-Google-Smtp-Source: ABdhPJxmyXlow8oB2WHW+IPzYvMvUo7PgS65PH8PfGpbQdVffrPDgyMeyka8WdFf8rtH5SvKTFfMHg== X-Received: by 2002:a19:5043:0:b0:472:36fd:4fc2 with SMTP id z3-20020a195043000000b0047236fd4fc2mr16723908lfj.258.1652798047702; Tue, 17 May 2022 07:34:07 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id p13-20020a19f00d000000b0047255d211c1sm1601365lfc.240.2022.05.17.07.34.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 07:34:07 -0700 (PDT) Message-ID: <1cec6a09-9d80-99e7-ccc4-c918c6be7dbb@linaro.org> Date: Tue, 17 May 2022 16:34:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property Content-Language: en-US To: AngeloGioacchino Del Regno , robh+dt@kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, sboyd@kernel.org, chun-jie.chen@mediatek.com, rex-bc.chen@mediatek.com, wenst@chromium.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220517101514.21639-1-angelogioacchino.delregno@collabora.com> <20220517101514.21639-3-angelogioacchino.delregno@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20220517101514.21639-3-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_073411_141037_B5BC6F2A X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote: > This is a clock-controller binding, so it needs #clock-cells, or > it would be of no use: add that to the list of required properties. > > Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock") > Signed-off-by: AngeloGioacchino Del Regno > --- > .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + If these are clock controllers and new bindings, why they were added to "arm" directory? arm is only for top-level stuff, not for devices. In the future please put your bindings in respective subsystem matching the hardware. Fallback is soc directory, not arm. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel