From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
"huziji@marvell.com" <huziji@marvell.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: mmc: xenon: Convert to JSON schema
Date: Mon, 21 Mar 2022 09:18:32 +0100 [thread overview]
Message-ID: <1cf2b374-5083-ea02-94af-cf6e3ce7b0e8@kernel.org> (raw)
In-Reply-To: <fd8cb680-5ae0-6b47-3f35-a497c51a47b9@alliedtelesis.co.nz>
On 21/03/2022 01:12, Chris Packham wrote:
> (adding some ARM people, resending hopefully without the html)
>
> On 19/03/22 03:20, Krzysztof Kozlowski wrote:
>>> + - const: marvell,sdhci-xenon
>> This did not exist before. Separate patches please for additions (with
>> explanation why). Maybe some DTS lists this, but then it should be
>> individually judged whether the DTS is correct.
>>
> On this specifically. I was all ready to add an additional patch to
> document this but then I noticed nothing actually uses the
> "marvell,sdhci-xenon" compatible and it appears nothing ever did. I then
> figured I'd delete the unused compatible string from armada-37xx.dtsi
> but then I remembered that sometimes we add compatible strings to have
> them "just in case" we need them for some SoC specific workaround.
>
> So there's a few things I can do
>
> 0. Nothing (easy) although the binding I just submitted will complain
> about the unexpected value
> 1. Document "marvell,sdhci-xenon" as a valid compatible
> 1.a. Add "marvell,sdhci-xenon" to the sdhci-xenon.c driver
> 2. Remove "marvell,sdhci-xenon" from armada-37xx.dtsi
Option 1 in a new patch, explaining why you are adding it.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-03-21 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220318033521.1432767-1-chris.packham@alliedtelesis.co.nz>
[not found] ` <91b6660d-c22b-0679-4cb9-6ebba9066545@kernel.org>
2022-03-21 0:12 ` [PATCH] dt-bindings: mmc: xenon: Convert to JSON schema Chris Packham
2022-03-21 8:18 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cf2b374-5083-ea02-94af-cf6e3ce7b0e8@kernel.org \
--to=krzk@kernel.org \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=huziji@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).