From: Michal Simek <michal.simek@amd.com>
To: Thilo Zirnstein <thi.zirnstein@gmail.com>,
Andi Shyti <andi.shyti@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
"Dubakula, Venkatesh" <venkatesh.dubakula@amd.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Subject: Re: [PATCH v2 1/1] i2c: i2c-xiic: fix clearing of bnb irq
Date: Fri, 16 Oct 2026 14:41:35 +0200 [thread overview]
Message-ID: <1d3a38fe-0d67-4911-bd4a-6d101ba83405@amd.com> (raw)
In-Reply-To: <atH2njvkxHjq_75E@thi-server.fritz.box>
+Shubhrajyoti, Venkatesh
On 10/16/26 12:04, Thilo Zirnstein wrote:
> Hi Andi,
>
> Thanks for your review and feedback.
>
> On Fri, Oct 16, 2026 at 01:51:35AM +0200, Andi Shyti wrote:
>> Hi Thilo,
>>
>> On Thu, Oct 15, 2026 at 10:11:27AM +0200, Thilo Zirnstein wrote:
>>> Add a function for clearing the bnb bit,
>>> It waits for all preconditions before clearing the bnb bit or times out.
>>>
>>> Tested on Zynqmp dev board with some custom logic.
>>> Tested-by: Thilo Zirnstein <thi.zirnstein@gmail.com>
>>>
>>
>> Please, don't leave blank lines between tags. Moreover in this
>> case I don't need your Tested-by, I believe you tested your patch
>> before sending.
>
> Ack
>
>>
>>> Signed-off-by: Thilo Zirnstein <thi.zirnstein@gmail.com>
>>
>> I'd need here an ack from Michal.
>
> Ok, but this is nothing i can steer somehow - right ?
Just give us some time to look at it.
Shubhrajyoti: Can you please look at the patch?
Venkatesh: Can you please test it on boards?
Thanks,
Michal
prev parent reply other threads:[~2026-10-16 12:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 8:11 [PATCH v2 0/1] i2c: i2c-xiic: fix clearing of bnb irq Thilo Zirnstein
2026-10-15 8:11 ` [PATCH v2 1/1] " Thilo Zirnstein
2026-10-15 23:51 ` Andi Shyti
2026-10-16 10:04 ` Thilo Zirnstein
2026-10-16 12:41 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d3a38fe-0d67-4911-bd4a-6d101ba83405@amd.com \
--to=michal.simek@amd.com \
--cc=andi.shyti@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=radhey.shyam.pandey@amd.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=thi.zirnstein@gmail.com \
--cc=venkatesh.dubakula@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox