From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D15BC282DD for ; Wed, 8 Jan 2020 18:03:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED7002067D for ; Wed, 8 Jan 2020 18:03:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sRppMisb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="slsvJMEW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED7002067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k4/O2QrKTwQFMLJiyYOjlKs4y2pYBqj/E44p4YH81HE=; b=sRppMisbF/syNr AX29Ps1qiA0PS8l1EHYIsP5VlrNZdvoTSHysb5UXafbsO8a5SR0dsxmIWV944TFeisDu2QBy3uXwG aiKqGJTXxa2Q/qA41kDGT4EhEDkPkP2/Oss2t7xD33R6gLCulwxCT0/NMjkjH8njf6hJ88M7o7oAb NjVY7pO3/3buOtdfPLOlv3UF73drtbhmE6neZae5NrgsmSq2/deyXr3OLaC/Ubg0ShknozEKctwlF hbYam62IT7UuiJcNUfuJGk286YN+qMJcEacqDFbnT+BbedrKygY5vQyziFDbEYLn6fSPjKj9/8Gnc aiiNGkNeWhdmFD96tB3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipFgJ-0006rJ-H6; Wed, 08 Jan 2020 18:03:47 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipFgG-0006pg-HN; Wed, 08 Jan 2020 18:03:45 +0000 Received: by mail-ed1-x542.google.com with SMTP id m8so3291225edi.13; Wed, 08 Jan 2020 10:03:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=i1tfu3hzWGLcDtJ61MWCbPmVimgAN/gzhifzT41dVSE=; b=slsvJMEWqH1SBUQ69EjoLHEAPtsa9rsw8bbf3/XGhip3C1CCmzLkiGl3cUcznFm6d0 YoBIga6QCDw27V99V2ZBJLd0qBM+GGz9af4fyNZ79CSKIE2v52agOHj4JXN5+dyq8IIs akLLAwXmagBWpCp9CL7fGMpvu5eqxneFlNLjgj6B6USW7rCBU1iqvJfGxAYAE66Xdlk2 3GzIwvOKDwet90x5/PVhFa97Q+uQmNlpMJKjs0/3ESKYoDZuclXsuWRnyqTQPcF/eLER G93ocb1YDmrLGeLNGBkXUawvL3cK0z1UGwRQuTKEyr6lBnhhCKrebk15ZQ3vFZb1n/NJ hajA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=i1tfu3hzWGLcDtJ61MWCbPmVimgAN/gzhifzT41dVSE=; b=ihPH291j/PdMR7YcFAQRIh0CmQU5fWSjGcpfdfHLD9+iTcDp9gUIgDIerYyWQY2cJL X6O9ruOaAmIvmli1hsrNHAL8n7/uMwJOYuVqqTkixB6pgEUH7QmQsmS/GXrmxTcjTFp7 Hd7EfcC7vq7tGNMGWjfK0sEEQAlgQE9kyaJQjlEn6fZkTswFhGNEfFi7PsxTa5GMhzY4 QmFotZHtbhuCmEpJFcMoVK2axdCoGrUKNhxVdDGkmcZRKk5bLKaPnb9TthVjFTBlDBD2 X3L+XLnwlQam7x3TH46jFIBfg4zpxlP039L9rK/F90hYRFqpaquhhg97rc7T6xOpdILQ avew== X-Gm-Message-State: APjAAAWKo+u8X3O4P62w9YSR7zVX0/uCnJePmyiy5a7sISPmbUJ4lStJ agNwNvhur/Etr7C8bsyM/8j8RKN5 X-Google-Smtp-Source: APXvYqwNUefmVlHNoyJRH4hhCju9yadMsulixPytlLWF1oSaxWokTX9EwW5ecLI0qm1p6Qt1Zx18NA== X-Received: by 2002:aa7:c550:: with SMTP id s16mr6827862edr.297.1578506622735; Wed, 08 Jan 2020 10:03:42 -0800 (PST) Received: from [10.67.50.41] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id u13sm55092ejz.69.2020.01.08.10.03.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2020 10:03:42 -0800 (PST) Subject: Re: [PATCH net-next] net: dsa: Remove indirect function call for flow dissection To: Vladimir Oltean References: <20200102233657.12933-1-f.fainelli@gmail.com> <91eb2720-d933-f1fd-8d50-e9a81434545b@gmail.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOwU0EVxvH8AEQAOqv6agYuT4x3DgFIJNv9i0e S443rCudGwmg+CbjXGA4RUe1bNdPHYgbbIaN8PFkXfb4jqg64SyU66FXJJJO+DmPK/t7dRNA 3eMB1h0GbAHlLzsAzD0DKk1ARbjIusnc02aRQNsAUfceqH5fAMfs2hgXBa0ZUJ4bLly5zNbr r0t/fqZsyI2rGQT9h1D5OYn4oF3KXpSpo+orJD93PEDeseho1EpmMfsVH7PxjVUlNVzmZ+tc IDw24CDSXf0xxnaojoicQi7kzKpUrJodfhNXUnX2JAm/d0f9GR7zClpQMezJ2hYAX7BvBajb Wbtzwi34s8lWGI121VjtQNt64mSqsK0iQAE6OYk0uuQbmMaxbBTT63+04rTPBO+gRAWZNDmQ b2cTLjrOmdaiPGClSlKx1RhatzW7j1gnUbpfUl91Xzrp6/Rr9BgAZydBE/iu57KWsdMaqu84 JzO9UBGomh9eyBWBkrBt+Fe1qN78kM7JO6i3/QI56NA4SflV+N4PPgI8TjDVaxgrfUTV0gVa cr9gDE5VgnSeSiOleChM1jOByZu0JTShOkT6AcSVW0kCz3fUrd4e5sS3J3uJezSvXjYDZ53k +0GS/Hy//7PSvDbNVretLkDWL24Sgxu/v8i3JiYIxe+F5Br8QpkwNa1tm7FK4jOd95xvYADl BUI1EZMCPI7zABEBAAHCwagEGBECAAkFAlcbx/ACGwICKQkQYVeZFbVjdg7BXSAEGQECAAYF Alcbx/AACgkQh9CWnEQHBwSJBw//Z5n6IO19mVzMy/ZLU/vu8flv0Aa0kwk5qvDyvuvfiDTd WQzq2PLs+obX0y1ffntluhvP+8yLzg7h5O6/skOfOV26ZYD9FeV3PIgR3QYF26p2Ocwa3B/k P6ENkk2pRL2hh6jaA1Bsi0P34iqC2UzzLq+exctXPa07ioknTIJ09BT31lQ36Udg7NIKalnj 5UbkRjqApZ+Rp0RAP9jFtq1n/gjvZGyEfuuo/G+EVCaiCt3Vp/cWxDYf2qsX6JxkwmUNswuL C3duQ0AOMNYrT6Pn+Vf0kMboZ5UJEzgnSe2/5m8v6TUc9ZbC5I517niyC4+4DY8E2m2V2LS9 es9uKpA0yNcd4PfEf8bp29/30MEfBWOf80b1yaubrP5y7yLzplcGRZMF3PgBfi0iGo6kM/V2 13iD/wQ45QTV0WTXaHVbklOdRDXDHIpT69hFJ6hAKnnM7AhqZ70Qi31UHkma9i/TeLLzYYXz zhLHGIYaR04dFT8sSKTwTSqvm8rmDzMpN54/NeDSoSJitDuIE8givW/oGQFb0HGAF70qLgp0 2XiUazRyRU4E4LuhNHGsUxoHOc80B3l+u3jM6xqJht2ZyMZndbAG4LyVA2g9hq2JbpX8BlsF skzW1kbzIoIVXT5EhelxYEGqLFsZFdDhCy8tjePOWK069lKuuFSssaZ3C4edHtkZ8gCfWWtA 8dMsqeOIg9Trx7ZBCDOZGNAAnjYQmSb2eYOAti3PX3Ex7vI8ZhJCzsNNBEjPuBIQEAC/6NPW 6EfQ91ZNU7e/oKWK91kOoYGFTjfdOatp3RKANidHUMSTUcN7J2mxww80AQHKjr3Yu2InXwVX SotMMR4UrkQX7jqabqXV5G+88bj0Lkr3gi6qmVkUPgnNkIBe0gaoM523ujYKLreal2OQ3GoJ PS6hTRoSUM1BhwLCLIWqdX9AdT6FMlDXhCJ1ffA/F3f3nTN5oTvZ0aVF0SvQb7eIhGVFxrlb WS0+dpyulr9hGdU4kzoqmZX9T/r8WCwcfXipmmz3Zt8o2pYWPMq9Utby9IEgPwultaP06MHY nhda1jfzGB5ZKco/XEaXNvNYADtAD91dRtNGMwRHWMotIGiWwhEJ6vFc9bw1xcR88oYBs+7p gbFSpmMGYAPA66wdDKGj9+cLhkd0SXGht9AJyaRA5AWB85yNmqcXXLkzzh2chIpSEawRsw8B rQIZXc5QaAcBN2dzGN9UzqQArtWaTTjMrGesYhN+aVpMHNCmJuISQORhX5lkjeg54oplt6Zn QyIsOCH3MfG95ha0TgWwyFtdxOdY/UY2zv5wGivZ3WeS0TtQf/BcGre2y85rAohFziWOzTaS BKZKDaBFHwnGcJi61Pnjkz82hena8OmsnsBIucsz4N0wE+hVd6AbDYN8ZcFNIDyt7+oGD1+c PfqLz2df6qjXzq27BBUboklbGUObNwADBQ//V45Z51Q4fRl/6/+oY5q+FPbRLDPlUF2lV6mb hymkpqIzi1Aj/2FUKOyImGjbLAkuBQj3uMqy+BSSXyQLG3sg8pDDe8AJwXDpG2fQTyTzQm6l OnaMCzosvALk2EOPJryMkOCI52+hk67cSFA0HjgTbkAv4Mssd52y/5VZR28a+LW+mJIZDurI Y14UIe50G99xYxjuD1lNdTa/Yv6qFfEAqNdjEBKNuOEUQOlTLndOsvxOOPa1mRUk8Bqm9BUt LHk3GDb8bfDwdos1/h2QPEi+eI+O/bm8YX7qE7uZ13bRWBY+S4+cd+Cyj8ezKYAJo9B+0g4a RVhdhc3AtW44lvZo1h2iml9twMLfewKkGV3oG35CcF9mOd7n6vDad3teeNpYd/5qYhkopQrG k2oRBqxyvpSLrJepsyaIpfrt5NNaH7yTCtGXcxlGf2jzGdei6H4xQPjDcVq2Ra5GJohnb/ix uOc0pWciL80ohtpSspLlWoPiIowiKJu/D/Y0bQdatUOZcGadkywCZc/dg5hcAYNYchc8AwA4 2dp6w8SlIsm1yIGafWlNnfvqbRBglSTnxFuKqVggiz2zk+1wa/oP+B96lm7N4/3Aw6uy7lWC HvsHIcv4lxCWkFXkwsuWqzEKK6kxVpRDoEQPDj+Oy/ZJ5fYuMbkdHrlegwoQ64LrqdmiVVPC TwQYEQIADwIbDAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2Do+FAJ956xSz2XpDHql+Wg/2qv3b G10n8gCguORqNGMsVRxrlLs7/himep7MrCc= Message-ID: <1d56362d-2c8c-6cf2-86a3-8b082d5085c2@gmail.com> Date: Wed, 8 Jan 2020 10:03:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200108_100344_582002_89B0DA43 X-CRM114-Status: GOOD ( 20.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Song Liu , Vladimir Oltean , Alexander Lobakin , Yoshiki Komachi , open list , Eric Dumazet , Stanislav Fomichev , Matteo Croce , Petar Penkov , Jakub Sitnicki , Daniel Borkmann , Vivien Didelot , Woojung Huh , Hauke Mehrtens , Sean Wang , Claudiu Manoil , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , netdev , Paul Blakey , Microchip Linux Driver Support , Russell King , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/3/20 1:28 PM, Vladimir Oltean wrote: > On Fri, 3 Jan 2020 at 22:50, Florian Fainelli wrote: >> >> The call path is the following on TX (e.g.: when you run a DHCP client), > > Oh, it gets called on TX too, ok. > In that case, static proto_off information won't work for asymmetric > taggers such as ocelot which may have an independently configurable > prefix length on RX and TX. > I want to get rid of the RX tag prefix in ocelot though, but just saying. > >> I don't think your formula works for EDSA which has an EtherType, but > > Why doesn't it work with edsa? It would, my bad. > >> this would probably work for all tags we currently support except trailer. >> >> proto = (__be16 *)(skb->data)[overhead / 2 - 1]; >> > > I wasn't suggesting to do this exact calculation in flow_dissector.c, > but rather to pre-populate proto_off with a value statically derived > from it on a piece of paper, with the trailer exception where it would > be -2 in bytes or -1 in shorts, but nonetheless a negative and valid > value. With the trailer, the EtherType is actually at the expected location, that is 12 bytes from the beginning of the Ethernet frame, so we can simplify things even more. > >> >> I don't think anyone except Alexander did serious investigation this. >> For now, what I am interested in is reducing the amount of technical >> debt and expensive function calls. > > Does the change bring any measurable improvement? I did not implement flow dissection for Broadcom tags largely because it did not show up as a performance problem with the different customers but I will try to collect some numbers. At any rate, the patch is not meant to be a performance improvement (though it might provide some improvements) but ease maintenance and make it more straight forward for future protocols to automatically gain dissection without having to provide a function pointer. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel