From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A76C433F5 for ; Tue, 28 Sep 2021 16:29:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F36C61213 for ; Tue, 28 Sep 2021 16:29:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8F36C61213 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XfLg2n+Tk5F2CurrrJmY0AKvMTxq0khrp8ql/wsUghY=; b=hSZmtDg+wIotjw OztZWZFz2J43zPITWNIz/QT/WbMchH/kvxIVxC6RpyD40F0HiykZaeRspLRW/wqBKJGz6pGm/eY1X Y0p0Djsdz/N9RSkQ0bVL9s4by3Ut4XBB/XnRgrN+HypmnMbe3Vwm4Rhfn8tmYmriAuZfvIm2VoQfB sEq+B+OLa0f8hU7yl7QQmXNoz2ENsGzfTuh/e8Ur6nfk5oyclzbABkBVIbJmHRdAfDxEpV5m7PNud NxbjzsuQ144Gvf6mHZNxt9C4Fmv/lyUCx/+5v6y+AWfcarF8hQlEs+KsaLAAWHUQMatTOh6RAS1Nc RieXdPHN70TiFQ87iKlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVFwe-0083oK-2B; Tue, 28 Sep 2021 16:27:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVFwa-0083na-K8; Tue, 28 Sep 2021 16:27:01 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 41F496128A; Tue, 28 Sep 2021 16:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632846420; bh=RIHQE4aWfBPKHQOvToBrdjP5ETITfcqpfhUZw9uKGXE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=RiuunJAHbRyP+p8E2K8/OQa92Ep5G9dbIz4CLljlIES1IUUU4wGruLbYZGsr6Qetk 4rDYPwNQYzZ4D5Y1StkJnfxrfMEi+8rQI/QSvKtuBDfEinE7+ojY4AzDV6X+5bxq5e 7iMGyZLMll830V6bjTZ8OndhzZRQWplbrmAkgGtJO34VBL51BKdGZlRPbBy380Nxq3 ErVlQGGTPp+g/K+q9A4TmNg/gsVdHvneYuhE6uDZFNhg0uHxoPy5UdTcnFFITDxtcq 5GWd8HAHvpHh5800z961Ps5at+obTEh/IsvcjBA2hnkklv6qDpS22BNoRSzAnCfDCd dEtG/jGpSIIcA== Message-ID: <1d94747e74061f05395c34a4c441f96823dbf53a.camel@kernel.org> Subject: Re: [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers From: nicolas saenz julienne To: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Florian Fainelli , Michael Stapelberg , Linus Torvalds Date: Tue, 28 Sep 2021 18:26:55 +0200 In-Reply-To: <20210922125419.4125779-3-maxime@cerno.tech> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-3-maxime@cerno.tech> User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_092700_708986_68A27CC1 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote: > The driver, once it found a divider, tries to round it up by increasing > the least significant bit of the fractional part by one when the > round_up argument is set and there's a remainder. > > However, since it increases the divider it will actually reduce the > clock rate below what we were asking for, leading to issues with > clk_set_min_rate() that will complain that our rounded clock rate is > below the minimum of the rate. > > Since the dividers are fairly precise already, let's remove that part so > that we can have clk_set_min_rate() working. > > This is effectively a revert of 9c95b32ca093 ("clk: bcm2835: add a round > up ability to the clock divisor"). > > Fixes: 9c95b32ca093 ("clk: bcm2835: add a round up ability to the clock divisor") > Signed-off-by: Maxime Ripard > --- Reviewed-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne # boot and basic functionality Regards, Nicolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel