From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8093C77B72 for ; Thu, 20 Apr 2023 15:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E8dKV1WmJL84c+45KT/9cZqnfYFYYnGySb9eZYx1I7s=; b=O3uRDw5qeEyYHt 6NZENVnxHQfeDG5kOLxXgiDjG+tyf+patZlQeJYXY6OUcw0wCXorKeS7VnKtvfAJzvYOd3QxVIU/P 90CnSA/mgthgW5OBfZpiPOAQCHjwCKQFL662YztV6RaGk97xU4Fh5A45CP+nWsacanAnFL8fm0INW vEGkMXxqzsrN7YsWyAc25D01WfSYig0AAYeDxYYpoAmqhrg2cMGyZWEyC1KlRZdC056X0yyW2N2/Y GmSelFTfyo7YZyr8fij5Ty0qK3X8lhC9O9dDXQuI3UbSxnk2qAgjZFAOGQYkKYdSAkrhI933fIM8X tHy+I6gZiice9u9r88OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppWM9-008QZx-2P; Thu, 20 Apr 2023 15:37:57 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppWM5-008QYp-1M for linux-arm-kernel@lists.infradead.org; Thu, 20 Apr 2023 15:37:56 +0000 Received: by mail-ej1-x62d.google.com with SMTP id u3so7222548ejj.12 for ; Thu, 20 Apr 2023 08:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682005071; x=1684597071; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ApdTWhhkzb3N6QPss2Yi29YN1Urm38DCu4SfJzo1FQI=; b=OI42D9V5yNMUvJYFnh5KZP3SfORv1nitueVJtSxwirYdvprgf4mHQfP3mWi6vxh8p7 jc6n1kvmWxPVFwZUqRp9zkDTthsv49ZKHfZE/ajqeT7rNcDTJAWlG+uuomQ7XWcc9IEu 69qmu/jgVP6qiE5E3U94y9VwfIpZmJ60lzZY/OZVUS1Q356VSOoWf0b0gvlLb0willLI +AuwkAWPd6MndKUf7NdsTNatgvsFQTn65fKFAybNM+2k41KxAP4lQl0bC1wvVHpfgAXI ssT8Bo0cqfePRtiDhsfpi/7am7YKWYfLUrq9/stle7KV6a9R+vVpQxY+glFEPtTnfT0U Cbog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682005071; x=1684597071; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ApdTWhhkzb3N6QPss2Yi29YN1Urm38DCu4SfJzo1FQI=; b=LhnQEMIb/g1YUaWZ1X6izi8LnxzN1Su4/sW59sT+Nk67IzngewhJmLacQLOSNch2rF Y4Xqu9yxEyZ6IDicHa8NtkCDiKn1UzO46LnaYDCI/hHFjE7asQHUWldjeoj2w0mXhK3g PwsTA3ma0Y8kTxDEmUdCOiplnu8nzA2Jj6OfSQKWRoeqlSLd4aJOqZn7Ysq3cuj8hk8r PobQ0WB1gag5X+8phJ0Xpc3ZcqZBCkkqyQwdjW8Qmn2/4MoCUK75us7J3anVWXnjECkL IeHNP5sdYYceZDrTk82CjfkIyqJsZC+cr0GSEA4EGEvobBsiirH6Y9Km/7FFvA7Q1osQ 2Fdg== X-Gm-Message-State: AAQBX9e9lunglGYCUMKQ1hdfoa0DRREKqbRHG4pQOzj6npt3Mc25GnfS dKfMoDLA93i86yW1Om7hrszYEQ== X-Google-Smtp-Source: AKy350bolQ8RHPDEoxQ2ZB1HmmT5FLmSChLbyJX+YfSROWHK0HuITUZs/iOaI9q4WjxA9H8o4aXbrA== X-Received: by 2002:a17:906:a258:b0:947:4828:4399 with SMTP id bi24-20020a170906a25800b0094748284399mr1991837ejb.12.1682005070813; Thu, 20 Apr 2023 08:37:50 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:bcb8:77e6:8f45:4771? ([2a02:810d:15c0:828:bcb8:77e6:8f45:4771]) by smtp.gmail.com with ESMTPSA id g25-20020a170906349900b0095336e8e012sm865381ejb.176.2023.04.20.08.37.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 08:37:50 -0700 (PDT) Message-ID: <1da788fd-03df-1704-187e-0045876f2605@linaro.org> Date: Thu, 20 Apr 2023 17:37:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 4/4] spi: s3c64xx: support interrupt based pio mode Content-Language: en-US To: Jaewon Kim , Mark Brown , Andi Shyti , Alim Akhtar Cc: linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chanho Park References: <20230419060639.38853-1-jaewon02.kim@samsung.com> <20230419060639.38853-5-jaewon02.kim@samsung.com> <88e74f8f-feee-159a-3048-736a5ffc13cd@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230420_083754_984404_75400DBD X-CRM114-Status: GOOD ( 10.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/04/2023 11:45, Jaewon Kim wrote: >>> static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd, >>> - struct spi_transfer *xfer) >>> + struct spi_transfer *xfer, int use_irq) >>> { >>> void __iomem *regs = sdd->regs; >>> unsigned long val; >>> + unsigned long time; >>> u32 status; >>> int loops; >>> u32 cpy_len; >>> @@ -563,17 +568,24 @@ static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd, >>> int ms; >>> u32 tx_time; >>> >>> - /* sleep during signal transfer time */ >>> - status = readl(regs + S3C64XX_SPI_STATUS); >>> - if (RX_FIFO_LVL(status, sdd) < xfer->len) { >>> - tx_time = (xfer->len * 8 * 1000 * 1000) / sdd->cur_speed; >>> - usleep_range(tx_time / 2, tx_time); >>> - } >> You just added this code. Adding and immediately removing it, suggests >> this should be one patch. >> > This code has been moved, not removed. Move consists of remove and add. Add it in correct place since beginning. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel