From: <Codrin.Ciubotariu@microchip.com>
To: <mirq-linux@rere.qmqm.pl>, <alsa-devel@alsa-project.org>
Cc: alexandre.belloni@bootlin.com, lgirdwood@gmail.com,
tiwai@suse.com, Ludovic.Desroches@microchip.com,
broonie@kernel.org, perex@perex.cz,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] ASoC: atmel_ssc_dai: implement left-justified data mode
Date: Thu, 25 Jul 2019 13:15:36 +0000 [thread overview]
Message-ID: <1da85885-4b5c-fcfa-a7b7-d8ef8102debe@microchip.com> (raw)
In-Reply-To: <ca3d0b124cdf6e2d0ec158a7948f08dd8abfd3b7.1563819483.git.mirq-linux@rere.qmqm.pl>
On 22.07.2019 21:27, Michał Mirosław wrote:
> External E-Mail
>
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> sound/soc/atmel/atmel_ssc_dai.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
> index b2992496e52f..04541d7c33fe 100644
> --- a/sound/soc/atmel/atmel_ssc_dai.c
> +++ b/sound/soc/atmel/atmel_ssc_dai.c
> @@ -564,7 +564,20 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream,
>
> switch (ssc_p->daifmt & SND_SOC_DAIFMT_FORMAT_MASK) {
>
> + case SND_SOC_DAIFMT_LEFT_J:
> + /* left-justified format */
> + fs_osync = SSC_FSOS_POSITIVE;
> +
> + rcmr = SSC_BF(RCMR_STTDLY, 0)
> + | SSC_BF(RCMR_START, SSC_START_RISING_RF);
> +
> + tcmr = SSC_BF(TCMR_STTDLY, 0)
> + | SSC_BF(TCMR_START, SSC_START_RISING_RF);
> +
> + break;
> +
> case SND_SOC_DAIFMT_I2S:
> + /* I2S format = left-justified with start bit and inverted LRCLK */
> fs_osync = SSC_FSOS_NEGATIVE;
>
> rcmr = SSC_BF(RCMR_STTDLY, 1)
>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks and best regards,
Codrin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-25 13:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:27 [PATCH 0/5] ASoC: atmel: extend SSC support Michał Mirosław
2019-07-22 18:27 ` [PATCH 1/5] ASoC: atmel: enable SSC_PCM_DMA in Kconfig Michał Mirosław
2019-07-23 13:36 ` Codrin.Ciubotariu
2019-07-23 14:26 ` Codrin.Ciubotariu
2019-07-23 16:43 ` mirq-linux
2019-07-23 17:27 ` Codrin.Ciubotariu
2019-07-23 18:39 ` Alexandre Belloni
2019-07-23 23:25 ` mirq-linux
2019-07-25 15:25 ` Codrin.Ciubotariu
2019-08-23 15:09 ` Alexandre Belloni
2019-07-23 17:18 ` Mark Brown
2019-07-22 18:27 ` [PATCH 2/5] ASoC: atmel_ssc_dai: rework DAI format configuration Michał Mirosław
2019-07-24 10:35 ` Codrin.Ciubotariu
2019-07-24 11:15 ` mirq-linux
2019-07-24 12:54 ` Codrin.Ciubotariu
2019-07-22 18:27 ` [PATCH 3/5] ASoC: atmel_ssc_dai: implement left-justified data mode Michał Mirosław
2019-07-25 13:15 ` Codrin.Ciubotariu [this message]
2019-07-22 18:27 ` [PATCH 4/5] ASoC: atmel_ssc_dai: split TX/RX FS constants Michał Mirosław
2019-07-25 13:28 ` Codrin.Ciubotariu
2019-07-22 18:27 ` [PATCH 5/5] ASoC: atmel_ssc_dai: Enable shared FSYNC source in frame-slave mode Michał Mirosław
2019-07-25 15:02 ` Codrin.Ciubotariu
2019-07-25 18:24 ` mirq-linux
2019-07-26 10:33 ` Codrin.Ciubotariu
2019-07-26 12:08 ` mirq-linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1da85885-4b5c-fcfa-a7b7-d8ef8102debe@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).