From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86412C4338F for ; Wed, 11 Aug 2021 11:18:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C10460EB5 for ; Wed, 11 Aug 2021 11:18:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2C10460EB5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JBzKcxsEedrXIc8wAjDNM4bWvnRE0sNK3TXI3bbY9UY=; b=y4AcvmP9Z11DNY917X5Hg+d1q7 TXsLPi2HOU66q49ZNbg54k0UMtVt41UMwurTRTFB73c+uE8ePL+/8R7N9eVx8fprZ/elolpvCYv06 j9v68ElSG4UyXLBqVpAI7cHNKAL/qd5zqiK8L6Q5oTuY1oW9ZWKN/pmsVmggCtcIRuygdVpqfv0zi y0eSgcn81SS6LdfqYx3ioYT8wP1Q61HlSarK8rIV8568Dp4iPQ0tpyZbI4uGiiQnEaeUc2H0hNDMy MH1rHRZJEBo0V3pDno8ayO9uFBPo/keNdyNuJlU6FrE4lRUxXwwTr4gnko0OdbI6oQTaeNiH7lrYB Btq8CotA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDmDL-006kLk-9R; Wed, 11 Aug 2021 11:16:03 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDmDE-006kKB-44 for linux-arm-kernel@lists.infradead.org; Wed, 11 Aug 2021 11:15:57 +0000 Received: from fraeml744-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Gl6gD2vDFz6BCtW; Wed, 11 Aug 2021 19:15:20 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml744-chm.china.huawei.com (10.206.15.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 11 Aug 2021 13:15:52 +0200 Received: from [10.47.80.4] (10.47.80.4) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 11 Aug 2021 12:15:51 +0100 Subject: Re: [PATCH RFC 2/8] iommu/arm-smmu-v3: Add and use static helper function arm_smmu_cmdq_issue_cmd_with_sync() To: Will Deacon CC: "Leizhen (ThunderTown)" , Robin Murphy , iommu , linux-arm-kernel , linux-kernel References: <20210626110130.2416-1-thunder.leizhen@huawei.com> <20210626110130.2416-3-thunder.leizhen@huawei.com> <20210810182454.GB3296@willie-the-truck> <20210811100905.GB4426@willie-the-truck> <20210811103344.GA4736@willie-the-truck> From: John Garry Message-ID: <1dcf5fe0-6ae0-2df6-9d2a-bda6a4f885ac@huawei.com> Date: Wed, 11 Aug 2021 12:15:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20210811103344.GA4736@willie-the-truck> Content-Language: en-US X-Originating-IP: [10.47.80.4] X-ClientProxiedBy: lhreml712-chm.china.huawei.com (10.201.108.63) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210811_041556_402641_B1785A39 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >>>>>> >>>>>> Therefore, function arm_smmu_cmdq_issue_cmd_with_sync() is added to insert >>>>>> the 'cmd+sync' commands at a time. >>>>>> >>>>>> Signed-off-by: Zhen Lei >>>>>> --- >>>>>> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 33 +++++++++++++-------- >>>>>> 1 file changed, 21 insertions(+), 12 deletions(-) >>>>>> >>>>>> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c >>>>>> index 2433d3c29b49ff2..a5361153ca1d6a4 100644 >>>>>> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c >>>>>> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c >>>>>> @@ -858,11 +858,25 @@ static int arm_smmu_cmdq_issue_cmd(struct arm_smmu_device *smmu, >>>>>> return arm_smmu_cmdq_issue_cmdlist(smmu, cmd, 1, false); >>>>>> } >>>>>> -static int arm_smmu_cmdq_issue_sync(struct arm_smmu_device *smmu) >>>>>> +static int __maybe_unused arm_smmu_cmdq_issue_sync(struct arm_smmu_device *smmu) >>>>>> { >>>>>> return arm_smmu_cmdq_issue_cmdlist(smmu, NULL, 0, true); >>>>>> } >>>>>> +static int arm_smmu_cmdq_issue_cmd_with_sync(struct arm_smmu_device *smmu, >>>>>> + struct arm_smmu_cmdq_ent *ent) >>>>>> +{ >>>>>> + u64 cmd[CMDQ_ENT_DWORDS]; >>>>>> + >>>>>> + if (arm_smmu_cmdq_build_cmd(cmd, ent)) { >>>>>> + dev_warn(smmu->dev, "ignoring unknown CMDQ opcode 0x%x\n", >>>>>> + ent->opcode); >>>>>> + return -EINVAL; >> Are any of the errors returned from the "issue command" functions actually >> consumed? I couldn't see it on mainline code from a brief browse. > I don't think so. I don't think so either. > Can we actually propagate them? There does appear to be some places, here's one I found: arm_smmu_page_response() -> arm_smmu_cmdq_issue_cmd(), and arm_smmu_page_response is set to arm_smmu_ops.page_response, which returns an int Thanks, John _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel