From: Michal Simek <michal.simek@amd.com>
To: Li zeming <zeming@nfschina.com>, <sboyd@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<michal.simek@xilinx.com>, <mturquette@baylibre.com>
Subject: Re: [PATCH] zynq: clkc: Add kmalloc allocation flag
Date: Mon, 27 Feb 2023 15:38:00 +0100 [thread overview]
Message-ID: <1dcfd6e7-fd9d-d091-0eee-87fa71218396@amd.com> (raw)
In-Reply-To: <20230223183312.2759-1-zeming@nfschina.com>
Hi,
On 2/23/23 19:33, Li zeming wrote:
>
> hello senior:
> I observed that some other variable assignments in this function are basically judged by the if statement, while clk_name does not make an if branch statement, and I think clk_name is also relatively important, increasing __GFP_NOFAIL flag ensures that the assignment can succeed under any circumstances.
>
I think that solution with array on stack would be better choice.
It will be faster and you can completely skip the whole allocation code for it.
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-02-27 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 21:58 [PATCH] zynq: clkc: Add kmalloc allocation flag Li zeming
2023-02-21 22:50 ` Stephen Boyd
2023-02-23 18:33 ` Li zeming
2023-02-27 14:38 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dcfd6e7-fd9d-d091-0eee-87fa71218396@amd.com \
--to=michal.simek@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).