From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C2B7C4167B for ; Tue, 5 Dec 2023 02:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lBlhVK9yXw6z66XlcBkPFvDWpJkD5YjNB1fAjqINJow=; b=ukc/QvJ5oz2HEl yKrojk/ZXpGyeDtV5638GEb/8VpKOTvYipixQyZMkzROjZI07aMi+bt6Ho7fDSCp4xisfT1w+wj1j 482W6Ma24Zg3YZVgK0nBnkuEC00FqpEo41raJijyi96C7iHXfL3noL5fUdeg7KeUMtKVxkYuvxfBJ UsoP1ANDk/I4wU4ilYIaDwUO0bU+bnxnK3wI4TQUbaOoYHTQNOsIE0LSvuIUMbTt9Eoa6uD21P/iN 4LUw7gQzBOOTU+dd6emzYhgq1Qnd+znNweWvQSbwpQ8ebXKmkgYJSCHBltHPatSbQJEGU+mqmvqmy SCKarfsZFRxPuqa5FWww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAL8o-0062FU-2I; Tue, 05 Dec 2023 02:26:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAL8k-0062EZ-2u for linux-arm-kernel@lists.infradead.org; Tue, 05 Dec 2023 02:26:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D9641474; Mon, 4 Dec 2023 18:27:10 -0800 (PST) Received: from [10.163.35.139] (unknown [10.163.35.139]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 837FF3F5A1; Mon, 4 Dec 2023 18:26:19 -0800 (PST) Message-ID: <1df51909-1b2a-4a42-973d-af9bcdfb8e6e@arm.com> Date: Tue, 5 Dec 2023 07:56:16 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 03/41] arm64: mm: get rid of kimage_vaddr global variable Content-Language: en-US To: Mark Rutland Cc: Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Catalin Marinas , Will Deacon , Marc Zyngier , Ryan Roberts , Kees Cook References: <20231129111555.3594833-43-ardb@google.com> <20231129111555.3594833-46-ardb@google.com> <2fabeac2-a1c1-4e10-b7f5-33de8d502e4d@arm.com> From: Anshuman Khandual In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_182627_012267_934AAE06 X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/4/23 20:07, Mark Rutland wrote: > On Thu, Nov 30, 2023 at 11:08:59AM +0530, Anshuman Khandual wrote: >> >> >> On 11/29/23 16:45, Ard Biesheuvel wrote: >>> From: Ard Biesheuvel >>> >>> We store the address of _text in kimage_vaddr, but since commit >>> 09e3c22a86f6889d ("arm64: Use a variable to store non-global mappings >>> decision"), we no longer reference this variable from modules so we no >>> longer need to export it. >>> >>> In fact, we don't need it at all so let's just get rid of it. >>> >>> Acked-by: Mark Rutland >>> Signed-off-by: Ard Biesheuvel >> >> There is a checkpatch.pl error for this patch. >> >> -------- >> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - >> ie: 'commit 09e3c22a86f6 ("arm64: Use a variable to store non-global mappings decision")' >> #6: >> We store the address of _text in kimage_vaddr, but since commit >> -------- > > That looks like a spurious warning. Ard wrote: > > [...] commit 09e3c22a86f6889d ("arm64: Use a variable to store non-global > mappings decision"), [...] > > ... which is 'commit <16 chars of sha1> ("<title line>")', just as the > checkpatch message says. Although it does not make any difference TBH, sometimes moving 'commit' before the SHA string on the same line just removes the warning. That line break might be the trigger. > > Clearly, this checkpatch warning isn't helpful. > > Regardless of whether the warning is spurious, please use judgement for > checkpatch warnings. They're not always a hard rule to be followed. > > Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel