From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1DC4C388F7 for ; Tue, 10 Nov 2020 09:34:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3939C20780 for ; Tue, 10 Nov 2020 09:34:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K1wmeR3R"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="16Q3RE3v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3939C20780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t1Lm0eLp2hew3Ot7Y+rOavDvzIPCfHbLk4s5lEszX9w=; b=K1wmeR3RsbhZyA1OigzBUG2Cv k/+1AKGF6Dlgp7UeSIamt2VSmz/MlTtVMaX6kBHXsHs/vVfyFaLOd32G/Fm3XQK5Luks7pPOHLyKj qGRDW8gFHWCCQ/JtL3I+s4xQy88kW2+4/4tHQuG+yRC3rH/25kh7Iwg4xMbEx4mzeXNAHbWDdR+rq WuEu7Dh/IRyECP6tNUxVSSF+3PzOcyahlVj1DGofs2kFX/zUpKWOXr5AGhogsMOd2Wj/kIKZsP+n+ OrNW2jl5j19ngpwVJmHTAANuAoT1WdPDLNzehfHu12TwdmkSBmA/OZHyZ+9mc9eK9XlM78PD3M3cc sZUjAkXnw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcQ1r-0004e1-HD; Tue, 10 Nov 2020 09:33:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcQ1o-0004cl-17 for linux-arm-kernel@lists.infradead.org; Tue, 10 Nov 2020 09:33:29 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2762C20780; Tue, 10 Nov 2020 09:33:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605000807; bh=uEKTfHixYeT5Tb8Ezc5HUHIdMDI5g+hUoBiizVerKYI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=16Q3RE3v0hUqz5GUBORBmyBzTvExolpPPZ71vWgfjUxvo9a01hpTi0ftSpcwvJ93f 1wbzK113f1ZKz22A90Fj3XA3w3Kg86/T+j3aqrbq3VP3QLzw80vothuBr+qf25wi3q cZj2i7dTyowQW955IgqTmg7soHhoYOtOKAFs0pmY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kcQ1l-009Oxm-5T; Tue, 10 Nov 2020 09:33:25 +0000 MIME-Version: 1.0 Date: Tue, 10 Nov 2020 09:33:25 +0000 From: Marc Zyngier To: Will Deacon Subject: Re: [PATCH v2 3/6] KVM: arm64: Kill 32-bit vCPUs on systems with mismatched EL0 support In-Reply-To: <20201109213023.15092-4-will@kernel.org> References: <20201109213023.15092-1-will@kernel.org> <20201109213023.15092-4-will@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <1df601250710b1fdef1e9089c33c5850@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, catalin.marinas@arm.com, gregkh@linuxfoundation.org, peterz@infradead.org, morten.rasmussen@arm.com, qais.yousef@arm.com, surenb@google.com, qperret@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201110_043328_163839_EDAC2F06 X-CRM114-Status: GOOD ( 20.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, kernel-team@android.com, Quentin Perret , Peter Zijlstra , Catalin Marinas , Qais Yousef , Greg Kroah-Hartman , Suren Baghdasaryan , Morten Rasmussen , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-11-09 21:30, Will Deacon wrote: > If a vCPU tries to run 32-bit code on a system with mismatched support nit: s/tries to run/is caught running/ > at EL0, then we should kill it. > > Signed-off-by: Will Deacon > --- > arch/arm64/kvm/arm.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 5750ec34960e..d322ac0f4a8e 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -633,6 +633,15 @@ static void check_vcpu_requests(struct kvm_vcpu > *vcpu) > } > } > > +static bool vcpu_mode_is_bad_32bit(struct kvm_vcpu *vcpu) > +{ > + if (likely(!vcpu_mode_is_32bit(vcpu))) > + return false; > + > + return !system_supports_32bit_el0() || > + static_branch_unlikely(&arm64_mismatched_32bit_el0); > +} > + > /** > * kvm_arch_vcpu_ioctl_run - the main VCPU run function to execute > guest code > * @vcpu: The VCPU pointer > @@ -816,7 +825,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu) > * with the asymmetric AArch32 case), return to userspace with > * a fatal error. > */ > - if (!system_supports_32bit_el0() && vcpu_mode_is_32bit(vcpu)) { > + if (vcpu_mode_is_bad_32bit(vcpu)) { > /* > * As we have caught the guest red-handed, decide that > * it isn't fit for purpose anymore by making the vcpu Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel