From: "Sven Peter" <sven@svenpeter.dev>
To: "Min-Hua Chen" <minhuadotchen@gmail.com>,
"Hector Martin" <marcan@marcan.st>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Philipp Zabel" <p.zabel@pengutronix.de>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static
Date: Thu, 20 Jul 2023 20:55:34 +0200 [thread overview]
Message-ID: <1e16e400-0dbb-4ba1-a0a5-2380b50fa60a@app.fastmail.com> (raw)
In-Reply-To: <20230719223848.138363-1-minhuadotchen@gmail.com>
On Thu, Jul 20, 2023, at 00:38, Min-Hua Chen wrote:
> This patch fixes the following sparse warnings:
>
> drivers/soc/apple/apple-pmgr-pwrstate.c:180:32: sparse: warning: symbol
> 'apple_pmgr_reset_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> ---
Acked-by: Sven Peter <sven@svenpeter.dev>
Thanks,
Sven
> drivers/soc/apple/apple-pmgr-pwrstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c
> b/drivers/soc/apple/apple-pmgr-pwrstate.c
> index d62a776c89a1..9467235110f4 100644
> --- a/drivers/soc/apple/apple-pmgr-pwrstate.c
> +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c
> @@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct
> reset_controller_dev *rcdev, unsigned
> return !!(reg & APPLE_PMGR_RESET);
> }
>
> -const struct reset_control_ops apple_pmgr_reset_ops = {
> +static const struct reset_control_ops apple_pmgr_reset_ops = {
> .assert = apple_pmgr_reset_assert,
> .deassert = apple_pmgr_reset_deassert,
> .reset = apple_pmgr_reset_reset,
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-07-20 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 22:38 [PATCH] soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static Min-Hua Chen
2023-07-20 18:55 ` Sven Peter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e16e400-0dbb-4ba1-a0a5-2380b50fa60a@app.fastmail.com \
--to=sven@svenpeter.dev \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=minhuadotchen@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).