* [PATCH] soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static
@ 2023-07-19 22:38 Min-Hua Chen
2023-07-20 18:55 ` Sven Peter
0 siblings, 1 reply; 2+ messages in thread
From: Min-Hua Chen @ 2023-07-19 22:38 UTC (permalink / raw)
To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Philipp Zabel
Cc: Min-Hua Chen, asahi, linux-arm-kernel, linux-kernel
This patch fixes the following sparse warnings:
drivers/soc/apple/apple-pmgr-pwrstate.c:180:32: sparse: warning: symbol 'apple_pmgr_reset_ops' was not declared. Should it be static?
No functional change intended.
Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
---
drivers/soc/apple/apple-pmgr-pwrstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c b/drivers/soc/apple/apple-pmgr-pwrstate.c
index d62a776c89a1..9467235110f4 100644
--- a/drivers/soc/apple/apple-pmgr-pwrstate.c
+++ b/drivers/soc/apple/apple-pmgr-pwrstate.c
@@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct reset_controller_dev *rcdev, unsigned
return !!(reg & APPLE_PMGR_RESET);
}
-const struct reset_control_ops apple_pmgr_reset_ops = {
+static const struct reset_control_ops apple_pmgr_reset_ops = {
.assert = apple_pmgr_reset_assert,
.deassert = apple_pmgr_reset_deassert,
.reset = apple_pmgr_reset_reset,
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static
2023-07-19 22:38 [PATCH] soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static Min-Hua Chen
@ 2023-07-20 18:55 ` Sven Peter
0 siblings, 0 replies; 2+ messages in thread
From: Sven Peter @ 2023-07-20 18:55 UTC (permalink / raw)
To: Min-Hua Chen, Hector Martin, Alyssa Rosenzweig, Philipp Zabel
Cc: asahi, linux-arm-kernel, linux-kernel
On Thu, Jul 20, 2023, at 00:38, Min-Hua Chen wrote:
> This patch fixes the following sparse warnings:
>
> drivers/soc/apple/apple-pmgr-pwrstate.c:180:32: sparse: warning: symbol
> 'apple_pmgr_reset_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> ---
Acked-by: Sven Peter <sven@svenpeter.dev>
Thanks,
Sven
> drivers/soc/apple/apple-pmgr-pwrstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c
> b/drivers/soc/apple/apple-pmgr-pwrstate.c
> index d62a776c89a1..9467235110f4 100644
> --- a/drivers/soc/apple/apple-pmgr-pwrstate.c
> +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c
> @@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct
> reset_controller_dev *rcdev, unsigned
> return !!(reg & APPLE_PMGR_RESET);
> }
>
> -const struct reset_control_ops apple_pmgr_reset_ops = {
> +static const struct reset_control_ops apple_pmgr_reset_ops = {
> .assert = apple_pmgr_reset_assert,
> .deassert = apple_pmgr_reset_deassert,
> .reset = apple_pmgr_reset_reset,
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-20 18:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-19 22:38 [PATCH] soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static Min-Hua Chen
2023-07-20 18:55 ` Sven Peter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).