From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BD2DEB64DA for ; Thu, 20 Jul 2023 18:56:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jsxsiPnolT0UiEd+N4/+MCadp4s/R/UhdAxBIaVFUIo=; b=ye5TURH4YLWMfT 31HqJF6DihDcjpLVbgRhybCr7QLPLMIx699b2XAKASzO5g/v7L1xYDiGrIX0W1sJQMK60mpn40N+N ZRt1SproES4PN98+1UOw6yeEx0GsdW2KyezrCs/pLst9pnL8GWxdVnN53q9QG652H02zhqxmsOVDf juBRZ62KDWgA1Y2rrSvdwX0QiA1SdoGoIWsdpg2nOT4U2p3ldE9dCCdPVNNSxsiTwQk7GchL+XqRE rsJY/HzhViMFazTUZu1ujygrSNKfippKOuQFL8xJuez5oB3Ziv96yqdFJU1Si2JcAS14suA2fPX23 fUGv7HK11znMmw3g0haw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMYoh-00By5o-17; Thu, 20 Jul 2023 18:55:59 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMYof-00By5D-27 for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 18:55:58 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 893063200124; Thu, 20 Jul 2023 14:55:56 -0400 (EDT) Received: from imap47 ([10.202.2.97]) by compute5.internal (MEProxy); Thu, 20 Jul 2023 14:55:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1689879356; x= 1689965756; bh=VlXcKq8r5CvDv0CQjr1ifJgqgPG6o4lzBf7CAsOaYZM=; b=Z 9dpjKXFJx6E45rGhQTEV52gxvEbjHOelVthAwRJS6cG8c6GxcCx//r0a3GUSoHkX yUqFaRRQS5dB8URGVRxLIXnel2gk2wqziQqQxDo6HPQ8Q3RXE2BxySHNO232FIuM xtuHcPRuHzr6c1zkLDANxy7BBf5EdepwPtYuWnDdufESlLxbqykO3lLbrh25KgPJ 12j6mpjWOWbW9rhuayi20DR3wwdgsaRtcVIGSHqUzfyk8qVnQHI9Dc+uiXdJZt+5 wbMVlvUjJiGaMBBgXnNk+FkHVFLY5d8/9opd6DjF7QZb80Em+dYw3t8/OnQK9cU1 gnN1l8FLjEXiKm1SQaVVw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1689879356; x=1689965756; bh=VlXcKq8r5CvDv 0CQjr1ifJgqgPG6o4lzBf7CAsOaYZM=; b=MR+lC1CyfZRZhHHseDJBYoY1Nowk+ rXvJx/agWc6q5w2QrSUUbh+EaZf6+V9ZJE/4SZWH1eKQXU80CeEgJr5QbX7hshww a2UDx4PUy0oY5QGMUBvQskEhOUy9CkwPXFr5kEvLxtdsfBMbaCZfpDuxakvIX3pS 3hmhUkFCIYS3rzujR/Z29cZYoenR5IMHNcWenOnijNdtSoEtOH8DC2vO7DLc0B5k gLL/8/UTdvsq3L1UYqD6jXId4D6CqEoDUt8unX/eAcAZXeGmWPijTUjOUJlU7fT5 PRMqllQ+ICabl2km7yJzEvUHEsuy0AWnZtfzCQOQWUPQ0Jls5gprQXrQw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrhedtgdduvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedfufhv vghnucfrvghtvghrfdcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrf grthhtvghrnhepleevgfegffehvedtieevhfekheeftedtjeetudevieehveevieelgffh ieevieeunecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epshhvvghnsehsvhgvnhhpvghtvghrrdguvghv X-ME-Proxy: Feedback-ID: i51094778:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id A139CA60077; Thu, 20 Jul 2023 14:55:55 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0 Mime-Version: 1.0 Message-Id: <1e16e400-0dbb-4ba1-a0a5-2380b50fa60a@app.fastmail.com> In-Reply-To: <20230719223848.138363-1-minhuadotchen@gmail.com> References: <20230719223848.138363-1-minhuadotchen@gmail.com> Date: Thu, 20 Jul 2023 20:55:34 +0200 From: "Sven Peter" To: "Min-Hua Chen" , "Hector Martin" , "Alyssa Rosenzweig" , "Philipp Zabel" Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_115557_751809_F6287329 X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 20, 2023, at 00:38, Min-Hua Chen wrote: > This patch fixes the following sparse warnings: > > drivers/soc/apple/apple-pmgr-pwrstate.c:180:32: sparse: warning: symbol > 'apple_pmgr_reset_ops' was not declared. Should it be static? > > No functional change intended. > > Signed-off-by: Min-Hua Chen > --- Acked-by: Sven Peter Thanks, Sven > drivers/soc/apple/apple-pmgr-pwrstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c > b/drivers/soc/apple/apple-pmgr-pwrstate.c > index d62a776c89a1..9467235110f4 100644 > --- a/drivers/soc/apple/apple-pmgr-pwrstate.c > +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c > @@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct > reset_controller_dev *rcdev, unsigned > return !!(reg & APPLE_PMGR_RESET); > } > > -const struct reset_control_ops apple_pmgr_reset_ops = { > +static const struct reset_control_ops apple_pmgr_reset_ops = { > .assert = apple_pmgr_reset_assert, > .deassert = apple_pmgr_reset_deassert, > .reset = apple_pmgr_reset_reset, > -- > 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel