From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F40BAEB64D9 for ; Wed, 12 Jul 2023 05:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ORFIfdm7WymXY7Ebb5i/rJ/vxDM9iQutUeA1fjvOo6o=; b=d//B85cV6NLYa5 IrsjyAwJefmuyHlEirLFPW9JquUsFdcQX6cnIhpsDgtPjtczClGprERWl3pVMpybs/PGhdiRiGXGY rzwXolbCaJoYD43ZHFPCH0lwLN6rAKYfmcfM8QQ9VzXoVs6tWKakfdiooIx0rp5FhSEIF5byEmLcj hfWEvauePgFE7Cywq8MV3D6dfQPrkAns+wQZAgeck9TNCt4yUVc5juzAN83mK9QUGF4ZFr7H0NfnS lxinnjzZiUapx0EsZsbAHwcCHLbDzEy75uQTHSzFNZ0CR6phctKXJxwk/Y41QTR/6Rvrzj+paNKW1 2G96FFBAVtC6Pp39Sk8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJSek-00Gba9-1M; Wed, 12 Jul 2023 05:44:54 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJSeh-00GbZk-1s for linux-arm-kernel@lists.infradead.org; Wed, 12 Jul 2023 05:44:53 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-992af8b3b1bso833901866b.1 for ; Tue, 11 Jul 2023 22:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689140689; x=1691732689; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5ouZomYFgUHpn/YJmr1JiZF0xkGrMDaTDJYudY8dp4M=; b=bvDjgm22UvS4P5aJYtI62PvGyl3FefCo0qkEKllhFf6M4CdzUxiqL695Nir4SdFfbA 6SVBVj/eKAYHpyeS+YzXy5d2+6wdeUN2HfM0alKa1+Ggbe8pJx+7Je8YdnbsCJNCggzc X+YLurn9JM15dKsZPa4E4n8vwzdp0I5+wPblHPV4SDls9D6ReHgldmd1LwUos56CRwtw hACkG0wvBKCbvcB4u3C9DPZltjjbiEVUG0x3tR993eJtZuA6/xumm9ZkQ7O0UsLsk6nP Lg9DFChGsxhJ76cau5ShQDg67+lo5aUm3dQnT4kdXC2koBJS9kqb5MgYSm1aebGRfgqi sw3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689140689; x=1691732689; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5ouZomYFgUHpn/YJmr1JiZF0xkGrMDaTDJYudY8dp4M=; b=CQQoy0s+xalHuB8qjbbIhwVN6ymqtRENI+AkDW3RvQqE0PdiOPP34tAJB2dl/YD6KS c+0jh6QtgAeeyzgpq55DwppXePQmup6G2tyhQGqR4TDR19yiimpI7jN/JgcuDel7WMR5 jFkPlVdFkk56KL9LsdMvfSehFOgJMA7OQjUwZFq062GCn1SfLLfF7udhemEHwpwbcyKw DfYvIfnChENTaoKWd/hP3trsu2Hk+sapQYO0uJ1qOwOAfsl8APGtoBIZv5VUzWmd88Jy tQXBA3K/zhJunQK1QPiZWYOySz2aAlEoJfNjD/UZbfJbYf6RZBLxk0wq3urY+jFBrKCI LRzQ== X-Gm-Message-State: ABy/qLaBtcjA6Z9/fd4IRboOt2QUfFTc+0mgVvI3tfOAAGmN0XgAKwuR WakOgcbU8Gio/bJFlSODBi7GSg== X-Google-Smtp-Source: APBJJlHpKjhGOrY5gOYh/iHBm8gwLfa++FYIuS61a3m8tRrnYlnMMtS51wSD8v3uSldBMX6yMpTdog== X-Received: by 2002:a17:907:c8f:b0:98d:b73b:b5f2 with SMTP id gi15-20020a1709070c8f00b0098db73bb5f2mr17159701ejc.71.1689140689368; Tue, 11 Jul 2023 22:44:49 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id d20-20020a170906371400b0098e2eaec395sm2049867ejc.130.2023.07.11.22.44.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 22:44:48 -0700 (PDT) Message-ID: <1e3b4fa4-6de7-e7bb-f1f7-266a73d87fb0@linaro.org> Date: Wed, 12 Jul 2023 07:44:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 1/5] arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane mux Content-Language: en-US To: Nishanth Menon , Jayesh Choudhary Cc: vigneshr@ti.com, krzysztof.kozlowski+dt@linaro.org, afd@ti.com, s-vadapalli@ti.com, kristo@kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230710101705.154119-1-j-choudhary@ti.com> <20230710101705.154119-2-j-choudhary@ti.com> <23833669-b9f7-94aa-ea42-56843842cba6@linaro.org> <20230711153144.jvofubaez5uoog5p@unmanaged> From: Krzysztof Kozlowski In-Reply-To: <20230711153144.jvofubaez5uoog5p@unmanaged> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230711_224451_622274_E8AD8F67 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/07/2023 17:31, Nishanth Menon wrote: > On 12:01-20230711, Jayesh Choudhary wrote: >> >> >> On 10/07/23 17:13, Krzysztof Kozlowski wrote: >>> On 10/07/2023 12:17, Jayesh Choudhary wrote: >>>> From: Siddharth Vadapalli >>>> >>>> The system controller node manages the CTRL_MMR0 region. >>>> Add serdes_ln_ctrl node which is used for controlling the SERDES lane mux. >>>> >>>> Signed-off-by: Siddharth Vadapalli >>>> [j-choudhary@ti.com: Add reg property to fix dtc warning] >>>> Signed-off-by: Jayesh Choudhary >>>> --- >>>> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 23 ++++++++++++++++++++++ >>>> 1 file changed, 23 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >>>> index 2ea0adae6832..68cc2fa053e7 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >>>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >>>> @@ -5,6 +5,9 @@ >>>> * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/ >>>> */ >>>> +#include >>>> +#include >>> >>> Why? What do you use from that binding? >>> >> >> Missed idle-state in the mux-controller node here for default values. >> I will wait for more feedback and then re-spin the series. > > btw, I am wondering if ti-serdes.h should even exist in dt-bindings - > are any of the macros used in the driver? or should this follow the > pinctrl style macros that could happily reside in arch/arm64/boot/dts/ti > ? I don't see any usage in drivers, which is a clear indication that it might not be suitable for bindings. What are these values? Look like some register values, which there is little sense in making a binding. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel