From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FFE9C3A59E for ; Tue, 20 Aug 2019 21:38:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33A1D2332A for ; Tue, 20 Aug 2019 21:38:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mvwqCblX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YSKysIzi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33A1D2332A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tJbrvKMlvoQWNlOWabg2U7j96+d91KoOZgQZwSN0k9E=; b=mvwqCblXcPsx8D RnB2PkRQSJUsS4ZVDdWJEwNldjvDK1Cje2bUwF9R0cLFN7f+XR0Ps1izFC2GVS0PnsvaVMhqKmhCp kY8TDVLCko8nxdN2MhEIb2VbKA7x/bunJNg5D8sv4inJLgN5a2quhZoO3xhDPEuqC6eXfT5kkcCG7 LJ3XbIlANH27Q+XkSNUEmD7hNe83Zf1DlZo1RzKjxdc+l0GGFcvDCc9SG9tFopIyYFsvfF/6NeqF6 +gnxmL7TwxGNKHOJDf2u6fjZzr3rKfgdy3Yw3SR/x+WXo5/TjtOQxQ1+6lFsIbXajd0hTIzv7r88w AJbPnNb3PEXM2woZiPPQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0BpU-0001HN-TX; Tue, 20 Aug 2019 21:38:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0BpS-0001H2-L6 for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2019 21:38:11 +0000 Received: from [192.168.0.26] (89-70-52-201.dynamic.chello.pl [89.70.52.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC0BF22D6D; Tue, 20 Aug 2019 21:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566337089; bh=gLlIXUezQ3H0zuhcdhL9pLDm+sYyFfXAb5ejydPRRmo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=YSKysIziONSdYqDaBp1ouXGTLLHWaQibOh262t4q8PqwcS1xHNYPe/dQwWYeTWl6A mVEskQ4pZhKpl0mK5B/28GUIIVpvfdjEH60nAHGv3fSCz434vvwZyCNxJDnDUxhTja /1OxRfvJm9udJI/sh3ViWVKapHq8bT4gSwBQ+bvE= Subject: Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API To: Krzysztof Kozlowski References: <20190813150827.31972-1-s.nawrocki@samsung.com> <20190813150827.31972-3-s.nawrocki@samsung.com> From: Sylwester Nawrocki Message-ID: <1e428c8e-f4b5-0810-77f9-2c899c040fc7@kernel.org> Date: Tue, 20 Aug 2019 23:38:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190820_143810_736496_389B9295 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , Arnd Bergmann , linux-pm@vger.kernel.org, vireshk@kernel.org, =?UTF-8?Q?Bart=c5=82omiej_=c5=bbo=c5=82nierkiewicz?= , "linux-kernel@vger.kernel.org" , Jon Hunter , robh+dt@kernel.org, kgene@kernel.org, Sylwester Nawrocki , pankaj.dubey@samsung.com, linux-tegra , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/20/19 21:37, Krzysztof Kozlowski wrote: >>> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c >>> @@ -51,29 +48,24 @@ static const char * __init product_id_to_soc_id(unsigned int product_id) >>> int __init exynos_chipid_early_init(void) >>> { >>> struct soc_device_attribute *soc_dev_attr; >>> - void __iomem *exynos_chipid_base; >>> struct soc_device *soc_dev; >>> struct device_node *root; >>> - struct device_node *np; >>> + struct regmap *regmap; >>> u32 product_id; >>> u32 revision; >>> + int ret; >>> >>> - /* look up for chipid node */ >>> - np = of_find_compatible_node(NULL, NULL, "samsung,exynos4210-chipid"); >>> - if (!np) >>> - return -ENODEV; >>> - >>> - exynos_chipid_base = of_iomap(np, 0); >>> - of_node_put(np); >>> - >>> - if (!exynos_chipid_base) { >>> - pr_err("Failed to map SoC chipid\n"); >>> - return -ENXIO; >>> + regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); >>> + if (IS_ERR(regmap)) { >>> + pr_err("Failed to get CHIPID regmap\n"); >>> + return PTR_ERR(regmap); >>> } >> Following this change, I am now seeing the above error on our Tegra >> boards where this driver is enabled. This is triggering a kernel >> warnings test we have to fail. Hence, I don't think that you can remove >> the compatible node test here, unless you have a better way to determine >> if this is a samsung device. > > Right, this is really wrong... I missed that it is not a probe but > early init. And this init will be called on every board... Probably it > should be converted to a regular driver. I'm also inclined to have it converted to a regular driver. We already have "exynos-asv" driver matching on the chipid node (patch 3/9). The ASV patches will not be merged soon anyway, all this needs some more thought. Krzysztof, can we abandon the chipid patches for now? Your pull request doesn't appear to be merged to arm-soc yet. Sorry about that. -- Regards, Sylwester _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel