From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@osg.samsung.com (Javier Martinez Canillas) Date: Fri, 16 Sep 2016 14:09:15 -0400 Subject: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board In-Reply-To: <20160916172110.GA7511@kozik-lap> References: <1473285535-21996-1-git-send-email-ayaka@soulik.info> <1473285535-21996-3-git-send-email-ayaka@soulik.info> <6bd9905d-0818-a917-8b8e-6abce134a3d3@kernel.org> <865b9f84-385f-fea8-2e3d-2b31e3bfe84c@soulik.info> <20160916172110.GA7511@kozik-lap> Message-ID: <1e4335db-9004-bb7c-6dc1-e435e66b8126@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Randy, On 09/16/2016 01:21 PM, Krzysztof Kozlowski wrote: [snip] >>>> + >>>> + beep { >>>> + compatible = "pwm-beeper"; >>>> + pwms = <&pwm 0 4000000 PWM_POLARITY_INVERTED>; >>> I have serious doubts that you run this code... if it does not even >>> compile. Sorry, I cannot accept code that does not compile and was not >>> tested. >>> >>> Please, test your DTS on top of current Linux tree, which would be one of: >>> 1. Linus' master branch: v4.8-rc6, >>> 2. one of my branches (for-next, next/dt etc), >> When I sent those patches, I tested in "Add linux-next specific files for >> 20160907" > > OK, good, but please tell me why kbuild reported that build error? > I agree with Krzysztof, it doesn't seem that you tested the exact version that was posted. You will need the following change to make the DTS build in latest linux-next: diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts index dd83689892ff..8559f891a740 100644 --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts @@ -14,6 +14,7 @@ */ /dts-v1/; +#include #include #include "exynos4412-itop-scp-core.dtsi" So please squash that change and resend. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America