From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D66C433E0 for ; Fri, 5 Mar 2021 10:37:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD14D64FD2 for ; Fri, 5 Mar 2021 10:37:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD14D64FD2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cylw/tvsPAH9/aXK8LfkZ9ObasQ6CzimZ0byd7SCbHE=; b=ZEkknN4yvX7hWnJo2gsohYmRU Gg0DN78ohnWbmmiOfTrTCgGLSPiR+oQsmXoskUmr/2AyTg5paYzOKTsdx5z90Xyq7t6DxkSKvFGzW vbmBeRe66Tc3V1yKH8r/4MmvHDJ1ASJCPSWk3vqsBIvfkPkVO4S7QcxiWKvrILjHZU6rdMFvW7r+S wpH5nWTsHVZrWaoZ+jYD0bClI4n4H45xXx1aW1MPafG7TIbnQgXidOLAbt+eEkLqDKfbkkvO+s4Bh D2Lft+Y5UiuMUXGHaZ6vNFOQPjX/n537RrQDJGJBTAkycBkcFL+yToCrjXhhjcTo9y9ZooUFDMGU/ o+7OjY1Yw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI7nr-00Eabt-OU; Fri, 05 Mar 2021 10:35:28 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI7n6-00EaPq-Cs for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:34:42 +0000 Received: from mail-ed1-f71.google.com ([209.85.208.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI7n5-0007Zu-Qu for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:34:40 +0000 Received: by mail-ed1-f71.google.com with SMTP id cq11so718815edb.14 for ; Fri, 05 Mar 2021 02:34:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RWwbwcqn7+V68bGLU4ZDn1q+MKGqnLhOEC9uAVuE8zc=; b=eXcfUIZFitJ7Lz6jNCf62r01TiG6yBAwA+frJydO0bm8Z2hyAJ6vVdarO37YgQImSx R8UXZUnds4HVGy/Ew4tbsUX7TZ+/VqShQ2rGuhisKT5+b1yp757pX7PbQAhADM01Rq8K /dUIPfAICWW5MqQLqY2hKsnXXM6ztSNvUEMqkdpVeDutYkL3ply0qzWy0tmh1mX/SBLA pkpWDnVtEsqHvffb5TjeL3r4haFGWJ8COI47jMebiCXyVqJ1NL9kanJPlMH1jMGffngH 0HxpNQLCsTIadvKo+Ct+Y563dS5GYlB2C9GhCE0RCoNjoU59t+W7AzXGpQh6UUhud07w ytNA== X-Gm-Message-State: AOAM533L2FbC2g32/27KIgGjtOFblZdlAvtwOF8NW5s527n5sQYJrCrr Wj4fVos7A+6POlsr9GCiQhMa9RxECaQOj5JF2eH/SipLb75t0ecSpzKp1QI9c2iA+EFCtQJ0CZ4 CGnTb9Csp8Lt3yaZ/mL9JQegj08qO97rCyfbDp3QJJ8V5ER6CV0iG X-Received: by 2002:adf:fe01:: with SMTP id n1mr8647739wrr.341.1614940478802; Fri, 05 Mar 2021 02:34:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJxL/xW+AO3OBrJBdGRjyMx7XXgn/DcEVAjw6nrX4rZjq/i98eqo/Tr07xkBjjsbwJ/68iC9lg== X-Received: by 2002:adf:fe01:: with SMTP id n1mr8647714wrr.341.1614940478678; Fri, 05 Mar 2021 02:34:38 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id p6sm3759537wru.2.2021.03.05.02.34.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 02:34:38 -0800 (PST) Subject: Re: [RFT PATCH v3 19/27] tty: serial: samsung_tty: Add ucon_mask parameter To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-20-marcan@marcan.st> From: Krzysztof Kozlowski Message-ID: <1e665346-15eb-3a9f-6dc3-7494a8050972@canonical.com> Date: Fri, 5 Mar 2021 11:34:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210304213902.83903-20-marcan@marcan.st> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_103440_705741_A2CE2495 X-CRM114-Status: GOOD ( 21.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/03/2021 22:38, Hector Martin wrote: > This simplifies the code by removing the only distinction between the > S3C2410 and S3C2440 codepaths. > > Signed-off-by: Hector Martin > --- > drivers/tty/serial/samsung_tty.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 78dc6e9240fb..33b421dbeb83 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -70,6 +70,7 @@ struct s3c24xx_uart_info { > unsigned long num_clks; > unsigned long clksel_mask; > unsigned long clksel_shift; > + unsigned long ucon_mask; > > /* uart port features */ > > @@ -1736,14 +1737,9 @@ static void s3c24xx_serial_resetport(struct uart_port *port, > { > struct s3c24xx_uart_info *info = s3c24xx_port_to_info(port); > unsigned long ucon = rd_regl(port, S3C2410_UCON); > - unsigned int ucon_mask; > > - ucon_mask = info->clksel_mask; > - if (info->type == PORT_S3C2440) > - ucon_mask |= S3C2440_UCON0_DIVMASK; > - > - ucon &= ucon_mask; > - wr_regl(port, S3C2410_UCON, ucon | cfg->ucon); > + ucon &= (info->clksel_mask | info->ucon_mask); > + wr_regl(port, S3C2410_UCON, ucon | cfg->ucon); This line (wr_regl()) is not related, please split it to separate white-space cleanups. With the change: Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel