From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FAFBEEE266 for ; Thu, 12 Sep 2024 21:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dCFCtYRF0r0oUa2Y3h+lyp5YSyFCuvNcC5gH+noZfs8=; b=DReDofiSqXBBdxngWV2My5Q9EX UZ3/R7Ubt3s4lb06VYyHAK+A0wnKGAt0HwDFVG2eATXD/Skw/BVzOBnetbfcw0W+WQZ/KDO6EJQlD OVgxTPCUtzHDEyUN0RPtMndSkCYI/XwnQNNkEYNZCaiy22NRIMoxnbqpEq+ciHt/Jb31+ALrpObkm i+uRhdfnLaL/TgSx5iisDx8oa2dHT9fFdkOLdU6O7ZPK+dn7EAggLqua0BvU3VfxhObNTb7SMLkkP FFVc2DrYie7LqsBs5DcZArvp/JgY2w2/ntD7ar5UtnOhIUyzpfmAUkYYnow4ac+lZDx8dOOeYyXxa yMxD05OQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sor1y-0000000EFng-2ZIN; Thu, 12 Sep 2024 21:07:10 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sor0r-0000000EFbd-3Dqf for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 21:06:04 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3787ddbd5a2so957115f8f.0 for ; Thu, 12 Sep 2024 14:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726175160; x=1726779960; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dCFCtYRF0r0oUa2Y3h+lyp5YSyFCuvNcC5gH+noZfs8=; b=fGQp+JVg64ZOoAjB2/ZtEEccBQjEXAkYD6uS04cym51+icAutrzSwXtaX5OemFKHYQ WeLdeojgktAL09Zn5AuQA11Hhgb/asotPNx59i+IEHC/vKhNDbKJvsJ1jHwbWqa5kUqf EFU1P1OKGXvlVac4MSf17X8XQEvz47v7STIQaZuwqo0Nu84wHr6vTtDXYFqP8rRdpWsE GMIw8hOlib4/kmIXLg1OgVpJjNtvhYmDHK9ezAibQqCOMmyTMHjs5lys1BEsaFj8D/Og lhRRxkOe6D8GWUo3aP0w3TkfvWEZ6uGcg1IdfeUXOvMFweSA9UzVR7OlL0J1x3P7yrIM uwag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726175160; x=1726779960; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dCFCtYRF0r0oUa2Y3h+lyp5YSyFCuvNcC5gH+noZfs8=; b=eWg1TRiZ2ulmFw6WMuyiIkTXfmWZ7tzHTOic1IVas3malMqyVKi2ybrRuH79R0MFa0 nmZsLsJkWG0iPPfXcC8b3KkJ+C45Rnl33halsMsPk64ZjsAaYL1DGvEGZLco4DrDWrxM BFmcloxC/kc5b8aQdOCgIlFfd99YcWYWOgh/t1T55cRhrhBQ+hZs1fZ3EIH7O1mbaKTz LdKwEaKzZdAslHIpXF5Rp+BEDD/rLz0pOVtOoBTpZ5cG+SJlofvihOBpZgLbeMzRI+2Y a0OnhNuVoxsD1BxIYsvokusa5pP/A2JBR6a3ArrG8o3JeFk7yuhpZ0r6xAhBiArPpP3n dtjQ== X-Forwarded-Encrypted: i=1; AJvYcCWUDVeWacPuFkZ6uqSQkcXNWJJvu4y7Cgqmv9qM0NqAs7yFPt32dqpVCLVMwhjVqCSyDL4/0pbQKD4x15FmulZz@lists.infradead.org X-Gm-Message-State: AOJu0YxNo6OcQozmKMS9GqDHM9EuPqjiFs5mJFUJADahwuEovcf1naBF qXTgoSrPlahCa7j4RzvnzyVTdx2MZT0JQ4T+0bOCM2Cg/qYkC8GI X-Google-Smtp-Source: AGHT+IE6dRu5huMEssWnMsPIy2t6zBPfrKMsG6Pz+edE4URaDTNGGNiP4KPcM+oZQLgD+z2/2tnhVw== X-Received: by 2002:a05:6000:c86:b0:374:b3a3:3f83 with SMTP id ffacd0b85a97d-378c2d617cemr2360491f8f.53.1726175159433; Thu, 12 Sep 2024 14:05:59 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378956dd932sm15173971f8f.98.2024.09.12.14.05.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 14:05:58 -0700 (PDT) Message-ID: <1ea7fff0-149d-408a-b5a7-1b223e8509d0@gmail.com> Date: Thu, 12 Sep 2024 14:05:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/6] firmware: arm_scmi: Use max-rx-timeout-ms from devicetree To: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, devicetree@vger.kernel.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, vincent.guittot@linaro.org, etienne.carriere@st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, quic_nkela@quicinc.com, dan.carpenter@linaro.org, souvik.chakravarty@arm.com, robh@kernel.org, krzk+dt@kernel.org, Peng Fan References: <20240730144707.1647025-1-cristian.marussi@arm.com> <20240730144707.1647025-4-cristian.marussi@arm.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCZtdNBQUJMNWh3gAKCRBhV5kVtWN2DhBgAJ9D8p3pChCfpxunOzIK7lyt +uv8dQCgrNubjaY9TotNykglHlGg2NB0iOLOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== In-Reply-To: <20240730144707.1647025-4-cristian.marussi@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_140601_844587_D5520615 X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/30/24 07:47, Cristian Marussi wrote: > Override default maximum RX timeout with the value picked from the > devicetree, when provided. > > Suggested-by: Peng Fan > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/driver.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 332cd5207bbc..e7dab0eea540 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -2964,6 +2964,7 @@ static int scmi_debugfs_raw_mode_setup(struct scmi_info *info) > static const struct scmi_desc *scmi_transport_setup(struct device *dev) > { > struct scmi_transport *trans; > + int ret; > > trans = dev_get_platdata(dev); > if (!trans || !trans->desc || !trans->supplier || !trans->core_ops) > @@ -2980,6 +2981,14 @@ static const struct scmi_desc *scmi_transport_setup(struct device *dev) > > dev_info(dev, "Using %s\n", dev_driver_string(trans->supplier)); > > + ret = of_property_read_u32(dev->of_node, "max-rx-timeout-ms", > + &trans->desc->max_rx_timeout_ms); > + if (ret && ret != -EINVAL) > + dev_err(dev, "Malformed max-rx-timeout-ms DT property.\n"); > + > + dev_info(dev, "SCMI max-rx-timeout: %dms\n", > + trans->desc->max_rx_timeout_ms); I am bit on the fence on that change, it is useful, and we have done similar things before using a command line parameter. This is definitively useful when bringing up new systems where you might be sprinkling enough debugging messages that this pushes your message processing logic too close to the default 30ms timeout. For normal use cases, we really want the message timeout to be as small as possible for most SCMI traffic but if we want the timeout to be configurable, that might have have to be on a per-message basis. -- Florian