From: Krzysztof Kozlowski <krzk@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/8] dt-bindings: Add Tegra264 clock and reset definitions
Date: Thu, 8 May 2025 09:40:02 +0200 [thread overview]
Message-ID: <1ec7ed24-a4fe-450b-8f99-34aae6ed2c4d@kernel.org> (raw)
In-Reply-To: <20250507143802.1230919-5-thierry.reding@gmail.com>
On 07/05/2025 16:37, Thierry Reding wrote:
> @@ -0,0 +1,9 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/* Copyright (c) 2022-2023, NVIDIA CORPORATION. All rights reserved. */
> +
> +#ifndef DT_BINDINGS_CLOCK_TEGRA264_CLOCK_H
> +#define DT_BINDINGS_CLOCK_TEGRA264_CLOCK_H
> +
> +#define TEGRA264_CLK_CLK_S 2U
Abstract IDs start from 0 or 1, not 2. Also drop "U".
> +
> +#endif /* DT_BINDINGS_CLOCK_TEGRA264_CLOCK_H */
> diff --git a/include/dt-bindings/reset/tegra264-reset.h b/include/dt-bindings/reset/tegra264-reset.h
> new file mode 100644
> index 000000000000..31d89dcf62fa
> --- /dev/null
> +++ b/include/dt-bindings/reset/tegra264-reset.h
> @@ -0,0 +1,7 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/* Copyright (c) 2022-2023, NVIDIA CORPORATION. All rights reserved. */
> +
> +#ifndef DT_BINDINGS_RESET_TEGRA264_RESET_H
> +#define DT_BINDINGS_RESET_TEGRA264_RESET_H
> +
This is empty, drop.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-08 7:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 14:37 [PATCH 0/8] Add more Tegra264 support Thierry Reding
2025-05-07 14:37 ` [PATCH 1/8] dt-bindings: dma: Add Tegra264 compatible string Thierry Reding
2025-05-14 19:32 ` Rob Herring
2025-05-07 14:37 ` [PATCH 2/8] dt-bindings: rtc: tegra: Document Tegra264 RTC Thierry Reding
2025-05-14 19:32 ` Rob Herring (Arm)
2025-05-07 14:37 ` [PATCH 3/8] dt-bindings: tegra: Document P3971-0089+P3834-0008 Platform Thierry Reding
2025-05-14 19:32 ` Rob Herring (Arm)
2025-05-07 14:37 ` [PATCH 4/8] dt-bindings: Add Tegra264 clock and reset definitions Thierry Reding
2025-05-08 7:39 ` Krzysztof Kozlowski
2025-05-08 7:40 ` Krzysztof Kozlowski
2025-05-08 7:46 ` Thierry Reding
2025-05-08 7:49 ` Krzysztof Kozlowski
2025-05-08 7:59 ` Thierry Reding
2025-05-08 8:51 ` Krzysztof Kozlowski
2025-05-08 8:58 ` Thierry Reding
2025-05-08 7:40 ` Krzysztof Kozlowski [this message]
2025-05-08 7:53 ` Thierry Reding
2025-05-08 8:42 ` Krzysztof Kozlowski
2025-05-08 9:04 ` Thierry Reding
2025-05-07 14:37 ` [PATCH 5/8] dt-bindings: memory: Add Tegra264 definitions Thierry Reding
2025-05-08 5:48 ` Krzysztof Kozlowski
2025-05-08 7:31 ` Thierry Reding
2025-05-08 7:37 ` Krzysztof Kozlowski
2025-05-08 8:02 ` Thierry Reding
2025-05-08 8:45 ` Krzysztof Kozlowski
2025-05-08 9:09 ` Thierry Reding
2025-05-14 19:31 ` Rob Herring
2025-05-07 14:38 ` [PATCH 6/8] arm64: tegra: Add Tegra264 support Thierry Reding
2025-05-07 14:38 ` [PATCH 7/8] arm64: tegra: Add p3971-0089+p3834-0008 support Thierry Reding
2025-05-07 14:38 ` [PATCH 8/8] arm64: defconfig: Enable Tegra241 and Tegra264 Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ec7ed24-a4fe-450b-8f99-34aae6ed2c4d@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).