From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 631D8C433FE for ; Tue, 22 Nov 2022 01:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:CC:References:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Jc26g0stkt/3e3bDu7bDAGb6ABxy5j5Q4Kdmf+h/XXY=; b=AZMuolAfcxllOVuJhfHSxo41CF HI2yfU9RQa3Ma+p9bLJ5dAfbJyFC0xHEj53RmSYCXV9E3UsEVf/WdjkDlcXC6uGHri7S7K5bLRxpk qUFnNJjjQMfJHwEkvsBC7xUGRBif6+CUX+mHIGWpDZmH6p6uE9RAF5F0BL0P8qu3YvXw6FKyskwXA EKRKK7odl6OwU385izc5woDfB5Nzwr+8Y4Ch4mA6FP6U6E5TeJ9W9L+jrHcb9nQ/8l7bkJ3VVBpua m3ZX4Bj8jeF9EbDscoDsTX1RNGiPL5uyfGtzZ9F/wBcgMPkrqx1j+baxsPehXXs5k9Xr3Y4PUVmGO vvlK1RWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxI28-001t1G-C2; Tue, 22 Nov 2022 01:25:08 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxI25-001szr-42 for linux-arm-kernel@lists.infradead.org; Tue, 22 Nov 2022 01:25:07 +0000 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NGRLJ0LYgzFqRT; Tue, 22 Nov 2022 09:21:44 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 22 Nov 2022 09:24:58 +0800 Received: from [10.174.179.24] (10.174.179.24) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 22 Nov 2022 09:24:58 +0800 Subject: Re: [PATCH v2 2/2] arm64/mm: fix incorrect file_map_count for invalid pmd/pud To: Will Deacon References: <20221117075602.2904324-1-liushixin2@huawei.com> <20221117075602.2904324-3-liushixin2@huawei.com> <20221118143414.GG4046@willie-the-truck> <10cecbdf-eb06-873d-6b79-bfdb3197d2ec@huawei.com> <20221121181636.GD7645@willie-the-truck> CC: Catalin Marinas , Denys Vlasenko , Kefeng Wang , "Anshuman Khandual" , David Hildenbrand , Rafael Aquini , Pasha Tatashin , , From: Liu Shixin Message-ID: <1f4ef941-6b45-8562-1723-21048a639c18@huawei.com> Date: Tue, 22 Nov 2022 09:24:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20221121181636.GD7645@willie-the-truck> X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_172505_360793_30896E18 X-CRM114-Status: GOOD ( 13.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/11/22 2:16, Will Deacon wrote: > On Mon, Nov 21, 2022 at 11:15:49AM +0800, Liu Shixin wrote: >> On 2022/11/18 22:34, Will Deacon wrote: >>> On Thu, Nov 17, 2022 at 03:56:02PM +0800, Liu Shixin wrote: >>>> static inline bool pud_user_accessible_page(pud_t pud) >>>> { >>>> - return pud_leaf(pud) && pud_user(pud); >>>> + return pud_valid(pud) && pud_leaf(pud) && pud_user(pud); >>> Not caused by this patch, but why don't we have something like a >>> pud_user_exec() check here like we do for the pte and pmd levels? >> As far as I know, there is no user use the user executable pud on arm64, so didn't define pud_user_exec(). > I can believe they don't get exposed to userspace at all, but exposing only > as non-executable doesn't sound right. So I would have thought that either > pud_user_accessible_page() would always return false or it would need to > check for the executable case too. Thanks for your advice, I will add the check for the executable case too. > > Will > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel